Merge pull request #13164 from djyasin/6116-incorrect-error-messages

Fix for incorrect error messages on incomplete credentials.
This commit is contained in:
Lila Yasin 2022-12-01 14:19:11 -05:00 committed by GitHub
commit 6289bfb639
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -1351,12 +1351,12 @@ class UnifiedJob(
if required in defined_fields and not credential.has_input(required):
missing_credential_inputs.append(required)
if missing_credential_inputs:
self.job_explanation = '{} cannot start because Credential {} does not provide one or more required fields ({}).'.format(
self._meta.verbose_name.title(), credential.name, ', '.join(sorted(missing_credential_inputs))
)
self.save(update_fields=['job_explanation'])
return (False, None)
if missing_credential_inputs:
self.job_explanation = '{} cannot start because Credential {} does not provide one or more required fields ({}).'.format(
self._meta.verbose_name.title(), credential.name, ', '.join(sorted(missing_credential_inputs))
)
self.save(update_fields=['job_explanation'])
return (False, None)
needed = self.get_passwords_needed_to_start()
try: