mirror of
https://github.com/ansible/awx.git
synced 2026-01-16 12:20:45 -03:30
Adds react-hooks eslint rules and fixes a few warnings
This commit is contained in:
parent
8bfbd85cf9
commit
68a6315626
@ -8,6 +8,9 @@
|
||||
"modules": true
|
||||
}
|
||||
},
|
||||
"plugins": [
|
||||
"react-hooks"
|
||||
],
|
||||
"extends": ["airbnb", "prettier", "prettier/react"],
|
||||
"settings": {
|
||||
"import/resolver": {
|
||||
@ -56,6 +59,8 @@
|
||||
"react/prop-types": "off",
|
||||
"react/sort-comp": ["error", {}],
|
||||
"jsx-a11y/label-has-for": "off",
|
||||
"jsx-a11y/label-has-associated-control": "off"
|
||||
"jsx-a11y/label-has-associated-control": "off",
|
||||
"react-hooks/rules-of-hooks": "error",
|
||||
"react-hooks/exhaustive-deps": "warn"
|
||||
}
|
||||
}
|
||||
|
||||
@ -19,7 +19,7 @@ function ExpandingContainer({ isExpanded, children }) {
|
||||
});
|
||||
useEffect(() => {
|
||||
setContentHeight(ref.current.scrollHeight);
|
||||
});
|
||||
}, [setContentHeight]);
|
||||
const height = isExpanded ? contentHeight : '0';
|
||||
return (
|
||||
<Container
|
||||
|
||||
@ -120,7 +120,7 @@ function HostEventModal({ onClose, hostEvent = {}, isOpen = false, i18n }) {
|
||||
|
||||
useEffect(() => {
|
||||
setHostStatus(processEventStatus(hostEvent));
|
||||
}, []);
|
||||
}, [setHostStatus, hostEvent]);
|
||||
|
||||
const handleTabClick = (event, tabIndex) => {
|
||||
setActiveTabKey(tabIndex);
|
||||
|
||||
@ -108,7 +108,7 @@ function ProjectForm({ project, ...props }) {
|
||||
}
|
||||
|
||||
fetchData();
|
||||
}, []);
|
||||
}, [summary_fields.credential]);
|
||||
|
||||
const scmFormFields = {
|
||||
scm_url: '',
|
||||
|
||||
@ -33,7 +33,7 @@ function LabelSelect({ value, onChange, onError }) {
|
||||
const [options, setOptions] = useState([]);
|
||||
useEffect(() => {
|
||||
loadLabelOptions(setOptions, onError);
|
||||
}, []);
|
||||
}, [onError]);
|
||||
|
||||
return (
|
||||
<MultiSelect
|
||||
|
||||
@ -39,7 +39,7 @@ function PlaybookSelect({
|
||||
onError(contentError);
|
||||
}
|
||||
})();
|
||||
}, [projectId]);
|
||||
}, [projectId, i18n, onError]);
|
||||
|
||||
return (
|
||||
<AnsibleSelect
|
||||
|
||||
Loading…
x
Reference in New Issue
Block a user