Adds react-hooks eslint rules and fixes a few warnings

This commit is contained in:
mabashian 2019-11-11 14:56:25 -05:00
parent 8bfbd85cf9
commit 68a6315626
6 changed files with 11 additions and 6 deletions

View File

@ -8,6 +8,9 @@
"modules": true
}
},
"plugins": [
"react-hooks"
],
"extends": ["airbnb", "prettier", "prettier/react"],
"settings": {
"import/resolver": {
@ -56,6 +59,8 @@
"react/prop-types": "off",
"react/sort-comp": ["error", {}],
"jsx-a11y/label-has-for": "off",
"jsx-a11y/label-has-associated-control": "off"
"jsx-a11y/label-has-associated-control": "off",
"react-hooks/rules-of-hooks": "error",
"react-hooks/exhaustive-deps": "warn"
}
}

View File

@ -19,7 +19,7 @@ function ExpandingContainer({ isExpanded, children }) {
});
useEffect(() => {
setContentHeight(ref.current.scrollHeight);
});
}, [setContentHeight]);
const height = isExpanded ? contentHeight : '0';
return (
<Container

View File

@ -120,7 +120,7 @@ function HostEventModal({ onClose, hostEvent = {}, isOpen = false, i18n }) {
useEffect(() => {
setHostStatus(processEventStatus(hostEvent));
}, []);
}, [setHostStatus, hostEvent]);
const handleTabClick = (event, tabIndex) => {
setActiveTabKey(tabIndex);

View File

@ -108,7 +108,7 @@ function ProjectForm({ project, ...props }) {
}
fetchData();
}, []);
}, [summary_fields.credential]);
const scmFormFields = {
scm_url: '',

View File

@ -33,7 +33,7 @@ function LabelSelect({ value, onChange, onError }) {
const [options, setOptions] = useState([]);
useEffect(() => {
loadLabelOptions(setOptions, onError);
}, []);
}, [onError]);
return (
<MultiSelect

View File

@ -39,7 +39,7 @@ function PlaybookSelect({
onError(contentError);
}
})();
}, [projectId]);
}, [projectId, i18n, onError]);
return (
<AnsibleSelect