External-Mirrors/awx
2
0
Fork 0
mirror of https://github.com/ansible/awx.git synced 2026-05-07 17:37:37 -02:30
Code Issues Packages Projects Releases Wiki Activity

Adds react-hooks eslint rules and fixes a few warnings

Browse Source
This commit is contained in:
mabashian
2019-11-11 14:56:25 -05:00
parent 8bfbd85cf9
commit 68a6315626
6 changed files with 11 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
awx/ui_next/.eslintrc
View File

@@ -8,6 +8,9 @@
"modules": true "modules": true
} }
}, },
"plugins": [
"react-hooks"
],
"extends": ["airbnb", "prettier", "prettier/react"], "extends": ["airbnb", "prettier", "prettier/react"],
"settings": { "settings": {
"import/resolver": { "import/resolver": {
@@ -56,6 +59,8 @@
"react/prop-types": "off", "react/prop-types": "off",
"react/sort-comp": ["error", {}], "react/sort-comp": ["error", {}],
"jsx-a11y/label-has-for": "off", "jsx-a11y/label-has-for": "off",
"jsx-a11y/label-has-associated-control": "off" "jsx-a11y/label-has-associated-control": "off",
"react-hooks/rules-of-hooks": "error",
"react-hooks/exhaustive-deps": "warn"
} }
} }

2
awx/ui_next/src/components/CollapsibleSection/ExpandingContainer.jsx
View File

@@ -19,7 +19,7 @@ function ExpandingContainer({ isExpanded, children }) {
}); });
useEffect(() => { useEffect(() => {
setContentHeight(ref.current.scrollHeight); setContentHeight(ref.current.scrollHeight);
}); }, [setContentHeight]);
const height = isExpanded ? contentHeight : '0'; const height = isExpanded ? contentHeight : '0';
return ( return (
<Container <Container

2
awx/ui_next/src/screens/Job/JobOutput/HostEventModal.jsx
View File

@@ -120,7 +120,7 @@ function HostEventModal({ onClose, hostEvent = {}, isOpen = false, i18n }) {
useEffect(() => { useEffect(() => {
setHostStatus(processEventStatus(hostEvent)); setHostStatus(processEventStatus(hostEvent));
}, []); }, [setHostStatus, hostEvent]);
const handleTabClick = (event, tabIndex) => { const handleTabClick = (event, tabIndex) => {
setActiveTabKey(tabIndex); setActiveTabKey(tabIndex);

2
awx/ui_next/src/screens/Project/shared/ProjectForm.jsx
View File

@@ -108,7 +108,7 @@ function ProjectForm({ project, ...props }) {
} }
fetchData(); fetchData();
}, []); }, [summary_fields.credential]);
const scmFormFields = { const scmFormFields = {
scm_url: '', scm_url: '',

2
awx/ui_next/src/screens/Template/shared/LabelSelect.jsx
View File

@@ -33,7 +33,7 @@ function LabelSelect({ value, onChange, onError }) {
const [options, setOptions] = useState([]); const [options, setOptions] = useState([]);
useEffect(() => { useEffect(() => {
loadLabelOptions(setOptions, onError); loadLabelOptions(setOptions, onError);
}, []); }, [onError]);
return ( return (
<MultiSelect <MultiSelect

2
awx/ui_next/src/screens/Template/shared/PlaybookSelect.jsx
View File

@@ -39,7 +39,7 @@ function PlaybookSelect({
onError(contentError); onError(contentError);
} }
})(); })();
}, [projectId]); }, [projectId, i18n, onError]);
return ( return (
<AnsibleSelect <AnsibleSelect