Merge pull request #181 from jakemcdermott/page-header-method-names

use 'handle' notation for header toolbar methods
This commit is contained in:
Jake McDermott
2019-04-29 14:39:43 -04:00
committed by GitHub

View File

@@ -28,29 +28,29 @@ class PageHeaderToolbar extends Component {
isUserOpen: false, isUserOpen: false,
}; };
this.onHelpSelect = this.onHelpSelect.bind(this); this.handleHelpSelect = this.handleHelpSelect.bind(this);
this.onHelpToggle = this.onHelpToggle.bind(this); this.handleHelpToggle = this.handleHelpToggle.bind(this);
this.onUserSelect = this.onUserSelect.bind(this); this.handleUserSelect = this.handleUserSelect.bind(this);
this.onUserToggle = this.onUserToggle.bind(this); this.handleUserToggle = this.handleUserToggle.bind(this);
} }
onHelpSelect () { handleHelpSelect () {
const { isHelpOpen } = this.state; const { isHelpOpen } = this.state;
this.setState({ isHelpOpen: !isHelpOpen }); this.setState({ isHelpOpen: !isHelpOpen });
} }
onUserSelect () { handleUserSelect () {
const { isUserOpen } = this.state; const { isUserOpen } = this.state;
this.setState({ isUserOpen: !isUserOpen }); this.setState({ isUserOpen: !isUserOpen });
} }
onHelpToggle (isOpen) { handleHelpToggle (isOpen) {
this.setState({ isHelpOpen: isOpen }); this.setState({ isHelpOpen: isOpen });
} }
onUserToggle (isOpen) { handleUserToggle (isOpen) {
this.setState({ isUserOpen: isOpen }); this.setState({ isUserOpen: isOpen });
} }
@@ -74,10 +74,10 @@ class PageHeaderToolbar extends Component {
isPlain isPlain
isOpen={isHelpOpen} isOpen={isHelpOpen}
position={DropdownPosition.right} position={DropdownPosition.right}
onSelect={this.onHelpSelect} onSelect={this.handleHelpSelect}
toggle={( toggle={(
<DropdownToggle <DropdownToggle
onToggle={this.onHelpToggle} onToggle={this.handleHelpToggle}
> >
<QuestionCircleIcon /> <QuestionCircleIcon />
</DropdownToggle> </DropdownToggle>
@@ -113,10 +113,10 @@ class PageHeaderToolbar extends Component {
isPlain isPlain
isOpen={isUserOpen} isOpen={isUserOpen}
position={DropdownPosition.right} position={DropdownPosition.right}
onSelect={this.onUserSelect} onSelect={this.handleUserSelect}
toggle={( toggle={(
<DropdownToggle <DropdownToggle
onToggle={this.onUserToggle} onToggle={this.handleUserToggle}
> >
<UserIcon /> <UserIcon />
&nbsp; User Name &nbsp; User Name