Merge pull request #5253 from shanemcd/stop-requiring-pg-admin-when-we-dont-need-it

Dont require pg_admin_password unless we're using it.

installer/inventory

@@ -84,11 +84,14 @@ pg_username=awx
 # pg_password should be random 10 character alphanumeric string, when postgresql is running on kubernetes
 # NB: it's a limitation of the "official" postgres helm chart
 pg_password=awxpass
-pg_admin_password=postgrespass
 pg_database=awx
 pg_port=5432
 #pg_sslmode=require
 
+# The following variable is only required when using the provided
+# containerized postgres deployment on OpenShift
+# pg_admin_password=postgrespass
+
 # RabbitMQ Configuration
 rabbitmq_password=awxpass
 rabbitmq_erlang_cookie=cookiemonster

installer/roles/check_vars/tasks/check_openshift.yml

@@ -46,3 +46,10 @@
     - docker_registry_password is defined and docker_registry_password != ''
     msg: "Set the value of 'docker_registry_password' in the inventory file."
   when: dockerhub_base is not defined
+
+- name: pg_admin_password should be defined
+  assert:
+    that:
+      - pg_admin_password is defined and pg_admin_password != ''
+  when:
+    - pg_hostname is not defined or pg_hostname == ''

installer/roles/kubernetes/templates/environment.sh.j2

@@ -3,7 +3,9 @@ DATABASE_NAME={{ pg_database }}
 DATABASE_HOST={{ pg_hostname|default('postgresql') }}
 DATABASE_PORT={{ pg_port|default('5432') }}
 DATABASE_PASSWORD={{ pg_password | quote }}
-DATABASE_ADMIN_PASSWORD={{ pg_admin_password | quote }}
+{% if pg_admin_password is defined %}
+DATABASE_ADMIN_PASSWORD={{ pg_admin_password|quote }}
+{% endif %}
 MEMCACHED_HOST={{ memcached_hostname|default('localhost') }}
 MEMCACHED_PORT={{ memcached_port|default('11211') }}
 RABBITMQ_HOST={{ rabbitmq_hostname|default('localhost') }}

installer/roles/local_docker/templates/environment.sh.j2

@@ -3,7 +3,9 @@ DATABASE_NAME={{ pg_database|quote }}
 DATABASE_HOST={{ pg_hostname|default('postgres')|quote }}
 DATABASE_PORT={{ pg_port|default('5432')|quote }}
 DATABASE_PASSWORD={{ pg_password|default('awxpass')|quote }}
-DATABASE_ADMIN_PASSWORD={{ pg_admin_password|default('postgrespass')|quote }}
+{% if pg_admin_password is defined %}
+DATABASE_ADMIN_PASSWORD={{ pg_admin_password|quote }}
+{% endif %}
 MEMCACHED_HOST={{ memcached_hostname|default('memcached') }}
 MEMCACHED_PORT={{ memcached_port|default('11211')|quote }}
 RABBITMQ_HOST={{ rabbitmq_hostname|default('rabbitmq')|quote }}