External-Mirrors/awx
2
0
Fork 0
mirror of https://github.com/ansible/awx.git synced 2026-03-13 23:17:32 -02:30
Code Issues Packages Projects Releases Wiki Activity

Add destory sanity checks to prevent UJ deletion during underlying workflow run.

Browse Source
This commit is contained in:
Aaron Tan
2016-10-26 14:53:22 -04:00
parent bf301ec130
commit 813c786dc7
1 changed files with 24 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
awx/api/views.py
View File

@@ -1087,6 +1087,14 @@ class ProjectUpdateDetail(RetrieveDestroyAPIView):
serializer_class = ProjectUpdateSerializer
new_in_13 = True
def destroy(self, request, *args, **kwargs):
obj = self.get_object()
for unified_job_node in obj.unified_job_nodes.all():
if unified_job_node.workflow_job.status in ('new', 'pending', 'waiting',
'running', 'updating'):
raise PermissionDenied()
return super(ProjectUpdateDetail, self).destroy(request, *args, **kwargs)
class ProjectUpdateCancel(RetrieveAPIView):
model = ProjectUpdate
@@ -2166,6 +2174,14 @@ class InventoryUpdateDetail(RetrieveDestroyAPIView):
serializer_class = InventoryUpdateSerializer
new_in_14 = True
def destroy(self, request, *args, **kwargs):
obj = self.get_object()
for unified_job_node in obj.unified_job_nodes.all():
if unified_job_node.workflow_job.status in ('new', 'pending', 'waiting',
'running', 'updating'):
raise PermissionDenied()
return super(InventoryUpdateDetail, self).destroy(request, *args, **kwargs)
class InventoryUpdateCancel(RetrieveAPIView):
model = InventoryUpdate
@@ -2869,6 +2885,14 @@ class JobDetail(RetrieveUpdateDestroyAPIView):
return self.http_method_not_allowed(request, *args, **kwargs)
return super(JobDetail, self).update(request, *args, **kwargs)
def destroy(self, request, *args, **kwargs):
obj = self.get_object()
for unified_job_node in obj.unified_job_nodes.all():
if unified_job_node.workflow_job.status in ('new', 'pending', 'waiting',
'running', 'updating'):
raise PermissionDenied()
return super(JobDetail, self).destroy(request, *args, **kwargs)
class JobLabelList(SubListAPIView):
model = Label