Merge pull request #4836 from fosterseth/fix-4334-active-user-removed

check if User exists before saving UserSessionMembership

Reviewed-by: https://github.com/apps/softwarefactory-project-zuul
This commit is contained in:
softwarefactory-project-zuul[bot]
2019-10-01 19:59:11 +00:00
committed by GitHub

View File

@@ -684,6 +684,8 @@ def save_user_session_membership(sender, **kwargs):
return return
if UserSessionMembership.objects.filter(user=user_id, session=session).exists(): if UserSessionMembership.objects.filter(user=user_id, session=session).exists():
return return
# check if user_id from session has an id match in User before saving
if User.objects.filter(id=int(user_id)).exists():
UserSessionMembership(user_id=user_id, session=session, created=timezone.now()).save() UserSessionMembership(user_id=user_id, session=session, created=timezone.now()).save()
expired = UserSessionMembership.get_memberships_over_limit(user_id) expired = UserSessionMembership.get_memberships_over_limit(user_id)
for membership in expired: for membership in expired: