check expired sessions only if User exists

- Indent rest of code into the conditional
  that checks for expired sessions of that User
- If user doesn't exist, no need to check
This commit is contained in:
Seth Foster 2019-09-27 12:31:10 -04:00
parent 94fa745859
commit b6ffde75ef
No known key found for this signature in database
GPG Key ID: DECBFA46ED79BAEA

View File

@ -687,15 +687,15 @@ def save_user_session_membership(sender, **kwargs):
# check if user_id from session has an id match in User before saving
if User.objects.filter(id=int(user_id)).exists():
UserSessionMembership(user_id=user_id, session=session, created=timezone.now()).save()
expired = UserSessionMembership.get_memberships_over_limit(user_id)
for membership in expired:
Session.objects.filter(session_key__in=[membership.session_id]).delete()
membership.delete()
if len(expired):
consumers.emit_channel_notification(
'control-limit_reached_{}'.format(user_id),
dict(group_name='control', reason='limit_reached')
)
expired = UserSessionMembership.get_memberships_over_limit(user_id)
for membership in expired:
Session.objects.filter(session_key__in=[membership.session_id]).delete()
membership.delete()
if len(expired):
consumers.emit_channel_notification(
'control-limit_reached_{}'.format(user_id),
dict(group_name='control', reason='limit_reached')
)
@receiver(post_save, sender=OAuth2AccessToken)