Fixes Credential Type Issue, ExtraVars Toggle Issue, Job Results Inert Link

This commit is contained in:
Alex Corey 2019-09-30 12:53:39 -04:00 committed by Shane McDonald
parent 59413e0a8f
commit 958c8a4177
No known key found for this signature in database
GPG Key ID: 6F374AF6E9EB9374
3 changed files with 9 additions and 10 deletions

View File

@ -559,7 +559,7 @@ function getInstanceGroupDetails () {
let link = `/#/instance_groups/${instanceGroup.id}`;
if (instanceGroup.is_containerized) {
label = strings.get('labels.CONTAINER_GROUP');
link = `/#/instance_groups/container_group/edit/${instanceGroup.id}`;
link = `/#/instance_groups/container_group/${instanceGroup.id}`;
}
let isolated = null;

View File

@ -92,7 +92,7 @@ function EditContainerGroupController($rootScope, $scope, $state, models, string
const podSpecValue = sanitizeVars(EditContainerGroupDataset.data.pod_spec_override);
const defaultPodSpecValue = sanitizeVars(instanceGroup.model.OPTIONS.actions.PUT.pod_spec_override.default);
if (podSpecValue && podSpecValue.trim() !== defaultPodSpecValue.trim()) {
if ((podSpecValue !== '---') && podSpecValue && podSpecValue.trim() !== defaultPodSpecValue.trim()) {
vm.form.extraVars.isOpen = true;
} else {
vm.form.extraVars.isOpen = false;

View File

@ -199,6 +199,7 @@ function InstanceGroupsRun($stateExtender, strings) {
params: {
credential_search: {
value: {
credential_type__kind: 'kubernetes',
order_by: 'name',
page_size: 5,
},
@ -228,12 +229,11 @@ function InstanceGroupsRun($stateExtender, strings) {
resolve: {
ListDefinition: ['CredentialList', list => list],
Dataset: ['ListDefinition', 'QuerySet', '$stateParams', 'GetBasePath', (list, qs, $stateParams, GetBasePath) => {
const params = {
credential_type__kind: 'kubernetes',
};
const searchPath = GetBasePath('credentials');
return qs.search(
searchPath, params,
searchPath,
$stateParams[`${list.iterator}_search`]
);
}]
@ -257,6 +257,7 @@ function InstanceGroupsRun($stateExtender, strings) {
controllerAs: 'vm'
}
},
resolve: {
resolvedModels: InstanceGroupsResolve,
EditContainerGroupDataset: ['GetBasePath', 'QuerySet', '$stateParams',
@ -278,6 +279,7 @@ function InstanceGroupsRun($stateExtender, strings) {
params: {
credential_search: {
value: {
credential_type__kind: 'kubernetes',
order_by: 'name',
page_size: 5,
},
@ -304,12 +306,9 @@ function InstanceGroupsRun($stateExtender, strings) {
resolve: {
ListDefinition: ['CredentialList', list => list],
Dataset: ['ListDefinition', 'QuerySet', '$stateParams', 'GetBasePath', (list, qs, $stateParams, GetBasePath) => {
const params = {
credential_type__kind: 'kubernetes',
};
const searchPath = GetBasePath('credentials');
return qs.search(
searchPath, params,
searchPath,
$stateParams[`${list.iterator}_search`]
);
}]