External-Mirrors/awx
2
0
Fork 0
mirror of https://github.com/ansible/awx.git synced 2026-05-24 00:57:48 -02:30
Code Issues Packages Projects Releases Wiki Activity

Fix an bug where I wouldn't properly error out when survey validation

Browse Source 
would fail
This commit is contained in:
Matthew Jones
2014-12-17 22:39:11 -05:00
parent 6f5d450e8d
commit a130ac88dd
1 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
awx/api/views.py
View File

@@ -1486,11 +1486,10 @@ class JobTemplateLaunch(GenericAPIView):
request_data = {} request_data = {}
else: else:
request_data = request.DATA request_data = request.DATA
if 'extra_vars' in request_data: validation_errors = obj.survey_variable_validation(request_data.get('extra_vars', {}))
validation_errors = obj.survey_variable_validation(request_data['extra_vars']) if validation_errors:
if validation_errors: return Response(dict(errors=validation_errors),
return Response(dict(errors=validation_errors), status=status.HTTP_400_BAD_REQUEST)
status=status.HTTP_400_BAD_REQUEST)
if obj.credential is None and ('credential' not in request.DATA and 'credential_id' not in request.DATA): if obj.credential is None and ('credential' not in request.DATA and 'credential_id' not in request.DATA):
return Response(dict(errors="Credential not provided"), status=status.HTTP_400_BAD_REQUEST) return Response(dict(errors="Credential not provided"), status=status.HTTP_400_BAD_REQUEST)
new_job = obj.create_unified_job(**request.DATA) new_job = obj.create_unified_job(**request.DATA)