put FormGroup component in form instead of in AnsibleSelect component

This commit is contained in:
John Mitchell
2019-02-13 15:40:46 -05:00
parent f2ab7f62b9
commit b4007c7e04
2 changed files with 14 additions and 17 deletions

View File

@@ -1,7 +1,6 @@
import React from 'react'; import React from 'react';
import { import {
FormGroup,
Select, Select,
SelectOption, SelectOption,
} from '@patternfly/react-core'; } from '@patternfly/react-core';
@@ -33,17 +32,15 @@ class AnsibleSelect extends React.Component {
render () { render () {
const { count } = this.state; const { count } = this.state;
const { labelName, value, data, fieldId } = this.props; const { value, data } = this.props;
let elem; let elem;
if (count > 1) { if (count > 1) {
elem = ( elem = (
<FormGroup label={labelName} fieldId={fieldId || 'ansible-select'}> <Select value={value} onChange={this.onSelectChange} aria-label="Select Input">
<Select value={value} id={`select-${fieldId}` || 'ansible-select-element'} onChange={this.onSelectChange} aria-label="Select Input">
{data.map((datum) => ( {data.map((datum) => (
<SelectOption isDisabled={datum.disabled} key={datum} value={datum} label={datum} /> <SelectOption isDisabled={datum.disabled} key={datum} value={datum} label={datum} />
))} ))}
</Select> </Select>
</FormGroup>
); );
} else { } else {
elem = null; elem = null;

View File

@@ -135,14 +135,14 @@ class OrganizationAdd extends React.Component {
</FormGroup> </FormGroup>
<ConfigContext.Consumer> <ConfigContext.Consumer>
{({ custom_virtualenvs }) => ( {({ custom_virtualenvs }) => (
<FormGroup label="Ansible Environment" fieldId="add-org-form-custom-virtualenv">
<AnsibleSelect <AnsibleSelect
fieldId="add-org-form-virtual-env"
labelName="Ansible Environment"
name="custom_virtualenv" name="custom_virtualenv"
value={custom_virtualenv} value={custom_virtualenv}
onChange={this.onFieldChange} onChange={this.onFieldChange}
data={custom_virtualenvs} data={custom_virtualenvs}
/> />
</FormGroup>
)} )}
</ConfigContext.Consumer> </ConfigContext.Consumer>
</Gallery> </Gallery>