Merge pull request #1735 from mabashian/1732-schedule

Only initialize extra vars if they are promptable
This commit is contained in:
Michael Abashian 2018-05-10 09:30:51 -04:00 committed by GitHub
commit c3816a9812
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -92,14 +92,6 @@ export default ['$filter', '$state', '$stateParams', '$http', 'Wait',
// extra_data field is not manifested in the UI when scheduling a Management Job
if ($state.current.name === 'jobTemplateSchedules.add'){
$scope.parseType = 'yaml';
$scope.extraVars = ParentObject.extra_vars === '' ? '---' : ParentObject.extra_vars;
ParseTypeChange({
scope: $scope,
variable: 'extraVars',
parse_variable: 'parseType',
field_id: 'SchedulerForm-extraVars'
});
let jobTemplate = new JobTemplate();
@ -126,7 +118,16 @@ export default ['$filter', '$state', '$stateParams', '$http', 'Wait',
});
};
if (!launchConf.ask_variables_on_launch) {
if (launchConf.ask_variables_on_launch) {
$scope.extraVars = ParentObject.extra_vars === '' ? '---' : ParentObject.extra_vars;
ParseTypeChange({
scope: $scope,
variable: 'extraVars',
parse_variable: 'parseType',
field_id: 'SchedulerForm-extraVars'
});
} else {
$scope.noVars = true;
}