Fixes bug where all_parents_must_converge was not being set for new or existing approval nodes.

This commit is contained in:
mabashian 2020-05-18 13:23:19 -04:00
parent cdfc9e05d4
commit c4d9b81c55

View File

@ -148,11 +148,14 @@ export default ['$scope', 'TemplatesService',
Object.keys(nodeRef).map((workflowMakerNodeId) => {
const node = nodeRef[workflowMakerNodeId];
const all_parents_must_converge = _.get(node, 'all_parents_must_converge', false);
if (node.isNew) {
if (node.unifiedJobTemplate && node.unifiedJobTemplate.unified_job_type === "workflow_approval") {
addPromises.push(TemplatesService.addWorkflowNode({
url: $scope.workflowJobTemplateObj.related.workflow_nodes,
data: {}
data: {
all_parents_must_converge
}
}).then(({data: newNodeData}) => {
Rest.setUrl(newNodeData.related.create_approval_template);
approvalTemplatePromises.push(Rest.post({
@ -234,6 +237,14 @@ export default ['$scope', 'TemplatesService',
});
}));
}
if (node.originalNodeObject.all_parents_must_converge !== all_parents_must_converge) {
editPromises.push(TemplatesService.editWorkflowNode({
id: node.originalNodeObject.id,
data: {
all_parents_must_converge
}
}));
}
} else {
editPromises.push(TemplatesService.editWorkflowNode({
id: node.originalNodeObject.id,