External-Mirrors/awx
2
0
Fork 0
mirror of https://github.com/ansible/awx.git synced 2026-01-11 10:00:01 -03:30
Code Issues Packages Projects Releases Wiki Activity

'managed' is a read-only field on InstanceSerializer

Browse Source 
so we don't need complex logic to compare an incoming to existing value.
This commit is contained in:
Jeff Bradberry 2024-01-24 15:24:03 -05:00 committed by Seth Foster
parent 1e254c804c
commit cc4cc37d46
1 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
awx/api/serializers.py
View File

@ -5666,9 +5666,6 @@ class InstanceSerializer(BaseSerializer):
if 'canonical_address_peers_from_control_nodes' in attrs:
attrs['peers_from_control_nodes'] = attrs.pop('canonical_address_peers_from_control_nodes')
def get_field_from_model_or_attrs(fd):
return attrs.get(fd, self.instance and getattr(self.instance, fd) or None)
def check_peers_changed():
'''
return True if
@ -5680,9 +5677,7 @@ class InstanceSerializer(BaseSerializer):
if not self.instance and not settings.IS_K8S:
raise serializers.ValidationError(_("Can only create instances on Kubernetes or OpenShift."))
managed = get_field_from_model_or_attrs("managed")
if managed:
if self.instance and self.instance.managed:
if check_peers_changed():
raise serializers.ValidationError(_("Setting peers manually for managed nodes is not allowed."))