External-Mirrors/awx
2
0
Fork 0
mirror of https://github.com/ansible/awx.git synced 2026-01-09 23:12:08 -03:30
Code Issues Packages Projects Releases Wiki Activity

Test code for posting an object to a subcollection, and accompanying view code. (In this case organizations/n/projects)

Browse Source 
To be generalized later.
This commit is contained in:
Michael DeHaan 2013-03-22 14:23:50 -04:00
parent a59d26f42b
commit d179c91537
3 changed files with 38 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/main/models/__init__.py
View File

@ -21,7 +21,7 @@ class CommonModel(models.Model):
name = models.CharField(max_length=512, unique=True)
description = models.TextField(blank=True, default='')
created_by = models.ForeignKey('auth.User', on_delete=SET_NULL, null=True, blank=True, related_name='+') # FIXME: want to make required?
created_by = models.ForeignKey('auth.User', on_delete=SET_NULL, null=True, related_name='%s(class)s_created') # not blank=False on purpose for admin!
creation_date = models.DateField(auto_now_add=True)
tags = models.ManyToManyField('Tag', related_name='%(class)s_tags', blank=True)
audit_trail = models.ManyToManyField('AuditTrail', related_name='%(class)s_audit_trails', blank=True)

44
lib/main/tests.py
View File

@ -26,16 +26,27 @@ class BaseTest(django.test.TestCase):
django_user = DjangoUser.objects.create_user(username, "%s@example.com", password)
return django_user
def make_organizations(self, count=1):
def make_organizations(self, created_by, count=1):
results = []
for x in range(0, count):
results.append(Organization.objects.create(name="org%s" % x, description="org%s" % x))
results.append(Organization.objects.create(
name="org%s" % x,
description="org%s" % x,
created_by=created_by
))
return results
def make_projects(self, count=1):
def make_projects(self, created_by, count=1):
results = []
for x in range(0, count):
results.append(Project.objects.create(name="proj%s" % x, description="proj%s" % x, scm_type='git', default_playbook='foo.yml', local_repository='/checkout'))
results.append(Project.objects.create(
name="proj%s" % x,
description="proj%s" % x,
scm_type='git',
default_playbook='foo.yml',
local_repository='/checkout',
created_by=created_by
))
return results
def check_pagination_and_size(self, data, desired_count, previous=None, next=None):
@ -86,7 +97,8 @@ class BaseTest(django.test.TestCase):
assert False, "Failed: %s" % response.content
if expect is not None:
assert response.status_code == expect, "expected status %s, got %s for url=%s as auth=%s: %s" % (expect, response.status_code, url, auth, response.content)
if response.status_code != 204:
if response.status_code not in [ 202, 204, 400, 409 ]:
# no JSON responses in these at least for now, 400/409 should probably return some (FIXME)
return json.loads(response.content)
else:
return None
@ -117,8 +129,8 @@ class OrganizationsTest(BaseTest):
def setUp(self):
self.setup_users()
self.organizations = self.make_organizations(10)
self.projects = self.make_projects(10)
self.organizations = self.make_organizations(self.super_django_user, 10)
self.projects = self.make_projects(self.normal_django_user, 10)
# add projects to organizations in a more or less arbitrary way
for project in self.projects[0:2]:
@ -266,22 +278,18 @@ class OrganizationsTest(BaseTest):
# get all the projects on the first org
projects0 = self.get(projects0_url, expect=200, auth=self.get_super_credentials())
a_project = projects0['results'][-1]
print a_project
# attempt to add the project to the 7th org and see what happens
print projects7_url
self.post(projects7_url, a_project, expect=201, auth=self.get_super_credentials())
self.post(projects7_url, a_project, expect=202, auth=self.get_super_credentials())
projects7 = self.get(projects0_url, expect=200, auth=self.get_super_credentials())
print projects7
assertEquals(project7['count'], 1)
raise Exception("stop, need more tests for this!")
self.assertEquals(projects7['count'], 3)
# make sure we can't add the project again (should generate a conflict error)
# make sure we can't edit an existing project off this resource
# make sure you have to be a superuser or org admin to add a project to an org
# make sure you can create a /new/ project (need similar permissions) -- not always true of all subresources
pass
self.post(projects7_url, a_project, expect=409, auth=self.get_super_credentials())
# make sure adding a project that does not exist, or a missing pk field, results in a 400
self.post(projects7_url, dict(id=99999), expect=400, auth=self.get_super_credentials())
self.post(projects7_url, dict(asdf=1234), expect=400, auth=self.get_super_credentials())
def test_post_item_subobjects_users(self):
pass

20
lib/main/views.py
View File

@ -163,25 +163,27 @@ class OrganizationsProjectsList(BaseList):
# FIXME: overriden post for add-to-collection
# FIXME: if posted with disassociate: True, do not create object and remove the link
# FIXME: verify permissions checks are in place
# FIXME: do not create objects
# POST { pk: 7, disassociate: True }
organization_id = kwargs['pk']
print request.DATA
project_id = request.DATA.get('id')
organization = Organization.objects.get(pk=organization_id)
projects = Project.objects.filter(pk=project_id)
if len(projects) != 1:
return Response(status=status.HTTP_400_BAD_REQUEST)
project = projects[0]
# you can only add a project to an organization if you are a superuser or
# the person who created the project.
# the person who created the project. TODO -- want to defer this question
# to the model. (FIXME)
if request.user.is_superuser or project.user == request.user:
if not request.user.is_superuser or project.created_by == request.user:
raise PermissionDenied()
if project in organization.projects.all():
return Response(status=status.HTTP_409_CONFLICT)
organization = Organization.objects.get(pk=organization_id)
project = Project.objects.get(pk=project_id)
organization.projects.add(Project)
organization.projects.add(project)
return Response(status=status.HTTP_202_ACCEPTED)