Fix inconsistent screen title bars

This commit is contained in:
Jake McDermott 2020-10-28 15:41:29 -04:00
parent 10664d1931
commit d30dd97c96
No known key found for this signature in database
GPG Key ID: 0E56ED990CDFCB4F
3 changed files with 8 additions and 29 deletions

View File

@ -8,18 +8,17 @@ import {
CardActions,
CardBody,
PageSection,
PageSectionVariants,
Select,
SelectVariant,
SelectOption,
Tabs,
Tab,
TabTitleText,
Title,
} from '@patternfly/react-core';
import useRequest from '../../util/useRequest';
import { DashboardAPI } from '../../api';
import Breadcrumbs from '../../components/Breadcrumbs';
import JobList from '../../components/JobList';
import LineChart from './shared/LineChart';
@ -56,8 +55,6 @@ const GraphCardActions = styled(CardActions)`
`;
function Dashboard({ i18n }) {
const { light } = PageSectionVariants;
const [isPeriodDropdownOpen, setIsPeriodDropdownOpen] = useState(false);
const [isJobTypeDropdownOpen, setIsJobTypeDropdownOpen] = useState(false);
const [periodSelection, setPeriodSelection] = useState('month');
@ -111,11 +108,7 @@ function Dashboard({ i18n }) {
return (
<Fragment>
<PageSection variant={light} className="pf-m-condensed">
<Title size="2xl" headingLevel="h2">
{i18n._(t`Dashboard`)}
</Title>
</PageSection>
<Breadcrumbs breadcrumbConfig={{ '/home': i18n._(t`Dashboard`) }} />
<PageSection>
<Counts>
<Count

View File

@ -1,25 +1,18 @@
import React, { Component, Fragment } from 'react';
import { withI18n } from '@lingui/react';
import { t } from '@lingui/macro';
import {
PageSection,
PageSectionVariants,
Title,
} from '@patternfly/react-core';
import Breadcrumbs from '../../components/Breadcrumbs';
class ManagementJobs extends Component {
render() {
const { i18n } = this.props;
const { light } = PageSectionVariants;
return (
<Fragment>
<PageSection variant={light} className="pf-m-condensed">
<Title size="2xl" headingLevel="h2">
{i18n._(t`Management Jobs`)}
</Title>
</PageSection>
<PageSection />
<Breadcrumbs
breadcrumbConfig={{ '/management_jobs': i18n._(t`Management Jobs`) }}
/>
</Fragment>
);
}

View File

@ -6,13 +6,9 @@ import ManagementJobs from './ManagementJobs';
describe('<ManagementJobs />', () => {
let pageWrapper;
let pageSections;
let title;
beforeEach(() => {
pageWrapper = mountWithContexts(<ManagementJobs />);
pageSections = pageWrapper.find('PageSection');
title = pageWrapper.find('Title');
});
afterEach(() => {
@ -21,9 +17,6 @@ describe('<ManagementJobs />', () => {
test('initially renders without crashing', () => {
expect(pageWrapper.length).toBe(1);
expect(pageSections.length).toBe(2);
expect(title.length).toBe(1);
expect(title.props().size).toBe('2xl');
expect(pageSections.first().props().variant).toBe('light');
expect(pageWrapper.find('Breadcrumbs').length).toBe(1);
});
});