Remove validation and unused vars for EE Lookup.

This commit is contained in:
Kia Lam 2021-09-23 10:23:51 -07:00
parent f06eb5e2f1
commit d7f1f0c7e6
4 changed files with 10 additions and 36 deletions

View File

@ -24,9 +24,7 @@ function ExecutionEnvironmentLookup({
id,
globallyAvailable,
helperTextInvalid,
isDefaultEnvironment,
isDisabled,
isGlobalDefaultEnvironment,
isValid,
onBlur,
onChange,
@ -40,7 +38,6 @@ function ExecutionEnvironmentLookup({
overrideLabel,
}) {
const location = useLocation();
const {
request: fetchProject,
error: fetchProjectError,
@ -199,26 +196,17 @@ function ExecutionEnvironmentLookup({
</>
);
const renderLabel = (
globalDefaultEnvironment,
defaultExecutionEnvironment
) => {
const renderLabel = () => {
if (overrideLabel) {
return null;
}
if (globalDefaultEnvironment) {
return t`Global Default Execution Environment`;
}
if (defaultExecutionEnvironment) {
return t`Default Execution Environment`;
}
return t`Execution Environment`;
};
return (
<FormGroup
fieldId={id}
label={renderLabel(isGlobalDefaultEnvironment, isDefaultEnvironment)}
label={renderLabel()}
labelIcon={popoverContent && <Popover content={popoverContent} />}
helperTextInvalid={helperTextInvalid}
validated={isValid ? 'default' : 'error'}
@ -239,8 +227,6 @@ ExecutionEnvironmentLookup.propTypes = {
value: ExecutionEnvironment,
popoverContent: string,
onChange: func.isRequired,
isDefaultEnvironment: bool,
isGlobalDefaultEnvironment: bool,
projectId: oneOfType([number, string]),
organizationId: oneOfType([number, string]),
validate: func,
@ -251,8 +237,6 @@ ExecutionEnvironmentLookup.propTypes = {
ExecutionEnvironmentLookup.defaultProps = {
id: 'execution-environments',
popoverContent: '',
isDefaultEnvironment: false,
isGlobalDefaultEnvironment: false,
value: null,
projectId: null,
organizationId: null,

View File

@ -54,7 +54,6 @@ describe('ExecutionEnvironmentLookup', () => {
wrapper = mountWithContexts(
<Formik>
<ExecutionEnvironmentLookup
isDefaultEnvironment
value={executionEnvironment}
onChange={() => {}}
/>
@ -64,12 +63,9 @@ describe('ExecutionEnvironmentLookup', () => {
wrapper.update();
expect(ExecutionEnvironmentsAPI.read).toHaveBeenCalledTimes(1);
expect(wrapper.find('ExecutionEnvironmentLookup')).toHaveLength(1);
expect(
wrapper.find('FormGroup[label="Default Execution Environment"]').length
).toBe(1);
expect(
wrapper.find('FormGroup[label="Execution Environment"]').length
).toBe(0);
).toBe(1);
});
test('should fetch execution environments', async () => {

View File

@ -57,12 +57,10 @@ function Lookup(props) {
useField({
name: fieldName,
validate: (val) => {
setTimeout(() => {
if (!multiple && !val && typedText && typedText !== '') {
return t`That value was not found. Please enter or select a valid value.`;
}
return validate(val);
});
if (!multiple && !val && typedText && typedText !== '') {
return t`That value was not found. Please enter or select a valid value.`;
}
return validate(val);
},
});

View File

@ -231,9 +231,7 @@ EncryptedField.propTypes = {
};
const ExecutionEnvField = ({ name, config, isRequired = false }) => {
const validate = isRequired ? required(null) : null;
const [field, meta, helpers] = useField({ name, validate });
const isValid = !meta.error || !meta.touched;
const [field, meta, helpers] = useField({ name });
return config ? (
<SettingGroup
defaultValue={config.default ?? ''}
@ -242,15 +240,13 @@ const ExecutionEnvField = ({ name, config, isRequired = false }) => {
isRequired={isRequired}
label={config.label}
popoverContent={config.help_text}
validated={isValid ? 'default' : 'error'}
isDisabled={field.value === null}
onRevertCallback={() => helpers.setValue(config.default)}
>
<ExecutionEnvironmentLookup
onBlur={() => helpers.setTouched(true)}
value={field.value}
onChange={(value) => {
helpers.setValue(value);
helpers.setTouched(true);
helpers.setValue(value, false);
}}
overrideLabel
fieldName={name}