External-Mirrors/awx
2
0
Fork 0
mirror of https://github.com/ansible/awx.git synced 2026-01-17 12:41:19 -03:30
Code Issues Packages Projects Releases Wiki Activity

add pagination test

Browse Source
This commit is contained in:
Alex Corey 2019-03-12 12:28:42 -04:00
parent a3bea6d4a8
commit d96b88e495
2 changed files with 102 additions and 35 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

134
__tests__/components/Pagination.test.jsx
View File

@ -117,6 +117,7 @@ describe('<Pagination />', () => {
const pageSizeDropdownItems = pagination.find(pageSizeDropdownItemsSelector);
expect(pageSizeDropdownItems.length).toBe(3);
pageSizeDropdownItems.at(1).simulate('click');
expect(onSetPage).toBeCalledWith(1, 25);
});
test('itemCount displays correctly', () => {
@ -134,8 +135,37 @@ describe('<Pagination />', () => {
/>
</I18nProvider>
);
const itemCount = pagination.find('.awx-pagination__item-count');
let itemCount = pagination.find('.awx-pagination__item-count');
expect(itemCount.text()).toEqual('Items 1 – 5 of 7');
pagination = mount(
<I18nProvider>
<Pagination
count={7}
page={1}
pageCount={1}
page_size={10}
pageSizeOptions={[5, 10, 25, 50]}
onSetPage={onSetPage}
/>
</I18nProvider>
);
itemCount = pagination.find('.awx-pagination__item-count');
expect(itemCount.text()).toEqual('Items 1 – 7 of 7');
pagination = mount(
<I18nProvider>
<Pagination
count={7}
page={2}
pageCount={2}
page_size={5}
pageSizeOptions={[5, 10, 25, 50]}
onSetPage={onSetPage}
/>
</I18nProvider>
);
itemCount = pagination.find('.awx-pagination__item-count');
expect(itemCount.text()).toEqual('Items 6 – 7 of 7');
});
test('itemCount matching pageSize displays correctly', () => {
@ -176,39 +206,38 @@ describe('<Pagination />', () => {
expect(itemCount.text()).toEqual('Items 1 – 3 of 3');
});
test('submit a new page by typing in input works', () => {
const textInputSelector = '.awx-pagination__page-input.pf-c-form-control';
const submitFormSelector = '.awx-pagination__page-input-form';
// test('submit a new page by typing in input works', () => {
// const textInputSelector = '.awx-pagination__page-input.pf-c-form-control';
// const submitFormSelector = '.awx-pagination__page-input-form';
// const onSetPage = jest.fn();
// pagination = mount(
// <I18nProvider>
// <Pagination
// count={21}
// page={1}
// pageCount={5}
// page_size={5}
// pageSizeOptions={[5, 10, 25, 50]}
// onSetPage={onSetPage}
// />
// </I18nProvider>
// );
// pagination.instance().onPageChange = jest.fn();
// const textInput = pagination.find(textInputSelector);
// expect(textInput.length).toBe(1);
// textInput.simulate('change', { target: { value: '2' } });
// const submitForm = pagination.find(submitFormSelector);
// expect(submitForm.length).toBe(1);
// submitForm.simulate('submit');
// expect(pagination.instance().onPageChange).toBeCalledWith(2)
// });
test('text input page change is not displayed when only 1 page', () => {
const onSetPage = jest.fn();
pagination = mount(
<I18nProvider>
<Pagination
count={21}
page={1}
pageCount={5}
page_size={5}
pageSizeOptions={[5, 10, 25, 50]}
onSetPage={onSetPage}
/>
</I18nProvider>
);
const textInput = pagination.find(textInputSelector);
expect(textInput.length).toBe(1);
textInput.simulate('change');
pagination.setProps({ page: 2 });
const submitForm = pagination.find(submitFormSelector);
expect(submitForm.length).toBe(1);
submitForm.simulate('submit');
pagination.find('Pagination').instance().setState({ value: 'invalid' });
submitForm.simulate('submit');
});
test('text input page change is disabled when only 1 page', () => {
const onSetPage = jest.fn();
const pageNumber = 'input[aria-label="Page Number"]';
pagination = mount(
<I18nProvider>
<Pagination
@ -221,5 +250,44 @@ describe('<Pagination />', () => {
/>
</I18nProvider>
);
let pageInput = pagination.find(pageNumber);
expect(pageInput.length).toBe(0);
pagination = mount(
<I18nProvider>
<Pagination
count={11}
page={1}
pageCount={3}
page_size={5}
pageSizeOptions={[5, 10, 25, 50]}
onSetPage={onSetPage}
/>
</I18nProvider>
);
pageInput = pagination.find(pageNumber);
expect(pageInput.length).toBe(1);
});
// test('make sure componentDidUpdate calls onPageChange', () => {
// const onSetPage = jest.fn();
// pagination = mount(
// <I18nProvider>
// <Pagination
// count={7}
// page={1}
// pageCount={2}
// page_size={5}
// pageSizeOptions={[5, 10, 25, 50]}
// onSetPage={onSetPage}
// />
// </I18nProvider>
// );
// pagination.instance().onPageChange = jest.fn();
// pagination.setProps({ page: 2 });
// pagination.update();
// expect(pagination.instance().onPageChange).toHaveBeenCalledTimes(1);
// expect(pagination.instance().onPageChange).toBeCalledWith(2);
// });
});

3
src/components/Pagination/Pagination.jsx
View File

@ -89,9 +89,8 @@ class Pagination extends Component {
onSelectPageSize ({ target }) {
const { onSetPage } = this.props;
const page = 1;
const page_size = parseInt(target.innerText, 10);
const page_size = parseInt(target.innerText || target.textContent, 10);
this.setState({ isOpen: false });