Merge pull request #1383 from jakemcdermott/401-on-invalid-login

issue a 401 on invalid login

awx/api/generics.py

@@ -66,14 +66,15 @@ class LoggedLoginView(auth_views.LoginView):
         original_user = getattr(request, 'user', None)
         ret = super(LoggedLoginView, self).post(request, *args, **kwargs)
         current_user = getattr(request, 'user', None)
+
         if current_user and getattr(current_user, 'pk', None) and current_user != original_user:
             logger.info("User {} logged in.".format(current_user.username))
         if request.user.is_authenticated:
             return ret
         else:
-            ret.status = 401
+            ret.status_code = 401
             return ret
-            
+
 
 class LoggedLogoutView(auth_views.LogoutView):
 

awx/main/tests/functional/api/test_auth.py

@@ -0,0 +1,26 @@
+import pytest
+
+from django.contrib import auth
+from django.test import Client
+
+from rest_framework.test import APIRequestFactory
+
+from awx.api.generics import LoggedLoginView
+from awx.api.versioning import drf_reverse
+
+
+@pytest.mark.django_db
+def test_invalid_login():
+    anon = auth.get_user(Client())
+    url = drf_reverse('api:login')
+ 
+    factory = APIRequestFactory()
+
+    data = {'userame': 'invalid', 'password': 'invalid'}
+
+    request = factory.post(url, data)
+    request.user = anon
+
+    response = LoggedLoginView.as_view()(request)
+
+    assert response.status_code == 401