Merge pull request #256 from joefiorini/moment-fixes

Make usage of moment consistent throughout app

awx/ui/static/js/app.js

@@ -37,6 +37,7 @@ import setupMenu from 'tower/setup-menu/main';
 import mainMenu from 'tower/main-menu/main';
 import browserData from 'tower/browser-data/main';
 import dashboard from 'tower/dashboard/main';
+import moment from 'tower/shared/moment/main';
 
 import {JobDetailController} from 'tower/controllers/JobDetail';
 import {JobStdoutController} from 'tower/controllers/JobStdout';
@@ -82,6 +83,7 @@ var tower = angular.module('Tower', [
     setupMenu.name,
     mainMenu.name,
     dashboard.name,
+    moment.name,
     'AuthService',
     'Utilities',
     'LicenseHelper',

awx/ui/static/js/dashboard/lists/jobs/jobs-list.directive.js

@@ -1,6 +1,7 @@
 /* jshint unused: vars */
 export default
-    [function JobsList() {
+    ['moment',
+    function JobsList(moment) {
     return {
         restrict: 'E',
         link: link,

awx/ui/static/js/shared/long-date.filter.js

@@ -4,16 +4,15 @@
  * All Rights Reserved
  *************************************************/
 
-angular.module('longDateFilter', []).filter('longDate', function() {
-  return function(input) {
-
-      // navigator.language is available in all modern browsers.
-      // however navigator.languages is a new technology that
-      // lists the user's preferred languages, the first in the array
-      // being the user's top choice. navigator.languages is currently
-      // comptabile with chrome>v32, ffox>32, but not IE/Safari
-    var lang = navigator.languages ? navigator.languages[0] : (navigator.language || navigator.userLanguage),
-        date = moment(input).locale(lang);
+function longDateFilter(moment, input) {
+    var date = moment(input);
     return date.format('l LTS');
-  };
-});
+}
+
+angular.module('longDateFilter', [])
+    .filter('longDate',
+            [   'moment',
+                function(moment) {
+                    return _.partial(longDateFilter, moment);
+                }
+            ]);

awx/ui/static/js/shared/moment/main.js

@@ -0,0 +1,9 @@
+import newMoment from './moment';
+
+export default
+    angular.module('moment', ['angularMoment'])
+        .config(function() {
+            // Remove the global variable for moment
+            delete window.moment;
+        })
+        .constant('moment', newMoment);

awx/ui/static/js/shared/moment/moment.js

@@ -0,0 +1,20 @@
+var originalMoment = window.moment;
+
+function moment() {
+
+    // navigator.language is available in all modern browsers.
+    // however navigator.languages is a new technology that
+    // lists the user's preferred languages, the first in the array
+    // being the user's top choice. navigator.languages is currently
+    // comptabile with chrome>v32, ffox>32, but not IE/Safari
+    var lang = navigator.languages ?
+                navigator.languages[0] :
+                (navigator.language || navigator.userLanguage);
+
+    originalMoment.locale(lang);
+    return originalMoment.apply(this, arguments);
+}
+
+_.merge(moment, originalMoment);
+
+export default moment;

awx/ui/static/js/system-tracking/date-picker/date-picker.directive.js

@@ -7,8 +7,8 @@
 /* jshint unused: vars */
 
 export default
-    [   '$rootScope',
-        function() {
+    [   'moment',
+        function(moment) {
             return {
                 restrict: 'E',
                 scope: {

awx/ui/static/js/system-tracking/main.js

@@ -16,8 +16,7 @@ import datePicker from './date-picker/main';
 
 export default
     angular.module('systemTracking',
-                   [   'angularMoment',
-                       utilities.name,
+                   [   utilities.name,
                        shared.name,
                        datePicker.name
                    ])

awx/ui/static/js/system-tracking/search-date-range.js

@@ -4,6 +4,8 @@
  * All Rights Reserved
  *************************************************/
 
+import moment from 'tower/shared/moment/moment';
+
 export function searchDateRange(dateString) {
     var date;
 

awx/ui/static/js/system-tracking/string-or-date.filter.js

@@ -6,7 +6,8 @@
 
 export default
     [   'amDateFormatFilter',
-        function(dateFormat) {
+        'moment',
+        function(dateFormat, moment) {
             return function(string, format) {
                 if (moment.isMoment(string)) {
                     return dateFormat(string, format);

awx/ui/static/js/system-tracking/system-tracking.controller.js

@@ -15,7 +15,7 @@ function controller($rootScope,
                     initialFactData,
                     getDataForComparison,
                     waitIndicator,
-
+                    moment,
                     _) {
     // var inventoryId = $routeParams.id;
     var hostIds = $routeParams.hosts.split(',');
@@ -201,6 +201,7 @@ export default
         'factScanData',
         'getDataForComparison',
         'Wait',
+        'moment',
         'lodashAsPromised',
         controller
     ];

awx/ui/static/js/system-tracking/system-tracking.route.js

@@ -5,6 +5,7 @@
  *************************************************/
 
 import {searchDateRange} from './search-date-range';
+import moment from 'tower/shared/moment/moment';
 
 export default {
     name: 'systemTracking',

awx/ui/tests/unit/system-tracking/single-host-data.service-test.js

@@ -1,5 +1,6 @@
 import systemTracking from 'tower/system-tracking/main';
 import {describeModule} from '../describe-module';
+import moment from 'tower/shared/moment/moment';
 
 describeModule(systemTracking.name)
     .testService('factScanDataService', function(test, restStub) {