Merge pull request #6276 from ryanpetrello/approval-start-date-in-notifications

save approval node start time *before* sending "started" notifications

Reviewed-by: https://github.com/apps/softwarefactory-project-zuul
This commit is contained in:
softwarefactory-project-zuul[bot] 2020-03-12 18:58:03 +00:00 committed by GitHub
commit e4dd2728ef
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -749,9 +749,9 @@ class WorkflowApproval(UnifiedJob, JobNotificationMixin):
def signal_start(self, **kwargs):
can_start = super(WorkflowApproval, self).signal_start(**kwargs)
self.send_approval_notification('running')
self.started = self.created
self.save(update_fields=['started'])
self.send_approval_notification('running')
return can_start
def send_approval_notification(self, approval_status):