Call this.sync when we receive a ws complete message.

- There can be a race condition where a job run finishes event processing before sending off a "successful/failed" websocket message. In this instance, we would miss gathering known artifacts for a job. The proposed fix is to do a manual detection of when a job status updates to "successful/failed/unknown" and perform a GET request to the job endpoint.
This commit is contained in:
kialam 2019-02-19 13:40:37 -05:00
parent 30352e375f
commit ec8a452f1d
No known key found for this signature in database
GPG Key ID: 2D0E60E4B8C7EA0F
2 changed files with 3 additions and 1 deletions

View File

@ -810,7 +810,6 @@ function OutputIndexController (
onStop () {
lockFollow = true;
stopFollowing();
stopListening();
status.updateStats();
status.dispatch();
status.sync();

View File

@ -95,6 +95,9 @@ function JobStatusService (moment, message) {
if (isJobStatusEvent) {
this.setJobStatus(data.status);
if (JOB_STATUS_FINISHED.includes(data.status)) {
this.sync();
}
this.dispatch();
} else if (isProjectStatusEvent) {
this.setProjectStatus(data.status);