Adds missing rel="noopener noreferrer" to each link element with target="_blank" (#13959)

2026-01-10 15:32:07 -03:30 · 2023-05-31 13:49:39 -04:00 · 2023-05-31 13:49:39 -04:00 · fbe202bdbf
commit fbe202bdbf
parent d89cad0d9e
13 changed files with 18 additions and 4 deletions
--- a/awx/ui/.eslintrc.json
+++ b/awx/ui/.eslintrc.json
@ -99,7 +99,8 @@
          "fieldName",
          "splitButtonVariant",
          "pageKey",
-          "textId"
+          "textId",
+          "rel"
        ],
        "ignore": [
          "Ansible",
--- a/awx/ui/src/components/AppContainer/PageHeaderToolbar.js
+++ b/awx/ui/src/components/AppContainer/PageHeaderToolbar.js
@ -112,6 +112,7 @@ function PageHeaderToolbar({
                target="_blank"
                href={`${getDocsBaseUrl(config)}/html/userguide/index.html`}
                ouiaId="help-dropdown-item"
+                rel="noopener noreferrer"
              >
                {t`Help`}
              </DropdownItem>,
--- a/awx/ui/src/components/Search/AdvancedSearch.js
+++ b/awx/ui/src/components/Search/AdvancedSearch.js
@ -322,6 +322,7 @@ function AdvancedSearch({
          variant="plain"
          target="_blank"
          href={`${getDocsBaseUrl(config)}/html/userguide/search_sort.html`}
+          rel="noopener noreferrer"
        >
          <QuestionCircleIcon />
        </Button>
--- a/awx/ui/src/screens/Instances/InstanceDetail/InstanceDetail.js
+++ b/awx/ui/src/screens/Instances/InstanceDetail/InstanceDetail.js
@ -258,6 +258,7 @@ function InstanceDetail({ setBreadcrumb, isK8s }) {
                        target="_blank"
                        variant="secondary"
                        dataCy="install-bundle-download-button"
+                        rel="noopener noreferrer"
                      >
                        <DownloadIcon />
                      </Button>
--- a/awx/ui/src/screens/Inventory/shared/ConstructedInventoryHint.js
+++ b/awx/ui/src/screens/Inventory/shared/ConstructedInventoryHint.js
@ -43,6 +43,7 @@ function ConstructedInventoryHint() {
          )}/html/userguide/inventories.html#constructed-inventories`}
          component="a"
          target="_blank"
+          rel="noopener noreferrer"
        >
          {t`View constructed inventory documentation here`}{' '}
          <ExternalLinkAltIcon />
--- a/awx/ui/src/screens/NotificationTemplate/shared/Notifications.helptext.js
+++ b/awx/ui/src/screens/NotificationTemplate/shared/Notifications.helptext.js
@ -35,7 +35,7 @@ const helpText = () => ({
      <a
        href="https://docs.djangoproject.com/en/4.0/ref/settings/#std:setting-EMAIL_USE_TLS"
        target="_blank"
-        rel="noreferrer"
+        rel="noopener noreferrer"
      >{t`documentation`}</a>{' '}
      <span>{t`for more information.`}</span>
    </>
--- a/awx/ui/src/screens/Setting/Subscription/SubscriptionDetail/SubscriptionDetail.js
+++ b/awx/ui/src/screens/Setting/Subscription/SubscriptionDetail/SubscriptionDetail.js
@ -206,6 +206,7 @@ function SubscriptionDetail() {
            href="https://www.redhat.com/contact"
            variant="link"
            target="_blank"
+            rel="noopener noreferrer"
            isInline
          >
            contact us.
--- a/awx/ui/src/screens/Setting/Subscription/SubscriptionEdit/AnalyticsStep.js
+++ b/awx/ui/src/screens/Setting/Subscription/SubscriptionEdit/AnalyticsStep.js
@ -46,6 +46,7 @@ function AnalyticsStep() {
            isInline
            ouiaId="tower-documentation-link"
            target="_blank"
+            rel="noopener noreferrer"
          >
            this Tower documentation page
          </Button>
@ -116,6 +117,7 @@ function AnalyticsStep() {
          target="_blank"
          variant="secondary"
          ouiaId="analytics-link"
+          rel="noopener noreferrer"
        >
          <Trans>Learn more about Automation Analytics</Trans>
        </Button>
--- a/awx/ui/src/screens/Setting/Subscription/SubscriptionEdit/SubscriptionStep.js
+++ b/awx/ui/src/screens/Setting/Subscription/SubscriptionEdit/SubscriptionStep.js
@ -70,6 +70,7 @@ function SubscriptionStep() {
            ouiaId="request-subscription-button"
            target="_blank"
            variant="secondary"
+            rel="noopener noreferrer"
          >
            {t`Request subscription`}
          </Button>
@ -103,6 +104,7 @@ function SubscriptionStep() {
                variant="link"
                target="_blank"
                ouiaId="subscription-allocations-link"
+                rel="noopener noreferrer"
                isInline
              >
                subscription allocations
@ -127,6 +129,7 @@ function SubscriptionStep() {
                      href="https://access.redhat.com/management/subscription_allocations"
                      variant="link"
                      target="_blank"
+                      rel="noopener noreferrer"
                      isInline
                      ouiaId="subscription-allocations-link"
                    >
@ -140,6 +143,7 @@ function SubscriptionStep() {
                      )}/html/userguide/import_license.html`}
                      variant="link"
                      target="_blank"
+                      rel="noopener noreferrer"
                      ouiaId="import-license-link"
                      isInline
                    >
--- a/awx/ui/src/screens/Template/Survey/SurveyQuestionForm.js
+++ b/awx/ui/src/screens/Template/Survey/SurveyQuestionForm.js
@ -264,7 +264,7 @@ function SurveyQuestionForm({
                        config
                      )}/html/userguide/job_templates.html#surveys`}
                      target="_blank"
-                      rel="noreferrer"
+                      rel="noopener noreferrer"
                    >
                      {t`documentation`}
                    </a>{' '}
--- a/awx/ui/src/screens/Template/WorkflowJobTemplateVisualizer/VisualizerToolbar.js
+++ b/awx/ui/src/screens/Template/WorkflowJobTemplateVisualizer/VisualizerToolbar.js
@ -108,6 +108,7 @@ function VisualizerToolbar({
              variant="plain"
              component="a"
              target="_blank"
+              rel="noopener noreferrer"
              href={`${getDocsBaseUrl(
                config
              )}/html/userguide/workflow_templates.html#ug-wf-editor`}
--- a/awx/ui/src/screens/Template/shared/JobTemplate.helptext.js
+++ b/awx/ui/src/screens/Template/shared/JobTemplate.helptext.js
@ -56,7 +56,7 @@ const jtHelpTextStrings = () => ({
      <a
        href={`${getDocsBaseUrl(config)}/html/userguide/scheduling.html`}
        target="_blank"
-        rel="noreferrer"
+        rel="noopener noreferrer"
      >
        {t`documentation`}
      </a>{' '}
--- a/awx/ui/src/screens/TopologyView/Tooltip.js
+++ b/awx/ui/src/screens/TopologyView/Tooltip.js
@ -254,6 +254,7 @@ function Tooltip({
                      href={`${instanceDetail.related?.install_bundle}`}
                      target="_blank"
                      variant="secondary"
+                      rel="noopener noreferrer"
                    >
                      <DownloadIcon />
                    </PFButton>