External-Mirrors/awx
2
0
Fork 0
mirror of https://github.com/ansible/awx.git synced 2026-09-16 08:50:10 -02:30
Code Issues Packages Projects Releases Wiki Activity
34,158 Commits 65 Branches 102 Tags
011733ad06daa6e5bcb5bca18d485db99430625c
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Alan Rominger 50db80182b Remove archaic monkey patches (#15338) 2024-08-28 21:50:00 -04:00
Alan Rominger 9cf66de454 Pin DAB to devel again (#15467) 2024-08-27 11:18:09 -04:00
Alan Rominger f5760b149d Fix 500 error when ordinary user viewed system JTs (#15465) 2024-08-26 11:51:16 -04:00
Alan Romingerandchrismeyersfsu 5a8429deed Update django-ansible-base version to 2024.8.19 (#15454) 
Update django-ansible-base version to 2024.8.9

Co-authored-by: chrismeyersfsu <722880+chrismeyersfsu@users.noreply.github.com>
 2024-08-21 14:16:49 -04:00
Alan Rominger af537b5261 Rewrite more access logic in terms of permissions instead of roles (#15453) 
* Rewrite more access logic in terms of permissions instead of roles

* Cut down supported logic because that would not work anyway

* Remove methods not needed anymore

* Create managed roles in test before delegating permissions
 2024-08-21 13:14:40 -04:00
Alan Rominger af02ab46e3 Bump DAB version manually because bot is on vacation (#15434) 2024-08-09 15:42:18 -04:00
Alan Rominger 59f61517d4 Loosen up team EE restrictions (#15384) 
* Try to loosen up team EE restrictions

* Fix missed permission case of nulling EE org
 2024-07-22 14:51:32 -04:00
Alan Rominger fa670e2d7f Upgrade to v4 checkout, hide output (#15322) 2024-07-19 15:33:11 -04:00
Alan Rominger 381ade1148 Fix create_preload_data to allow running without an admin user created (#15356) 
* Allow create_preload_data without having superuser created first

* Temporarily change the DAB requirement

* Put DAB branch back to devel
 2024-07-19 10:35:33 -04:00
Alan Rominger fde8af9f11 Fix task ending in error due to bad iterator (#15355) 2024-07-12 13:20:39 -04:00
Alan Rominger 282ba36839 Fix EE admin not being able to PATCH/PUT object while providing organization (#15348) 
* Fix bug where EE object-level admin could not set organization

* Finish polishing up test
 2024-07-09 16:55:09 -04:00
Alan Rominger b727d2c3b3 Log conflicts and created items by the periodic resource sync (#15337) 
* Initial lazy logging of periodic sync results

* Add desired polish to log

* Add debug log
 2024-07-09 15:13:08 -04:00
Alan Rominger ea232315bf Do not reference self.messages when it does not exist (#15331) 2024-07-03 20:07:46 +00:00
Alan Rominger ee251812b5 Add complete test that we have analogs to old versions of roles, fix some mismatches (#15321) 
* Add test that we got all permissions right for every role

* Fix missing Org execute role and missing adhoc role permission

* Add in missing Organization Approval Role as well

* Remove Role from role names
 2024-07-03 15:40:55 -04:00
Alan Rominger 00ba1ea569 Suppress docker pull output in checks (#15323) 
Supress docker pull output in checks
 2024-07-03 15:04:59 -04:00
Alan Rominger d91af132c1 Fix server error assigning teams EE object roles (#15320) 2024-07-03 14:07:03 -04:00
Alan Rominger c4688d6298 Add in missing read permissions for organization audit role (#15318) 
* Add in missing read permissions for organization audit role

* Add missing audit permission, special case name handling
 2024-07-02 15:20:40 -04:00
Alan Rominger 98bbc836a6 Fix server error from DAB ValidationError with strings (#15312) 2024-07-01 10:11:22 -04:00
Alan Rominger b59aff50dc Update ExecutionEnvironment model so object-level roles work with DAB RBAC system (#15289) 
* Add initial test for deletion of stale permission

* Delete existing EE view permission

* Hypothetically complete update of EE model permissions setup

* Tests passing locally

* Issue with user_capabilities was a test bug, fixed
 2024-06-28 16:09:42 -04:00
Alan Rominger a70b0c1ddc Do not use cache in github image build action (#15308) 
* Do not use cache in actual image build action

* Add cache args to kube prod builds
 2024-06-28 09:52:59 -04:00
Alan Rominger db72c9d5b8 Fix permissions that come from an external auditor role (#15291) 
* Add tests for external auditor

* Add assertion for unified JTs which fails

* Fix UJT listing bug

* Add test for ad hoc commands just to be sure
 2024-06-27 15:57:39 -04:00
Alan Rominger dbc2215bb6 Make attached user models adhere to new API assignments (#15298) 2024-06-26 23:00:25 -04:00
Alan RomingerandSeth Foster 853af295d9 Various RBAC fixes related to managed RoleDefinitions (#15287) 
* Add migration testing for certain managed roles

* Fix managed role bugs

* Add more tests

* Fix another bug with org workflow admin role reference

* Add test because another issue is fixed

* Mark reason for test

* Remove internal markers

* Reword failure message

Co-authored-by: Seth Foster <fosterseth@users.noreply.github.com>

---------

Co-authored-by: Seth Foster <fosterseth@users.noreply.github.com>
 2024-06-21 09:29:34 -04:00
Alan Rominger 4738c8333a Fix object-level permission bugs with DAB RBAC system (#15284) 
* Fix object-level permission bugs with DAB RBAC system

* Fix NT organization change regression

* Mark tests to AAP number
 2024-06-20 16:34:34 -04:00
Alan Rominger d5bad1a533 Pass the Makefile python exe to ansible-playbook (#15282) 2024-06-18 13:03:01 -04:00
Alan Rominger f6c0effcb2 Use public methods to reference registered models (#15277) 2024-06-17 11:45:44 -04:00
Alan Rominger 208ef0ce25 Update test so that DAB change can merge (#15222) 2024-05-28 11:53:01 -04:00
Alan Rominger 8de8f6dce2 Update a few dev requirements (#15203) 
* Update a few dev requirements

* Fix test failures due to upgrade

* Update patterns for mocker usage
 2024-05-20 23:37:02 +00:00
Alan Rominger 918d5b3565 Do some aesthetic adjustments to role presentation fields (#15153) 
* Do some asthetic adjustments to role presentation fields

* Correctly test managed setup

* Minor migration adjustments
 2024-04-29 17:11:10 -04:00
Alan Rominger 014534bfa5 Upgrade DRF (#15144) 
* Upgrade DRF

* Fix failures caused by DRF upgrade
 2024-04-25 15:37:08 -04:00
Alan Rominger 47a061eb39 Fix and test data migration error from DAB RBAC (#15138) 
* Fix and test data migration error from DAB RBAC

* Fix up migration test

* Fix custom method bug

* Fix another fat fingered bug
 2024-04-24 15:14:03 -04:00
Alan Rominger c760577855 Adjust test for stricter DAB user view permission enforcement (#15130) 2024-04-23 15:21:06 -04:00
Alan Rominger e3af658f82 Use released version of django-radius (#15103) 2024-04-12 16:34:23 -04:00
Alan Rominger 390c2d8907 [RBAC] Update related name to reflect upstream DAB change (#15093) 
Update related name to reflect upstream DAB change
 2024-04-11 14:59:09 -04:00
Alan Rominger 97605c5f19 Make custom urls work with RBAC 2024-04-11 14:59:09 -04:00
Alan Rominger 818c326160 [RBAC] Rename managed role definitions, and move migration logic here (#15087) 
* Rename managed role definitions, and move migration logic here

* Fix naming capitalization
 2024-04-11 14:59:09 -04:00
Alan RomingerandSeth Foster c98727d83e [RBAC] Fix bug where team could not be given read_role to other team (#15067) 
* Fix bug where team could not be given read_role to other team

* Avoid unwanted triggers of parentage granting

* Restructure signal structure

* Fix another bug unmasked by team member permission fix

* Changes to live with test writing

* Use equality as opposed to string "in"

from Seth in review comment

Co-authored-by: Seth Foster <fosterseth@users.noreply.github.com>

---------

Co-authored-by: Seth Foster <fosterseth@users.noreply.github.com>
 2024-04-11 14:59:09 -04:00
Alan Rominger a138a92e67 [RBAC] Tweaks to reflect what endpoints are deprecated (#15068) 
Tweaks to reflect what endpoints are deprecated
 2024-04-11 14:59:09 -04:00
Alan Rominger 7aed19ffda Fix missing role membership when giving creator permissions (#15058) 2024-04-11 14:59:09 -04:00
Alan Rominger 389a729b75 [RBAC] Fix known issues with backward compatible access_list (#15052) 
* Remove duplicate access_list entries for direct team access

* Revert test changes for superuser in access_list
 2024-04-11 14:59:09 -04:00
Alan Rominger 2f3c9122fd Generalize can_delete solution, use devel DAB (#15009) 
* Generalize can_delete solution, use devel DAB

* Fix bug where model was used instead of model_name

* Linter fixes
 2024-04-11 14:59:09 -04:00
Alan Rominger 733478ee19 [RBAC] Fix server error from delete capability of approvals (#15002) 
Fix server error from delete capability of approvals
 2024-04-11 14:59:09 -04:00
Alan Rominger 41c6337fc1 [RBAC] Fix migration for created and modified field changes (#14999) 
Fix migration for created and modified field changes
 2024-04-11 14:59:09 -04:00
Alan Rominger 7446da1c2f Bump migration number for RBAC branch 2024-04-11 14:59:09 -04:00
Alan Rominger c79fca5ceb Adopt internal DAB RBAC Permission model (#14994) 2024-04-11 14:59:09 -04:00
Alan Rominger dc5f43927a Minor RBAC test fix (#14982) 2024-04-11 14:59:09 -04:00
Alan Rominger 35a5a81e19 Use AWX base view to make unauth requests 401 (#14981) 2024-04-11 14:59:09 -04:00
Alan Rominger 9dcc11d54c [DAB RBAC] Re-implement system auditor as a singleton role in new system (#14963) 
* Add new enablement settings from DAB RBAC

* Initial implementation of system auditor as role without testing

* Fix system auditor role, remove duplicate assignments

* Make the system auditor role managed

* Flake8 fix

* Remove another thing from old solution

* Fix a few test failures

* Add extra setting to disable custom system roles via API

* Add test for custom role prohibition
 2024-04-11 14:59:09 -04:00
Alan Rominger 74ce21fa54 Bump number of allowed endpoints (#14956) 2024-04-11 14:59:09 -04:00
Alan Rominger eb93660b36 Cache organization child evaluations and remove hacks 2024-04-11 14:59:09 -04:00
Alan Rominger f50e597548 Cast ObjectRole object_id to int, very wrong, tmp fix 2024-04-11 14:59:09 -04:00
Alan Rominger 817c3b36b9 Replace role system with permissions-based DB roles 
Develop ability to list permissions for existing roles

Create a model registry for RBAC-tracked models

Write the data migration logic for creating
  the preloaded role definitions

Write migration to migrate old Role into ObjectRole model

This loops over the old Role model, knowing it is unique
  on object and role_field

Most of the logic is concerned with identifying the
  needed permissions, and then corresponding role definition

As needed, object roles are created and users then teams
  are assigned

Write re-computation of cache logic for teams
  and then for object role permissions

Migrate new RBAC internals to ansible_base

Migrate tests to ansible_base

Implement solution for visible_roles

Expose URLs for DAB RBAC
 2024-04-11 14:59:09 -04:00
Alan Rominger 1859a6ae69 Fix failure from DAB (#15102) 
@AlanCoding said to do this 🚌
 2024-04-11 17:10:11 +00:00
Alan Rominger cc5d4dd119 Clean the postgres 15 volume (#15083) 2024-04-09 16:06:42 -04:00
Alan Rominger 4b6f7e0ebe Add link to service-index URL 2024-03-29 10:07:15 +00:00
Alan Rominger 30500e5a95 Re-parent DAB views from AWX base 2024-03-29 10:03:12 +00:00
Alan Rominger f48b2d1ae5 Add resource and ansible_id to serializers (#15020) 2024-03-26 22:37:15 -04:00
Alan Rominger a4a2fabc01 Add test for utils method is_testing 2024-03-05 11:38:14 +00:00
Alan Rominger d70c6b9474 Reset another to test-playbooks 2024-02-21 15:11:12 +00:00
Alan Rominger 5549516a37 Reset these tests back to test-playbooks 2024-02-21 15:11:12 +00:00
Alan Rominger 14ac91a8a2 Swap repos test fix 2024-02-21 15:11:12 +00:00
Alan Rominger d5753818a0 Stop using the bulky test-playbooks in tests where possible 2024-02-21 15:11:12 +00:00
Alan Rominger 14454cc670 Fix playbook errors found by debugging 2024-02-21 14:36:41 +00:00
Alan Rominger 7ab2bca16e Fix missing var name change 2024-02-21 14:36:41 +00:00
Alan Rominger f0f655f2c3 Style consistency for task 'when' 2024-02-21 14:36:41 +00:00
Alan Rominger 1ebff23232 Do not rely on unreliable dir output and use exists query 2024-02-21 13:43:54 +00:00
Alan Rominger 700de14c76 Make the migration middleware faster, second attempt 2024-02-21 13:43:54 +00:00
Alan Rominger cd91fbf59f Label any changes to requirements folder with dependencies label 2024-02-19 15:56:53 +00:00
Alan Rominger 1f7be9258c Remove tower_legacy module_utils that appears unused (#14421) 
* Remove tower_legacy module that appears unused

* Update license details
 2024-02-16 16:02:09 -05:00
Alan Rominger 4d80f886e0 Revert "Drop cython dep" (#14884) 
* Revert "Remove cython lib"

This reverts commit 46f816e7a4.

* Revert "WIP consider droping cython dep"

This reverts commit 54b32c10f0.

* Update Cython comment
 2024-02-15 11:58:17 -05:00
Alan Rominger 362e11aaf2 Respect old downtime setting name if user has already set it 2024-02-15 12:34:24 +00:00
Alan Rominger 46f816e7a4 Remove cython lib 2024-02-13 14:45:28 +00:00
Alan Rominger 54b32c10f0 WIP consider droping cython dep 2024-02-13 14:45:28 +00:00
Alan Rominger 20202054cc Use lowercase password 2024-02-13 14:36:39 +00:00
Alan Rominger e84e2962d0 Support DB configs where PASSWORD is not used 2024-02-13 14:36:39 +00:00
Alan Rominger 4c41f6b018 Ability to use updater script to pin dev requirements (#14644) 
* Add a dev option for updater script to pin CI reqs

* Avoid removing git links for dev requirements

* Add dev to primary options

* Fix up sanitize git switch
 2024-02-12 11:57:59 -05:00
Alan Rominger 8eb4a9a2a0 Update location of logstash build context (#14676) 2024-02-12 15:49:29 +00:00
Alan Rominger a1bbe75aed Adopt new rules from black upgrade (#14809) 2024-01-26 12:54:44 -05:00
Alan Rominger d91da39f81 New setting for pg_notify listener DB settings, add keepalive (#14755) 2024-01-17 13:44:04 -05:00
Alan Rominger 325f5250db Narrow the actor types accepted for RBAC evaluations (#14709) 
* Narrow the scope of RBAC evaluations

* Update tests for RBAC method changes

* Simplify querset for credentials in org

* Fix call pattern to pass in team role obj
 2023-12-14 21:30:47 -05:00
Alan Rominger b14518c1e5 Simplify RBAC get_roles_on_resource method (#14710) 
* Simplify RBAC get_roles_on_resource method

* Fix bug

* Fix query type bug
 2023-12-14 10:42:26 -05:00
Alan Rominger 1294cec92c Fix updater bug due to missing newline at EOF (#14713) 2023-12-08 16:51:17 +00:00
Alan Rominger adb1b12074 Update RBAC docs, remove unused get_permissions (#14492) 
* Update RBAC docs, remove unused get_permissions

* Add back in section for get_roles_on_resource
 2023-11-16 11:29:33 -05:00
Alan Rominger 8fae20c48a Remove unused methods we attach to user model (#14668) 2023-11-16 11:21:21 -05:00
Alan Rominger 1f36e84b45 Correctly handle case where unpartitioned table does not exist (#14648) 2023-11-14 08:38:48 -05:00
Alan Rominger 93c329d9d5 Fix cancel bug - WorkflowManager cancel in transaction (#14608) 
This fixes a bug where jobs within a workflow job were not canceled
  when the workflow job was canceled by the user

The fix is to submit the cancel request as a part of the
  transaction that WorkflowManager commits its work in
  this requires that we send the message without expecting a reply
  so this changes the control-with-reply cancel to just a control function
 2023-10-30 15:30:18 -04:00
Alan Rominger 333ef76cbd Send notifications for dependency failures (#14603) 
* Send notifications for dependency failures

* Delete tests for deleted method

* Remove another test for removed method
 2023-10-30 10:42:37 -04:00
Alan Rominger fc0b58fd04 Fix bug that prevented dispatcher exit with downed DB (#14469) 
* Separate handling of original sitTERM and sigINT
 2023-10-26 14:34:25 -04:00
Alan Rominger b6b167627c Fix Boolean values defaulting to False in collection (#14493) 
* Fix Boolean values defaulting to False in collection

* Remove null values in other cases, fix null handling for WFJT nodes

* Only remove null values if it is a boolean field

* Reset changes to WFJT node field processing

* Use test content from sean-m-sullivan to fix lookups in assert
 2023-10-24 14:29:16 -04:00
Alan Rominger 07f49f5925 AAP-16926 Delete unpartitioned tables in a separate transaction (#14572) 2023-10-13 15:50:51 -04:00
Alan Rominger 19ca480078 Upgrade client library for dsv since tss already landed (#14362) 2023-10-11 16:01:22 -04:00
Alan Rominger 9745058546 Only block commits if black fails for certain paths (#14531) 2023-10-10 10:12:57 -04:00
Alan Rominger e72e9f94b9 Fix collection test flake due to successful canceled command (#14519) 2023-10-04 09:09:29 -04:00
Alan Rominger f5922f76fa DROP unnecessary unpartioned event tables (#14055) 2023-10-03 11:49:23 -04:00
Alan Rominger 1d340c5b4e Add a section for postgres max_connections value (#14482) 2023-09-28 10:28:52 -04:00
Alan Rominger 770cc10a78 Get rid of names_digest hack no longer needed (#14459) 2023-09-26 12:09:30 -04:00
Alan Rominger 159dd62d84 Add null value handling in create_partition (#14480) 2023-09-25 18:28:44 -04:00
Alan Rominger 9ed527eb26 Consolidate image and server setup in several checks (#14477) 2023-09-25 09:02:20 -04:00
Alan Rominger 29ad6e1eaa Fix bug, None was used instead of empty for DB outage (#14463) 2023-09-21 14:30:25 -04:00
Alan Rominger 3e607f8964 AAP-15927 Use ATTACH PARTITION to avoid exclusive table lock for events (#14433) 2023-09-21 14:27:04 -04:00