Commit Graph
100 Commits
Author SHA1 Message Date
Alan Rominger 083e56d97d Merge pull request #464 from AlanCoding/actiony_permissions
fix bug where JT admins could not edit spec
2017-10-19 16:22:14 -04:00
AlanCoding 098a407e25 fix bug where JT admins could not edit spec 2017-10-19 16:05:44 -04:00
Alan Rominger 6347db56c5 Merge pull request #473 from AlanCoding/test_fix_exc
fix test fallout from 321 merge
2017-10-19 16:05:01 -04:00
AlanCoding e660879a00 fix test fallout from 321 merge 2017-10-19 15:47:51 -04:00
Alan Rominger 353a9a55c7 Merge pull request #406 from AlanCoding/variables_debt
Consolidation of variables parsing throughout codebase
2017-10-13 15:40:36 -04:00
AlanCoding 993fa9290d additional verbosity for vars parsing exceptions 2017-10-13 11:41:11 -04:00
Alan Rominger ad0e43dc52 Merge pull request #379 from AlanCoding/awx160
Enforce max line length of 160 characters
2017-10-12 14:05:31 -04:00
AlanCoding 8b41810189 Consolidation of variables parsing throughout codebase
* Remove attempted support of key=value pattern, because
  it is not actually allowed in practice
* Have variables validator defer to the utils variables parser
* Prune serializers of a handful of cases that previous
  attempts at cleanup have missed
2017-10-11 16:21:50 -04:00
AlanCoding f03b40aa50 enforce max line length of 160 characters 2017-10-11 12:38:39 -04:00
Alan Rominger 70f8ec78de Merge pull request #517 from AlanCoding/vars_exception
fallback to empty dict when processing extra_data
2017-10-10 09:30:06 -04:00
AlanCoding e2c398ade2 fallback to empty dict when processing extra_data 2017-10-10 08:13:45 -04:00
Alan Rominger 7365e4a63f Merge pull request #516 from AlanCoding/abc_migrations
Fix 3.1.1->3.2.1 migration error
2017-10-09 16:37:35 -04:00
AlanCoding d4fc4bcd61 fix migration problem from 3.1.1 2017-10-09 15:49:38 -04:00
AlanCoding 4237b9ed5c move 0005a migration to 0005b 2017-10-09 15:48:52 -04:00
Alan Rominger 2dd2541550 Merge pull request #507 from AlanCoding/adhoc_word_smithing
[3.2.2] feedback on ad hoc prohibited vars error msg
2017-10-06 14:15:16 -04:00
AlanCoding edda5e5420 feedback on ad hoc prohibited vars error msg 2017-10-06 14:07:38 -04:00
Alan Rominger e8b79cde4a Merge pull request #499 from AlanCoding/adhoc_local
[3.2.1] Disallow Ansible vars in adhoc launch serializer + wayne's change
2017-10-05 15:30:06 -04:00
AlanCoding 81c14ce942 fix WARNING log when launching ad hoc command 2017-10-05 13:42:23 -04:00
AlanCoding eacbeef660 Validate against ansible variables on ad hoc launch
Share code between this check for ad hoc and JT callback
2017-10-05 12:14:05 -04:00
Alan Rominger 8c117e9ef1 Merge pull request #337 from AlanCoding/admin_cancel
allow WFJT admins to cancel scheduled jobs
2017-10-02 11:33:46 -04:00
AlanCoding 681770e25a allow WFJT admins to cancel scheduled jobs 2017-10-02 10:25:49 -04:00
Alan Rominger 2ec675cf54 Merge pull request #465 from AlanCoding/retry_retry
broaden inventory deletion retry condition
2017-09-26 14:48:13 -04:00
AlanCoding bfccd49a64 broaden inventory deletion retry condition 2017-09-26 10:45:30 -04:00
Alan Rominger 4c0fd573c6 Merge pull request #459 from AlanCoding/special_treatment
always ignore deprecated_group if in groups
2017-09-25 13:35:55 -04:00
Alan Rominger 5bec43fc8e Merge pull request #462 from AlanCoding/bad_groups
handle additional cases of inv script output
2017-09-25 13:31:16 -04:00
AlanCoding 647d272a31 handle additional cases of inv script output 2017-09-25 12:20:21 -04:00
AlanCoding a4a17fe14c always ignore deprecated_group if in groups
If overwrite=True for an inventory source import, then this matters
creating a new inventory source through v1 API will not include
deprecated_group inside of the InventorySource groups m2m related
connection, but migrations from 3.1 will

In those migrated cases, this code will leave the deprecated_group
untouched, so as to not trigger its cascade delete
2017-09-25 11:22:12 -04:00
Alan Rominger 9662719660 Merge pull request #226 from AlanCoding/host_option
add back logic to re-call script for hostvars
2017-09-22 06:46:32 -04:00
Alan Rominger 186d61aac4 Merge pull request #448 from AlanCoding/more_task_mgr_fixing
fix task manager running task structures
2017-09-21 16:27:32 -04:00
AlanCoding dba83674a2 fix task manager running task structures
- prevent dual-entry for first item in running jobs due to
   setdefault syntax
 - fix issue where queues (celery tasks) only returned the last
   item in the inspector output due to looping problem
   this caused reaper bugs in production
2017-09-21 14:38:58 -04:00
Alan Rominger 428eca1c35 Merge pull request #439 from AlanCoding/custom_hostvars
add back logic to re-call script for hostvars
2017-09-20 15:43:52 -04:00
AlanCoding f1219ea001 add back logic to recall script for hostvars 2017-09-20 15:31:13 -04:00
AlanCoding 80a944dd31 add back logic to recall script for hostvars 2017-09-20 13:20:04 -04:00
Alan Rominger 9db91b4344 Merge pull request #436 from AlanCoding/set_node_early
set execution_node right when jobs are accepted
2017-09-20 12:43:51 -04:00
AlanCoding 892ca98709 set execution_node right when jobs are accepted 2017-09-20 11:49:09 -04:00
Alan Rominger 88ffb32d4f Merge pull request #427 from AlanCoding/inv_for_the_people
Inventory file suggestion adjustments from user feedback
2017-09-19 10:36:02 -04:00
Alan Rominger bc4b622e6b Merge pull request #199 from AlanCoding/inv_no_yaml
Inventory file suggestion adjustments from user feedback
2017-09-19 08:40:20 -04:00
AlanCoding f455f1b257 Inventory file suggestion adjustments from user feedback
- ditch yaml files as suggestions
 - automatically greenlight any hosts or inventory titled file
2017-09-18 15:29:03 -04:00
AlanCoding 120b5297e3 Inventory file suggestion adjustments from user feedback
- ditch yaml files as suggestions
 - automatically greenlight any hosts or inventory titled file
2017-09-18 14:28:29 -04:00
Alan Rominger 4c28e04e5e Merge pull request #191 from AlanCoding/step_parent
do not use parent_model with GenericAPIView
2017-09-18 10:36:59 -04:00
AlanCoding 1b48b99ba7 do not use parent_model with GenericAPIView 2017-09-15 14:41:12 -04:00
Alan Rominger 7c920c305f Merge pull request #397 from AlanCoding/7583
add help for instance provisioning
2017-09-09 15:17:37 -07:00
AlanCoding 42ee804464 add help for instance provisioning 2017-09-08 14:36:17 -07:00
Alan Rominger 19ebd0aa68 Merge pull request #382 from AlanCoding/isolated_reaper
reap isolated jobs
2017-09-08 12:41:03 -07:00
AlanCoding 8e1e60c187 simplify isolated job reaping by checking all task ids 2017-09-08 12:30:05 -07:00
AlanCoding 878e7ef49f reap isolated jobs 2017-09-08 10:40:39 -07:00
AlanCoding 41940687f1 Pass existing object references within access methods
This avoids re-loading objects from the database in our
chain of permission checking, wherever possible.
access.py is equiped to handle object references instead
of pk ints, and permissions.py is changed to pass those refs.
2017-09-06 16:34:00 -07:00
Alan Rominger 757a91a7d2 Merge pull request #385 from AlanCoding/smart_validation
fuller validation for host_filter
2017-09-05 10:39:33 -04:00
AlanCoding a36a141141 fuller validation for host_filter 2017-08-31 23:10:09 -04:00
Alan Rominger 12537c2739 Merge pull request #376 from AlanCoding/host_filter_goof
fix bug with host_filter RBAC check
2017-08-31 12:09:00 -04:00
Alan Rominger 3530b643b6 Merge pull request #374 from AlanCoding/v1_adhoc
remove can_run_ad_hoc_commands in v2
2017-08-31 11:33:18 -04:00
AlanCoding 2027047220 fix bug with host_filter RBAC check 2017-08-31 10:42:16 -04:00
AlanCoding ceafa3803a remove can_run_ad_hoc_commands in v2 2017-08-30 23:14:05 -04:00
AlanCoding 853d38b757 remove unused signal_finished method 2017-08-30 13:44:37 -04:00
AlanCoding de58d6764f use exceptions for job cancel and failure 2017-08-30 13:19:53 -04:00
Alan Rominger de3b9fc70d Merge pull request #364 from AlanCoding/null_inv_val
more coherent source_script & inv validation
2017-08-30 10:35:04 -04:00
Alan Rominger 2385c28046 Merge pull request #366 from AlanCoding/logger_unicode
smart_str in log statement to avoid unicode error
2017-08-30 10:33:43 -04:00
AlanCoding 78ab13a44e smart_str in log statement to avoid unicode error 2017-08-30 09:47:18 -04:00
AlanCoding 20e82eba42 more coherent source_script & inv validation 2017-08-30 08:31:08 -04:00
Alan Rominger 7a1f674abc Merge pull request #363 from AlanCoding/org_smart_inv
backend of org-scoped smart inventories
2017-08-29 20:51:03 -04:00
Alan Rominger e679997ecc Merge pull request #359 from AlanCoding/fail_ans_inv
set flag to fail imports on errors
2017-08-29 16:51:48 -04:00
AlanCoding ff96a750e1 backend of org-scoped smart inventories 2017-08-29 16:43:56 -04:00
AlanCoding 9d91875832 set flag to fail imports on errors 2017-08-29 14:36:53 -04:00
Alan Rominger ba8326285e Merge pull request #337 from AlanCoding/capacity_fix
correct capacity algorithm for task manager
2017-08-28 16:49:19 -04:00
AlanCoding d54eb93f26 Handle capacity algorithm corner cases
Instance has gone lost, and jobs are still either running
or waiting inside of its instance group
RBAC - user does not have permission to see some of the
groups that would be used in the capacity calculation

For some cases, a naive capacity dictionary is returned,
main goal is to not throw errors and avoid unpredicted behavior

Detailed capacity tests are moved into new unit test file.
2017-08-28 16:12:12 -04:00
Alan Rominger c2d59e4815 Merge pull request #347 from AlanCoding/no_start
remove job start endpoint in v2
2017-08-28 12:11:32 -04:00
AlanCoding 5327a4c622 Use global capacity algorithm in serializer
The task manager was doing work to compute currently consumed
capacity, this is moved into the manager and applied in the
same form to the instance group list.
2017-08-28 12:07:47 -04:00
AlanCoding 495d6e9887 remove job start endpoint in v2 2017-08-28 11:12:13 -04:00
Alan Rominger c904ed62fe Merge pull request #348 from AlanCoding/jobs_opt
optimizations for unified job subtypes
2017-08-28 11:06:26 -04:00
AlanCoding ce3c969c08 correct capacity algorithm for task manager 2017-08-26 11:59:25 -04:00
Alan Rominger 34a375542e Merge pull request #339 from AlanCoding/encrypted_fix2
allow cache storing of non-DB settings
2017-08-26 11:57:29 -04:00
Alan Rominger d97cf263c1 Merge pull request #308 from AlanCoding/calm_your_signals2
avoid every-request user signals
2017-08-26 11:56:41 -04:00
AlanCoding 5cc5d4deff allow cache storing of non-DB settings 2017-08-25 13:59:31 -04:00
AlanCoding 50ff18ba25 avoid every-request user signals 2017-08-24 11:20:39 -04:00
Alan Rominger 223a198bc4 Merge pull request #317 from AlanCoding/token_on_commit
[WIP] delay token expiration update to on_commit
2017-08-22 10:56:15 -04:00
AlanCoding 4d41e31639 delay token expiration update to on_commit 2017-08-21 16:56:07 -04:00
AlanCoding a1083d45c5 optimizations for unified job subtypes 2017-08-19 07:05:37 -04:00
Alan Rominger 66a3680134 Merge pull request #295 from ansible/labels_load
basic API optimization of labels list
2017-08-18 17:23:55 -04:00
Alan Rominger caf15abc4f Merge pull request #297 from AlanCoding/cache_ids
Make cache compatible with encrypted settings
2017-08-18 17:20:57 -04:00
AlanCoding 1f2a7801fd fix flake8 and data gen functionality 2017-08-18 15:30:20 -04:00
AlanCoding 9254bcaf16 Make cache compatible with encrypted settings
This saves the id value of the setting into the cache
if the setting is encrypted. That can then be combined
with the secret_key in order to decrypt the setting,
without having to make an additional query to the database.
2017-08-17 17:18:41 -04:00
AlanCoding 66a8170bbc basic API optimization of labels list 2017-08-17 10:33:10 -04:00
Alan Rominger bd0d911376 Merge pull request #2 from AlanCoding/rollbacktothewall
data generator schema update
2017-08-17 08:15:52 -04:00
AlanCoding d48c1bd71d data generator schema update for 3.2 2017-08-16 17:14:56 -04:00
Alan Rominger 738fff65a1 Merge pull request #277 from AlanCoding/script_name
rename isolated->expect in script tooling
2017-08-15 13:35:46 -04:00
AlanCoding 86be5cf2cf rename isolated->expect in script tooling 2017-08-15 13:25:23 -04:00
Alan Rominger 5f71dba616 Merge pull request #262 from AlanCoding/graceful
Graceful killing of receiver workers
2017-08-15 13:11:07 -04:00
Alan Rominger 848e174fb1 Merge pull request #273 from AlanCoding/mooovin
Rename isolated folder to "expect"
2017-08-15 13:10:43 -04:00
AlanCoding 9ad34edc38 graceful killing of receiver worker processes 2017-08-15 12:13:47 -04:00
AlanCoding 6944ffa010 change imports to reflect isolated->expect move 2017-08-15 12:08:58 -04:00
AlanCoding e79ca131a6 initial commit to move folder isolated->expect 2017-08-15 11:32:44 -04:00
AlanCoding 8be1bea33a import os, fixing bug that forced SIGKILL 2017-08-15 06:32:21 -04:00
Alan Rominger 4ee95259f3 Merge pull request #255 from AlanCoding/ws_ig
provide instance group name over websocket
2017-08-14 15:13:03 -04:00
AlanCoding a6def691b7 provide instance group name over websocket 2017-08-14 13:56:12 -04:00
Alan Rominger 42ef2f265b Merge pull request #250 from AlanCoding/keep_on_truckin
pass over job-run exceptions & log ID
2017-08-14 12:14:37 -04:00
Alan Rominger bfa33dea56 Merge pull request #254 from AlanCoding/fix_adhoc_del
fix adhoc IG bug and prevent related inventory deletion
2017-08-14 11:37:21 -04:00
Alan Rominger dcfcfb6c7b Merge pull request #245 from AlanCoding/fix_supervisor
specify all group queues, get supervisor working
2017-08-14 11:31:00 -04:00
AlanCoding eed5a5c924 fix adhoc IG bug and prevent related inventory deletion 2017-08-14 11:14:42 -04:00
AlanCoding 5dfe0b205f pass over job-run exceptions & log ID 2017-08-14 09:57:32 -04:00
Alan Rominger e2db4b9001 Merge pull request #241 from AlanCoding/mutable
hack around mutability problem for v1 launch
2017-08-14 09:19:52 -04:00