External-Mirrors/awx
2
0
Fork 0
mirror of https://github.com/ansible/awx.git synced 2026-09-16 17:00:12 -02:30
Code Issues Packages Projects Releases Wiki Activity
34,340 Commits 63 Branches 102 Tags
0ba9fc69809bac5b2f5e04d12dade3073f0866fb
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Alan Rominger 0ba9fc6980 More PyGithub dep and license housekeeping (#15853) 2025-02-24 08:41:54 -05:00
Alan Rominger 3495c421c1 Fix: do not use current apps in migrations (#15839) 2025-02-19 07:58:24 -05:00
Alan Rominger 7d2b2d672c Make awx/main/tests/live dramatically faster (#15780) 
* Make awx/main/tests/live dramatically faster

* Add new setting to exclude list
 2025-02-08 21:07:56 -05:00
Alan Rominger 26346d237d Fix rsyslog permission error in github ubuntu tests from apparmor (#15717) 
* Add test to detect rsyslog config problems

* Get dmesg output

* Disable apparmor for rsyslogd
 2025-02-05 08:38:55 -05:00
Alan Rominger 30b0c19e72 AAP-38528 Make default state passing for coverage targets (#15772) 
* Make default state passing for coverage targets

* Implement Pablo suggestion for patch vs project

* bump up based on current values
 2025-01-31 08:40:40 -05:00
Alan Rominger c418bc034f Put duplicate plugin location in error message (#15781) 2025-01-29 17:15:02 -05:00
Alan Rominger d639953a4c Removing some (but not all) dead pytest fixtures (#15782) 
* Try removing dead fixtures

* Add back in EE fixture
 2025-01-29 17:13:31 -05:00
Alan Rominger 1f503645fd Move some more tests out of root functional folder (#15753) 2025-01-24 15:04:59 -05:00
Alan Rominger 534c312328 Use upload artifact v4 
unique-ify name

psh, who needs loops

Folder management

Extracts into current path
 2025-01-23 16:56:19 -05:00
Alan Rominger c43dfde45a Create test for using manual & file projects (#15754) 
* Create test for using a manual project

* Chang default project factory to git, remove project files monkeypatch

* skip update of factory project

* Initial file scaffolding for feature

* Fill in galaxy and names

* Add README, describe project folders and dependencies
 2025-01-20 17:06:15 -05:00
Alan Rominger f57a9863d6 Use advisory_lock from DAB (#15676) 
* Use advisory_lock from DAB

* Remove the django-pglocks dep

* Re-run updater script

* Move the import in new location
 2025-01-15 14:06:59 -05:00
Alan Rominger c45eb43d63 Update logstash container image and remove ELK stack (#15744) 
* Migrate to new image for logstash container

* Remove ELK stack tooling I will not maintain
 2025-01-15 07:43:38 -05:00
Alan Rominger fb12c834eb Add test to ensure bootstrap reqs are good (#15733) 
* Add test to ensure bootstrap reqs are good

* Give full diff list in assert
 2025-01-13 14:31:19 -05:00
Alan RomingerandSatoe Imaishi c1572af1d4 Fix dependency upgrades (#15740) 
* Update dependencies to fix offline build

* Downgrade cryptography due to compatibility issue with openssl

* Downgrade setuptools

* Run update script to assure constraints work

* Maintain pin on cryptography

* Small adjustment to comment

---------

Co-authored-by: Satoe Imaishi <simaishi@redhat.com>
 2025-01-10 21:18:48 +00:00
Alan Rominger 3e50b019e0 Delete test file that should have been removed and fix checks (#15739) 
* Delete test file that should have been removed

* Add more insights env variables
 2025-01-10 13:10:24 -05:00
Alan Rominger 2d7bbc4ec8 AAP-37080 Delete the cleanup_tokens system job template (#15711) 
Delete the cleanup_tokens system job template
 2025-01-10 10:33:35 -05:00
Alan Romingerandjessicamack 2186c24c8f General upgrade of dependencies (#15705) 
* General upgrade of dependencies

* adjust licenses to match requirements

* add missing licenses

* another pass to fix licenses

* Try easy for for psycopg encoding pattern change

---------

Co-authored-by: jessicamack <jmack@redhat.com>
 2025-01-07 15:03:43 -05:00
Alan Rominger 9a5ed20ed5 AAP-37989 Tests for exclude list with multiple jobs (#15722) 
* Tests for exclude list with multiple jobs
 2025-01-02 16:38:09 -05:00
Alan Rominger 2657ea840b Disable color logs in CI (#15719) 
* Disable color logs in CI

* Disable management command color
 2025-01-02 16:19:59 -05:00
Alan Rominger 14808cb99b Move RBAC functional tests into folder (#15723) 2024-12-20 14:54:52 -05:00
Alan Rominger 288e8d78d3 Cleanup in-memory data from test that randomly causes other failures (#15716) 2024-12-18 16:59:42 -05:00
Alan Rominger c0158181c3 Fix test warnings that escaped somehow (#15714) 2024-12-18 15:21:53 -05:00
Alan Rominger 65b104e1f9 Upload container logs for live tests (#15713) 
* Upload container logs for live tests

* Get rid of dash that does nothing
 2024-12-18 20:17:01 +00:00
Alan Rominger 36c75a2c62 AAP-36536 Send job_lifecycle logs to external loggers (#15701) 
* Send job_lifecycle logs to external loggers

* Include structured data in message

* Attach the organization_id of the job
 2024-12-16 15:49:16 -05:00
Alan Rominger f377b5fdde Use runtime log utility moved to DAB (#15675) 
* Use runtime log utility moved to DAB
 2024-12-11 10:38:24 -05:00
Alan Rominger 32122e6822 Fix misused project cache identifier (#15690) 
Fix project cache identifiers for new updates

Finish test and discover viable solution

Add comment on related task code
 2024-12-10 15:26:17 -05:00
Alan Rominger 325b6d3997 Fix missing exception catch in create_partition (#15691) 
Fix error creating partition due to uncaught exception

the primary fix is to simply add an exception class
  to those caught in the except block

This also adds live tests for the general scenario
  although this does not hit the new exception type
 2024-12-09 20:57:14 -05:00
Alan Rominger 91d92a6636 Make dev script work in combined environment (#15684) 2024-12-09 09:07:17 -05:00
Alan Rominger 1a35775c25 Create a new pytest folder for live system testing with normal services (#15688) 
* PoC for running dev env tests

* Replace in github actions

* Try non interactive

* Move folder to better location

* Further streamlining of new test folders

* Consolidate fixture, add writeup docs

* Use star import

* Push the wait-for-job to the conftest
 2024-12-06 09:20:26 -05:00
Alan Rominger c64b5eb462 Fix missing dependencies due to extras - vs _ (#15677) 
Fix missing dependencies
 2024-12-02 13:32:27 -05:00
Alan Rominger adc2162bac Ignore warnings so people can run tests on python 3.12 (#15663) 2024-12-02 11:53:04 -05:00
Alan Rominger 789a43077f Address unclosed fd warnings 2024-11-25 14:01:21 -05:00
Alan Rominger d2cd4e08c5 Do not check error state if null (#15655) 2024-11-22 07:47:48 -05:00
Alan Rominger ce7911e578 Revive the logstash container for testing (#15654) 
* Revive the logstash container for testing

* yamllint
 2024-11-21 20:11:16 +00:00
Alan Rominger 6599f3f827 Removal of OAuth2 stuff from CLI 
also from awxkit generally

Remove login command
 2024-11-20 11:18:52 -05:00
Alan Rominger 670b7e7754 Fix server error from system job detail view (#15640) 2024-11-19 12:53:32 -05:00
Alan Rominger d26396ce74 Fix error with CLI monitor of ad hoc output (#15642) 2024-11-18 13:52:20 -05:00
Alan Rominger 3dbcfb138c Add test that resource list does not server error (#15635) 2024-11-15 11:12:18 -05:00
Alan Rominger 989a4387df Set coverage limits so we do not have current failures (#15629) 
* Set coverage limits so we do not have current failures

* Fix to reflect changed number of jobs
 2024-11-12 13:50:12 -05:00
Alan RomingerandSviatoslav Sydorenko c9f880414c Make lookup plugins return lists to fix failures (#15625) 
* Make lookup plugins return lists to fix failures

* Update unit tests

* Use lookup for test failures, update docs

* Grammar fix from review

Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>

---------

Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
 2024-11-12 12:37:38 -05:00
Alan Rominger f4cbb9f9a8 Fix bug where unrelated jobs were linked as dependencies (#15610) 2024-11-06 14:43:36 -05:00
Alan Rominger 68055bb89f Add back git requirements as comments & re-run script (#15317) 
* Add back git requirements as comments

* Add comment to commented out git lines for clarity

* Re run the updater script

* Add new licenses

* Fix library name
 2024-10-28 19:44:06 -04:00
Alan Rominger 97ececa8b4 Fix 500 error due to None data in DAB response (#15562) 
* Fix 500 error due to None data in DAB response

* NOQA for flake8 failures
 2024-10-02 11:27:08 -04:00
Alan Rominger 5b7a0504f4 Enable service redirect auth and reverse-sync from DAB (#15489) 
* Update settings from DAB features

* Move to the end of the list more correctly
 2024-09-23 08:52:06 -04:00
Alan Rominger 50db80182b Remove archaic monkey patches (#15338) 2024-08-28 21:50:00 -04:00
Alan Rominger 9cf66de454 Pin DAB to devel again (#15467) 2024-08-27 11:18:09 -04:00
Alan Rominger f5760b149d Fix 500 error when ordinary user viewed system JTs (#15465) 2024-08-26 11:51:16 -04:00
Alan Romingerandchrismeyersfsu 5a8429deed Update django-ansible-base version to 2024.8.19 (#15454) 
Update django-ansible-base version to 2024.8.9

Co-authored-by: chrismeyersfsu <722880+chrismeyersfsu@users.noreply.github.com>
 2024-08-21 14:16:49 -04:00
Alan Rominger af537b5261 Rewrite more access logic in terms of permissions instead of roles (#15453) 
* Rewrite more access logic in terms of permissions instead of roles

* Cut down supported logic because that would not work anyway

* Remove methods not needed anymore

* Create managed roles in test before delegating permissions
 2024-08-21 13:14:40 -04:00
Alan Rominger af02ab46e3 Bump DAB version manually because bot is on vacation (#15434) 2024-08-09 15:42:18 -04:00
Alan Rominger 59f61517d4 Loosen up team EE restrictions (#15384) 
* Try to loosen up team EE restrictions

* Fix missed permission case of nulling EE org
 2024-07-22 14:51:32 -04:00
Alan Rominger fa670e2d7f Upgrade to v4 checkout, hide output (#15322) 2024-07-19 15:33:11 -04:00
Alan Rominger 381ade1148 Fix create_preload_data to allow running without an admin user created (#15356) 
* Allow create_preload_data without having superuser created first

* Temporarily change the DAB requirement

* Put DAB branch back to devel
 2024-07-19 10:35:33 -04:00
Alan Rominger fde8af9f11 Fix task ending in error due to bad iterator (#15355) 2024-07-12 13:20:39 -04:00
Alan Rominger 282ba36839 Fix EE admin not being able to PATCH/PUT object while providing organization (#15348) 
* Fix bug where EE object-level admin could not set organization

* Finish polishing up test
 2024-07-09 16:55:09 -04:00
Alan Rominger b727d2c3b3 Log conflicts and created items by the periodic resource sync (#15337) 
* Initial lazy logging of periodic sync results

* Add desired polish to log

* Add debug log
 2024-07-09 15:13:08 -04:00
Alan Rominger ea232315bf Do not reference self.messages when it does not exist (#15331) 2024-07-03 20:07:46 +00:00
Alan Rominger ee251812b5 Add complete test that we have analogs to old versions of roles, fix some mismatches (#15321) 
* Add test that we got all permissions right for every role

* Fix missing Org execute role and missing adhoc role permission

* Add in missing Organization Approval Role as well

* Remove Role from role names
 2024-07-03 15:40:55 -04:00
Alan Rominger 00ba1ea569 Suppress docker pull output in checks (#15323) 
Supress docker pull output in checks
 2024-07-03 15:04:59 -04:00
Alan Rominger d91af132c1 Fix server error assigning teams EE object roles (#15320) 2024-07-03 14:07:03 -04:00
Alan Rominger c4688d6298 Add in missing read permissions for organization audit role (#15318) 
* Add in missing read permissions for organization audit role

* Add missing audit permission, special case name handling
 2024-07-02 15:20:40 -04:00
Alan Rominger 98bbc836a6 Fix server error from DAB ValidationError with strings (#15312) 2024-07-01 10:11:22 -04:00
Alan Rominger b59aff50dc Update ExecutionEnvironment model so object-level roles work with DAB RBAC system (#15289) 
* Add initial test for deletion of stale permission

* Delete existing EE view permission

* Hypothetically complete update of EE model permissions setup

* Tests passing locally

* Issue with user_capabilities was a test bug, fixed
 2024-06-28 16:09:42 -04:00
Alan Rominger a70b0c1ddc Do not use cache in github image build action (#15308) 
* Do not use cache in actual image build action

* Add cache args to kube prod builds
 2024-06-28 09:52:59 -04:00
Alan Rominger db72c9d5b8 Fix permissions that come from an external auditor role (#15291) 
* Add tests for external auditor

* Add assertion for unified JTs which fails

* Fix UJT listing bug

* Add test for ad hoc commands just to be sure
 2024-06-27 15:57:39 -04:00
Alan Rominger dbc2215bb6 Make attached user models adhere to new API assignments (#15298) 2024-06-26 23:00:25 -04:00
Alan RomingerandSeth Foster 853af295d9 Various RBAC fixes related to managed RoleDefinitions (#15287) 
* Add migration testing for certain managed roles

* Fix managed role bugs

* Add more tests

* Fix another bug with org workflow admin role reference

* Add test because another issue is fixed

* Mark reason for test

* Remove internal markers

* Reword failure message

Co-authored-by: Seth Foster <fosterseth@users.noreply.github.com>

---------

Co-authored-by: Seth Foster <fosterseth@users.noreply.github.com>
 2024-06-21 09:29:34 -04:00
Alan Rominger 4738c8333a Fix object-level permission bugs with DAB RBAC system (#15284) 
* Fix object-level permission bugs with DAB RBAC system

* Fix NT organization change regression

* Mark tests to AAP number
 2024-06-20 16:34:34 -04:00
Alan Rominger d5bad1a533 Pass the Makefile python exe to ansible-playbook (#15282) 2024-06-18 13:03:01 -04:00
Alan Rominger f6c0effcb2 Use public methods to reference registered models (#15277) 2024-06-17 11:45:44 -04:00
Alan Rominger 208ef0ce25 Update test so that DAB change can merge (#15222) 2024-05-28 11:53:01 -04:00
Alan Rominger 8de8f6dce2 Update a few dev requirements (#15203) 
* Update a few dev requirements

* Fix test failures due to upgrade

* Update patterns for mocker usage
 2024-05-20 23:37:02 +00:00
Alan Rominger 918d5b3565 Do some aesthetic adjustments to role presentation fields (#15153) 
* Do some asthetic adjustments to role presentation fields

* Correctly test managed setup

* Minor migration adjustments
 2024-04-29 17:11:10 -04:00
Alan Rominger 014534bfa5 Upgrade DRF (#15144) 
* Upgrade DRF

* Fix failures caused by DRF upgrade
 2024-04-25 15:37:08 -04:00
Alan Rominger 47a061eb39 Fix and test data migration error from DAB RBAC (#15138) 
* Fix and test data migration error from DAB RBAC

* Fix up migration test

* Fix custom method bug

* Fix another fat fingered bug
 2024-04-24 15:14:03 -04:00
Alan Rominger c760577855 Adjust test for stricter DAB user view permission enforcement (#15130) 2024-04-23 15:21:06 -04:00
Alan Rominger e3af658f82 Use released version of django-radius (#15103) 2024-04-12 16:34:23 -04:00
Alan Rominger 390c2d8907 [RBAC] Update related name to reflect upstream DAB change (#15093) 
Update related name to reflect upstream DAB change
 2024-04-11 14:59:09 -04:00
Alan Rominger 97605c5f19 Make custom urls work with RBAC 2024-04-11 14:59:09 -04:00
Alan Rominger 818c326160 [RBAC] Rename managed role definitions, and move migration logic here (#15087) 
* Rename managed role definitions, and move migration logic here

* Fix naming capitalization
 2024-04-11 14:59:09 -04:00
Alan RomingerandSeth Foster c98727d83e [RBAC] Fix bug where team could not be given read_role to other team (#15067) 
* Fix bug where team could not be given read_role to other team

* Avoid unwanted triggers of parentage granting

* Restructure signal structure

* Fix another bug unmasked by team member permission fix

* Changes to live with test writing

* Use equality as opposed to string "in"

from Seth in review comment

Co-authored-by: Seth Foster <fosterseth@users.noreply.github.com>

---------

Co-authored-by: Seth Foster <fosterseth@users.noreply.github.com>
 2024-04-11 14:59:09 -04:00
Alan Rominger a138a92e67 [RBAC] Tweaks to reflect what endpoints are deprecated (#15068) 
Tweaks to reflect what endpoints are deprecated
 2024-04-11 14:59:09 -04:00
Alan Rominger 7aed19ffda Fix missing role membership when giving creator permissions (#15058) 2024-04-11 14:59:09 -04:00
Alan Rominger 389a729b75 [RBAC] Fix known issues with backward compatible access_list (#15052) 
* Remove duplicate access_list entries for direct team access

* Revert test changes for superuser in access_list
 2024-04-11 14:59:09 -04:00
Alan Rominger 2f3c9122fd Generalize can_delete solution, use devel DAB (#15009) 
* Generalize can_delete solution, use devel DAB

* Fix bug where model was used instead of model_name

* Linter fixes
 2024-04-11 14:59:09 -04:00
Alan Rominger 733478ee19 [RBAC] Fix server error from delete capability of approvals (#15002) 
Fix server error from delete capability of approvals
 2024-04-11 14:59:09 -04:00
Alan Rominger 41c6337fc1 [RBAC] Fix migration for created and modified field changes (#14999) 
Fix migration for created and modified field changes
 2024-04-11 14:59:09 -04:00
Alan Rominger 7446da1c2f Bump migration number for RBAC branch 2024-04-11 14:59:09 -04:00
Alan Rominger c79fca5ceb Adopt internal DAB RBAC Permission model (#14994) 2024-04-11 14:59:09 -04:00
Alan Rominger dc5f43927a Minor RBAC test fix (#14982) 2024-04-11 14:59:09 -04:00
Alan Rominger 35a5a81e19 Use AWX base view to make unauth requests 401 (#14981) 2024-04-11 14:59:09 -04:00
Alan Rominger 9dcc11d54c [DAB RBAC] Re-implement system auditor as a singleton role in new system (#14963) 
* Add new enablement settings from DAB RBAC

* Initial implementation of system auditor as role without testing

* Fix system auditor role, remove duplicate assignments

* Make the system auditor role managed

* Flake8 fix

* Remove another thing from old solution

* Fix a few test failures

* Add extra setting to disable custom system roles via API

* Add test for custom role prohibition
 2024-04-11 14:59:09 -04:00
Alan Rominger 74ce21fa54 Bump number of allowed endpoints (#14956) 2024-04-11 14:59:09 -04:00
Alan Rominger eb93660b36 Cache organization child evaluations and remove hacks 2024-04-11 14:59:09 -04:00
Alan Rominger f50e597548 Cast ObjectRole object_id to int, very wrong, tmp fix 2024-04-11 14:59:09 -04:00
Alan Rominger 817c3b36b9 Replace role system with permissions-based DB roles 
Develop ability to list permissions for existing roles

Create a model registry for RBAC-tracked models

Write the data migration logic for creating
  the preloaded role definitions

Write migration to migrate old Role into ObjectRole model

This loops over the old Role model, knowing it is unique
  on object and role_field

Most of the logic is concerned with identifying the
  needed permissions, and then corresponding role definition

As needed, object roles are created and users then teams
  are assigned

Write re-computation of cache logic for teams
  and then for object role permissions

Migrate new RBAC internals to ansible_base

Migrate tests to ansible_base

Implement solution for visible_roles

Expose URLs for DAB RBAC
 2024-04-11 14:59:09 -04:00
Alan Rominger 1859a6ae69 Fix failure from DAB (#15102) 
@AlanCoding said to do this 🚌
 2024-04-11 17:10:11 +00:00
Alan Rominger cc5d4dd119 Clean the postgres 15 volume (#15083) 2024-04-09 16:06:42 -04:00
Alan Rominger 4b6f7e0ebe Add link to service-index URL 2024-03-29 10:07:15 +00:00
Alan Rominger 30500e5a95 Re-parent DAB views from AWX base 2024-03-29 10:03:12 +00:00