Commit Graph
100 Commits
Author SHA1 Message Date
Alan Rominger 7fe22e9c53 Merge pull request #757 from AlanCoding/vault_cred_noop
allow no-op case for vault_credential
2017-12-04 16:01:00 -05:00
Alan Rominger 42d8368596 Merge pull request #763 from AlanCoding/remember_where_you_came_from
add AWX meta extra_vars for workflow + schedule
2017-12-04 15:52:30 -05:00
AlanCoding eecf997856 add AWX meta extra_vars: WFJT + schedule 2017-12-04 15:33:05 -05:00
AlanCoding dfc154ed95 allow no-op case for vault_credential 2017-12-01 10:29:23 -05:00
Alan Rominger fde5a8850d Merge pull request #748 from AlanCoding/no_job_in_relaunch
Do not show job serialization in relaunch GET
2017-11-30 09:58:35 -05:00
AlanCoding c359c072c4 do not show job serialization in relaunch GET 2017-11-30 08:47:35 -05:00
Alan Rominger 53c6248a6d Merge pull request #647 from AlanCoding/no_sql
remove raw SQL in visible_roles
2017-11-29 16:46:09 -05:00
AlanCoding c4bc310271 remove raw SQL in visible_roles 2017-11-29 16:04:31 -05:00
Alan Rominger 43c58b5bf5 Merge pull request #731 from AlanCoding/enabled_fix
fix inventory import bug with enabled_var
2017-11-29 14:46:16 -05:00
AlanCoding 2c06bfc9ce fix inventory import bug with enabled_var 2017-11-29 14:12:03 -05:00
Alan Rominger 5602b5d2d7 Merge pull request #733 from AlanCoding/credentials_in_list
Show credentials in list view
2017-11-29 12:09:52 -05:00
Alan Rominger 04f682bf7a Merge pull request #694 from AlanCoding/credentials_not_a_thing
adjust assertions about JT credentials to be correct
2017-11-29 10:41:48 -05:00
Alan Rominger 070a12a10c Merge pull request #692 from AlanCoding/vault_credential_check
Modify JT access tests to reflect new vault_credential reality
2017-11-29 10:40:35 -05:00
AlanCoding 37a44c439e show credentials in list view 2017-11-29 08:14:45 -05:00
Alan Rominger 8f5be46d52 Merge pull request #730 from AlanCoding/list_bug
fix bug with inventory update queryset
2017-11-28 18:41:39 -05:00
AlanCoding a880f47925 fix bug with inventory update queryset 2017-11-28 14:13:35 -05:00
AlanCoding 9fe524cd20 adjust assertions about JT credentials to be correct 2017-11-21 10:03:57 -05:00
AlanCoding 1481a62b23 modify JT access tests to reflect new vault_credential reality 2017-11-21 08:40:04 -05:00
Alan Rominger ce6d96feda Merge pull request #687 from AlanCoding/new_kill
allow deletion of new jobs
2017-11-21 07:20:05 -05:00
AlanCoding 6c57a3bb68 allow deletion of new jobs 2017-11-20 11:19:22 -05:00
Alan Rominger 71127c039d Merge pull request #668 from AlanCoding/null_cred_okay2
Do not filter out JTs with null credentials
2017-11-16 11:18:16 -05:00
AlanCoding 127da5525c do not filter out JTs with null credentials 2017-11-16 10:20:41 -05:00
Alan Rominger 0f52ab47a0 Merge pull request #665 from AlanCoding/prefetch_credentials
prefetch UnifiedJob related credentials
2017-11-16 09:57:22 -05:00
AlanCoding 8cb5ce8307 prefetch UnifiedJob related credentials 2017-11-15 22:35:10 -05:00
Alan Rominger 93b80307db Merge pull request #624 from AlanCoding/dev_super
get development supervisor use working again
2017-11-14 10:14:11 -05:00
Alan Rominger 0a883edd4d Merge pull request #632 from AlanCoding/some_test_fixes
do not use expensive visible_roles for Activity Stream filter
2017-11-14 09:56:27 -05:00
AlanCoding 7eac219eae do not use expensive visible_roles for Act Stream filter 2017-11-14 08:37:14 -05:00
AlanCoding 805170ffd7 get development supervisor use working again 2017-11-13 20:31:32 -05:00
Alan Rominger 1ed3a8f0e9 Merge pull request #566 from AlanCoding/no_can_read
Fix bug where system gets 404 viewing job detail view
2017-11-06 15:23:30 -05:00
AlanCoding 270a41443c fix bug of system auditor 404 viewing job 2017-11-03 08:20:15 -04:00
Alan Rominger 0579db1162 Merge pull request #439 from AlanCoding/retry_subset
Feature: retry on subset of jobs hosts
2017-11-01 11:33:15 -04:00
AlanCoding 41c84b4652 update retry-on-failed acceptance docs
Relaunching by other status values is tabled for later.
2017-11-01 10:24:46 -04:00
AlanCoding 0ae9283fba Feature: retry on subset of jobs hosts 2017-11-01 10:22:52 -04:00
AlanCoding d7ae95684c fix bug with dependent SCM inv updates
This change causes all SCM inventory updates to run a local
project sync unless they were specifically marked as a
dependency of an already-existing project update, as
opposed to just doing so on manual launch types.

This should be a more robust criteria.
2017-10-30 11:59:33 -04:00
AlanCoding 8b39b3b41a fix admin edit of WFJT survey spec 2017-10-29 16:27:16 -04:00
Alan Rominger d7f5ef6564 Merge pull request #511 from AlanCoding/wrong_type_error
raise error for invalid type lookup
2017-10-27 14:14:11 -04:00
Alan Rominger bc7793def1 Merge pull request #494 from AlanCoding/get_queryset_modest_refactor
Refactor get_queryset inside of access.py
2017-10-26 13:52:08 -04:00
AlanCoding 4e16b19ae6 Refactor access.py get_queryset into filtering method
Use BaseAccess class to enforce the superuser and system
  auditor conditions, as well as the optimizations.
Declare optimizations on access class as tuple.
Limit role of access class method narrowly to RBAC filtering.
2017-10-26 11:40:08 -04:00
AlanCoding b4a446dba0 raise error for invalid type lookup 2017-10-26 11:25:40 -04:00
Alan Rominger 641b18fe13 Merge pull request #509 from AlanCoding/lib_test_fixes
update tests to new Ansible core code
2017-10-26 09:28:52 -04:00
AlanCoding e5d2eb9f3d update tests to new Ansible core code 2017-10-26 08:34:00 -04:00
Alan Rominger 73ece87e68 Merge pull request #487 from AlanCoding/E722
flake8: comply with new E722 rule
2017-10-23 14:58:27 -04:00
AlanCoding 90f63774f4 flake8: comply with new E722 rule 2017-10-23 14:36:48 -04:00
Alan Rominger 083e56d97d Merge pull request #464 from AlanCoding/actiony_permissions
fix bug where JT admins could not edit spec
2017-10-19 16:22:14 -04:00
AlanCoding 098a407e25 fix bug where JT admins could not edit spec 2017-10-19 16:05:44 -04:00
Alan Rominger 6347db56c5 Merge pull request #473 from AlanCoding/test_fix_exc
fix test fallout from 321 merge
2017-10-19 16:05:01 -04:00
AlanCoding e660879a00 fix test fallout from 321 merge 2017-10-19 15:47:51 -04:00
Alan Rominger 353a9a55c7 Merge pull request #406 from AlanCoding/variables_debt
Consolidation of variables parsing throughout codebase
2017-10-13 15:40:36 -04:00
AlanCoding 993fa9290d additional verbosity for vars parsing exceptions 2017-10-13 11:41:11 -04:00
Alan Rominger ad0e43dc52 Merge pull request #379 from AlanCoding/awx160
Enforce max line length of 160 characters
2017-10-12 14:05:31 -04:00
AlanCoding 8b41810189 Consolidation of variables parsing throughout codebase
* Remove attempted support of key=value pattern, because
  it is not actually allowed in practice
* Have variables validator defer to the utils variables parser
* Prune serializers of a handful of cases that previous
  attempts at cleanup have missed
2017-10-11 16:21:50 -04:00
AlanCoding f03b40aa50 enforce max line length of 160 characters 2017-10-11 12:38:39 -04:00
Alan Rominger 70f8ec78de Merge pull request #517 from AlanCoding/vars_exception
fallback to empty dict when processing extra_data
2017-10-10 09:30:06 -04:00
AlanCoding e2c398ade2 fallback to empty dict when processing extra_data 2017-10-10 08:13:45 -04:00
Alan Rominger 7365e4a63f Merge pull request #516 from AlanCoding/abc_migrations
Fix 3.1.1->3.2.1 migration error
2017-10-09 16:37:35 -04:00
AlanCoding d4fc4bcd61 fix migration problem from 3.1.1 2017-10-09 15:49:38 -04:00
AlanCoding 4237b9ed5c move 0005a migration to 0005b 2017-10-09 15:48:52 -04:00
Alan Rominger 2dd2541550 Merge pull request #507 from AlanCoding/adhoc_word_smithing
[3.2.2] feedback on ad hoc prohibited vars error msg
2017-10-06 14:15:16 -04:00
AlanCoding edda5e5420 feedback on ad hoc prohibited vars error msg 2017-10-06 14:07:38 -04:00
Alan Rominger e8b79cde4a Merge pull request #499 from AlanCoding/adhoc_local
[3.2.1] Disallow Ansible vars in adhoc launch serializer + wayne's change
2017-10-05 15:30:06 -04:00
AlanCoding 81c14ce942 fix WARNING log when launching ad hoc command 2017-10-05 13:42:23 -04:00
AlanCoding eacbeef660 Validate against ansible variables on ad hoc launch
Share code between this check for ad hoc and JT callback
2017-10-05 12:14:05 -04:00
Alan Rominger 8c117e9ef1 Merge pull request #337 from AlanCoding/admin_cancel
allow WFJT admins to cancel scheduled jobs
2017-10-02 11:33:46 -04:00
AlanCoding 681770e25a allow WFJT admins to cancel scheduled jobs 2017-10-02 10:25:49 -04:00
Alan Rominger 2ec675cf54 Merge pull request #465 from AlanCoding/retry_retry
broaden inventory deletion retry condition
2017-09-26 14:48:13 -04:00
AlanCoding bfccd49a64 broaden inventory deletion retry condition 2017-09-26 10:45:30 -04:00
Alan Rominger 4c0fd573c6 Merge pull request #459 from AlanCoding/special_treatment
always ignore deprecated_group if in groups
2017-09-25 13:35:55 -04:00
Alan Rominger 5bec43fc8e Merge pull request #462 from AlanCoding/bad_groups
handle additional cases of inv script output
2017-09-25 13:31:16 -04:00
AlanCoding 647d272a31 handle additional cases of inv script output 2017-09-25 12:20:21 -04:00
AlanCoding a4a17fe14c always ignore deprecated_group if in groups
If overwrite=True for an inventory source import, then this matters
creating a new inventory source through v1 API will not include
deprecated_group inside of the InventorySource groups m2m related
connection, but migrations from 3.1 will

In those migrated cases, this code will leave the deprecated_group
untouched, so as to not trigger its cascade delete
2017-09-25 11:22:12 -04:00
Alan Rominger 9662719660 Merge pull request #226 from AlanCoding/host_option
add back logic to re-call script for hostvars
2017-09-22 06:46:32 -04:00
Alan Rominger 186d61aac4 Merge pull request #448 from AlanCoding/more_task_mgr_fixing
fix task manager running task structures
2017-09-21 16:27:32 -04:00
AlanCoding dba83674a2 fix task manager running task structures
- prevent dual-entry for first item in running jobs due to
   setdefault syntax
 - fix issue where queues (celery tasks) only returned the last
   item in the inspector output due to looping problem
   this caused reaper bugs in production
2017-09-21 14:38:58 -04:00
Alan Rominger 428eca1c35 Merge pull request #439 from AlanCoding/custom_hostvars
add back logic to re-call script for hostvars
2017-09-20 15:43:52 -04:00
AlanCoding f1219ea001 add back logic to recall script for hostvars 2017-09-20 15:31:13 -04:00
AlanCoding 80a944dd31 add back logic to recall script for hostvars 2017-09-20 13:20:04 -04:00
Alan Rominger 9db91b4344 Merge pull request #436 from AlanCoding/set_node_early
set execution_node right when jobs are accepted
2017-09-20 12:43:51 -04:00
AlanCoding 892ca98709 set execution_node right when jobs are accepted 2017-09-20 11:49:09 -04:00
Alan Rominger 88ffb32d4f Merge pull request #427 from AlanCoding/inv_for_the_people
Inventory file suggestion adjustments from user feedback
2017-09-19 10:36:02 -04:00
Alan Rominger bc4b622e6b Merge pull request #199 from AlanCoding/inv_no_yaml
Inventory file suggestion adjustments from user feedback
2017-09-19 08:40:20 -04:00
AlanCoding f455f1b257 Inventory file suggestion adjustments from user feedback
- ditch yaml files as suggestions
 - automatically greenlight any hosts or inventory titled file
2017-09-18 15:29:03 -04:00
AlanCoding 120b5297e3 Inventory file suggestion adjustments from user feedback
- ditch yaml files as suggestions
 - automatically greenlight any hosts or inventory titled file
2017-09-18 14:28:29 -04:00
Alan Rominger 4c28e04e5e Merge pull request #191 from AlanCoding/step_parent
do not use parent_model with GenericAPIView
2017-09-18 10:36:59 -04:00
AlanCoding 1b48b99ba7 do not use parent_model with GenericAPIView 2017-09-15 14:41:12 -04:00
Alan Rominger 7c920c305f Merge pull request #397 from AlanCoding/7583
add help for instance provisioning
2017-09-09 15:17:37 -07:00
AlanCoding 42ee804464 add help for instance provisioning 2017-09-08 14:36:17 -07:00
Alan Rominger 19ebd0aa68 Merge pull request #382 from AlanCoding/isolated_reaper
reap isolated jobs
2017-09-08 12:41:03 -07:00
AlanCoding 8e1e60c187 simplify isolated job reaping by checking all task ids 2017-09-08 12:30:05 -07:00
AlanCoding 878e7ef49f reap isolated jobs 2017-09-08 10:40:39 -07:00
AlanCoding 41940687f1 Pass existing object references within access methods
This avoids re-loading objects from the database in our
chain of permission checking, wherever possible.
access.py is equiped to handle object references instead
of pk ints, and permissions.py is changed to pass those refs.
2017-09-06 16:34:00 -07:00
Alan Rominger 757a91a7d2 Merge pull request #385 from AlanCoding/smart_validation
fuller validation for host_filter
2017-09-05 10:39:33 -04:00
AlanCoding a36a141141 fuller validation for host_filter 2017-08-31 23:10:09 -04:00
Alan Rominger 12537c2739 Merge pull request #376 from AlanCoding/host_filter_goof
fix bug with host_filter RBAC check
2017-08-31 12:09:00 -04:00
Alan Rominger 3530b643b6 Merge pull request #374 from AlanCoding/v1_adhoc
remove can_run_ad_hoc_commands in v2
2017-08-31 11:33:18 -04:00
AlanCoding 2027047220 fix bug with host_filter RBAC check 2017-08-31 10:42:16 -04:00
AlanCoding ceafa3803a remove can_run_ad_hoc_commands in v2 2017-08-30 23:14:05 -04:00
AlanCoding 853d38b757 remove unused signal_finished method 2017-08-30 13:44:37 -04:00
AlanCoding de58d6764f use exceptions for job cancel and failure 2017-08-30 13:19:53 -04:00
Alan Rominger de3b9fc70d Merge pull request #364 from AlanCoding/null_inv_val
more coherent source_script & inv validation
2017-08-30 10:35:04 -04:00
Alan Rominger 2385c28046 Merge pull request #366 from AlanCoding/logger_unicode
smart_str in log statement to avoid unicode error
2017-08-30 10:33:43 -04:00