External-Mirrors/awx
2
0
Fork 0
mirror of https://github.com/ansible/awx.git synced 2026-09-16 00:40:11 -02:30
Code Issues Packages Projects Releases Wiki Activity
33,840 Commits 63 Branches 102 Tags
33010a2e02b9691e950915ee5486779eab44e73d
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Alan Rominger 14454cc670 Fix playbook errors found by debugging 2024-02-21 14:36:41 +00:00
Alan Rominger 7ab2bca16e Fix missing var name change 2024-02-21 14:36:41 +00:00
Alan Rominger f0f655f2c3 Style consistency for task 'when' 2024-02-21 14:36:41 +00:00
Alan Rominger 1ebff23232 Do not rely on unreliable dir output and use exists query 2024-02-21 13:43:54 +00:00
Alan Rominger 700de14c76 Make the migration middleware faster, second attempt 2024-02-21 13:43:54 +00:00
Alan Rominger cd91fbf59f Label any changes to requirements folder with dependencies label 2024-02-19 15:56:53 +00:00
Alan Rominger 1f7be9258c Remove tower_legacy module_utils that appears unused (#14421) 
* Remove tower_legacy module that appears unused

* Update license details
 2024-02-16 16:02:09 -05:00
Alan Rominger 4d80f886e0 Revert "Drop cython dep" (#14884) 
* Revert "Remove cython lib"

This reverts commit 46f816e7a4.

* Revert "WIP consider droping cython dep"

This reverts commit 54b32c10f0.

* Update Cython comment
 2024-02-15 11:58:17 -05:00
Alan Rominger 362e11aaf2 Respect old downtime setting name if user has already set it 2024-02-15 12:34:24 +00:00
Alan Rominger 46f816e7a4 Remove cython lib 2024-02-13 14:45:28 +00:00
Alan Rominger 54b32c10f0 WIP consider droping cython dep 2024-02-13 14:45:28 +00:00
Alan Rominger 20202054cc Use lowercase password 2024-02-13 14:36:39 +00:00
Alan Rominger e84e2962d0 Support DB configs where PASSWORD is not used 2024-02-13 14:36:39 +00:00
Alan Rominger 4c41f6b018 Ability to use updater script to pin dev requirements (#14644) 
* Add a dev option for updater script to pin CI reqs

* Avoid removing git links for dev requirements

* Add dev to primary options

* Fix up sanitize git switch
 2024-02-12 11:57:59 -05:00
Alan Rominger 8eb4a9a2a0 Update location of logstash build context (#14676) 2024-02-12 15:49:29 +00:00
Alan Rominger a1bbe75aed Adopt new rules from black upgrade (#14809) 2024-01-26 12:54:44 -05:00
Alan Rominger d91da39f81 New setting for pg_notify listener DB settings, add keepalive (#14755) 2024-01-17 13:44:04 -05:00
Alan Rominger 325f5250db Narrow the actor types accepted for RBAC evaluations (#14709) 
* Narrow the scope of RBAC evaluations

* Update tests for RBAC method changes

* Simplify querset for credentials in org

* Fix call pattern to pass in team role obj
 2023-12-14 21:30:47 -05:00
Alan Rominger b14518c1e5 Simplify RBAC get_roles_on_resource method (#14710) 
* Simplify RBAC get_roles_on_resource method

* Fix bug

* Fix query type bug
 2023-12-14 10:42:26 -05:00
Alan Rominger 1294cec92c Fix updater bug due to missing newline at EOF (#14713) 2023-12-08 16:51:17 +00:00
Alan Rominger adb1b12074 Update RBAC docs, remove unused get_permissions (#14492) 
* Update RBAC docs, remove unused get_permissions

* Add back in section for get_roles_on_resource
 2023-11-16 11:29:33 -05:00
Alan Rominger 8fae20c48a Remove unused methods we attach to user model (#14668) 2023-11-16 11:21:21 -05:00
Alan Rominger 1f36e84b45 Correctly handle case where unpartitioned table does not exist (#14648) 2023-11-14 08:38:48 -05:00
Alan Rominger 93c329d9d5 Fix cancel bug - WorkflowManager cancel in transaction (#14608) 
This fixes a bug where jobs within a workflow job were not canceled
  when the workflow job was canceled by the user

The fix is to submit the cancel request as a part of the
  transaction that WorkflowManager commits its work in
  this requires that we send the message without expecting a reply
  so this changes the control-with-reply cancel to just a control function
 2023-10-30 15:30:18 -04:00
Alan Rominger 333ef76cbd Send notifications for dependency failures (#14603) 
* Send notifications for dependency failures

* Delete tests for deleted method

* Remove another test for removed method
 2023-10-30 10:42:37 -04:00
Alan Rominger fc0b58fd04 Fix bug that prevented dispatcher exit with downed DB (#14469) 
* Separate handling of original sitTERM and sigINT
 2023-10-26 14:34:25 -04:00
Alan Rominger b6b167627c Fix Boolean values defaulting to False in collection (#14493) 
* Fix Boolean values defaulting to False in collection

* Remove null values in other cases, fix null handling for WFJT nodes

* Only remove null values if it is a boolean field

* Reset changes to WFJT node field processing

* Use test content from sean-m-sullivan to fix lookups in assert
 2023-10-24 14:29:16 -04:00
Alan Rominger 07f49f5925 AAP-16926 Delete unpartitioned tables in a separate transaction (#14572) 2023-10-13 15:50:51 -04:00
Alan Rominger 19ca480078 Upgrade client library for dsv since tss already landed (#14362) 2023-10-11 16:01:22 -04:00
Alan Rominger 9745058546 Only block commits if black fails for certain paths (#14531) 2023-10-10 10:12:57 -04:00
Alan Rominger e72e9f94b9 Fix collection test flake due to successful canceled command (#14519) 2023-10-04 09:09:29 -04:00
Alan Rominger f5922f76fa DROP unnecessary unpartioned event tables (#14055) 2023-10-03 11:49:23 -04:00
Alan Rominger 1d340c5b4e Add a section for postgres max_connections value (#14482) 2023-09-28 10:28:52 -04:00
Alan Rominger 770cc10a78 Get rid of names_digest hack no longer needed (#14459) 2023-09-26 12:09:30 -04:00
Alan Rominger 159dd62d84 Add null value handling in create_partition (#14480) 2023-09-25 18:28:44 -04:00
Alan Rominger 9ed527eb26 Consolidate image and server setup in several checks (#14477) 2023-09-25 09:02:20 -04:00
Alan Rominger 29ad6e1eaa Fix bug, None was used instead of empty for DB outage (#14463) 2023-09-21 14:30:25 -04:00
Alan Rominger 3e607f8964 AAP-15927 Use ATTACH PARTITION to avoid exclusive table lock for events (#14433) 2023-09-21 14:27:04 -04:00
Alan Rominger 3b8e662916 Remove conditional paths due to conflict with required checks (#14450) 2023-09-14 16:19:42 -04:00
Alan Rominger aa3228eec9 Fix continue-on-error GH actions bug, always run archive step instead 2023-09-14 19:45:07 +00:00
Alan Rominger 7b0598c7d8 Continue workflow steps to save logs from failed tests (#14448) 2023-09-14 18:23:22 +00:00
Alan Rominger 8feeb5f1fa Allow saving github creds in user folder (#14435) 2023-09-12 15:47:12 -04:00
Alan Rominger 09168e5832 Edit docker-compose instructions for correctness (#14418) 2023-09-06 11:55:25 -04:00
Alan Rominger 6df1de4262 Avoid activity stream entries for instance going offline (#14385) 2023-09-06 11:18:52 -04:00
Alan RomingerandMaxwell G e072bb7668 Declare license for unique module that uses BSD-2 
Co-authored-by: Maxwell G <maxwell@gtmx.me>
 2023-09-06 10:43:25 -04:00
Alan Rominger ec579fd637 Fix collection metadata license to match intent 2023-09-06 10:43:25 -04:00
Alan Rominger 20fc7c702a Add check for building docsite (#14406) 2023-09-05 16:07:48 -04:00
Alan Rominger ab3ceaecad Remove extra scheduler state save that does nothing (#14396) 2023-08-31 10:35:07 -04:00
Alan Rominger cdb4f0b7fd Consume job_explanation from runner, fix error reporting error (#13482) 2023-08-30 16:45:50 -04:00
Alan Rominger 951bd1cc87 Re-run the updater script after upstream removal of future (#14265) 2023-08-29 15:36:42 -04:00
Alan Rominger 4fbdc412ad Restrict PR body check to just AWX repo 2023-08-29 09:29:30 -04:00
Alan Rominger db1af57daa Revert "Adding PR check to ensure JIRA links are present" 
This reverts commit 3ae6174050.
 2023-08-29 09:29:30 -04:00
Alan Rominger c448b87c85 AAP-10891 Apply AWX_TASK_ENV when performing credential plugin lookups (#14271) 2023-08-23 13:26:12 -04:00
Alan Rominger 8dc6ceffee Fix programming error in facts retry merge (#14336) 2023-08-11 13:54:18 -04:00
Alan Rominger 2c7184f9d2 Add a retry to update host facts on deadlocks (#14325) 2023-08-11 11:13:56 -04:00
Alan Rominger 284bd8377a Integrate scheduler into dispatcher main loop (#14067) 
Dispatcher refactoring to get pg_notify publish payload
  as separate method

Refactor periodic module under dispatcher entirely
  Use real numbers for schedule reference time
  Run based on due_to_run method

Review comments about naming and code comments
 2023-08-10 14:43:07 -04:00
Alan Rominger 6f9ea1892b AAP-14538 Only process ansible_facts for successful jobs (#14313) 2023-08-04 17:10:14 -04:00
Alan Rominger ab5cc2e69c Simplifications for DependencyManager (#13533) 2023-07-27 15:42:29 -04:00
Alan Rominger 98bfe3f43f Add missing trigger for failed-to-start nodes (#13802) 2023-07-24 12:17:46 -04:00
Alan Rominger ea455df9f4 Only push the production images for main repo (#14261) 2023-07-19 09:51:33 -04:00
Alan Rominger b8c48f7d50 Restore pre-upgrade pg_notify notifcation behavior (#14222) 2023-07-11 16:23:53 -04:00
Alan Rominger 82abd18927 Fix DELETE 500 KeyError due to eventless model events (#14172) 2023-07-05 15:37:52 -04:00
Alan Rominger aed96fb365 Use the proper queryset to filter project update events (#14166) 2023-06-26 21:41:08 -04:00
Alan Rominger fe2da52eec Upgrade Github actions issue labeler to fix 404 errors (#14163) 2023-06-26 17:14:53 -04:00
Alan RomingerandSarabraj Singh 974465e46a Add hashivault option as docker-compose optional container (#14161) 
Co-authored-by: Sarabraj Singh <singh.sarabraj@gmail.com>
 2023-06-26 15:48:58 -04:00
Alan Rominger c736986023 Try to fix CI by adding dropped coreapi lib (#14165) 2023-06-26 15:11:12 -04:00
Alan Rominger 755e55ec70 Remove reference to unmaintained runner image (#14143) 2023-06-23 10:15:11 -04:00
Alan Rominger aa8437fd77 Tooling for running collection tests locally ad hoc (#14160) 2023-06-22 13:32:09 -04:00
Alan Rominger 7a36041bf2 Remove whitespace artifacts from black with f-strings (#14112) 2023-06-12 11:52:22 -04:00
Alan Romingerandjessicamack fbaeb90268 Apply conservative database connection reduction changes (#14066) 
This is expected to free up 4 additional database connections per traditional node
  compare to roughly 12 in total before this change

Out of these 3 are accomplished by using existing connection for recently added services
  then 1 is obtained by closing the connection for the idle callback receiver main process

Signed-off-by: jessicamack <jmack@redhat.com>
Co-authored-by: jessicamack <jmack@redhat.com>
 2023-06-01 14:59:18 -04:00
Alan Rominger 2c320cb16d Manually run subquery for parent event updates (#14044) 
Fixes a long query when processing playbook_on_stats events
 2023-06-01 07:55:56 -04:00
Alan Rominger f58c44590d Remove unused settings and associated code (#13898) 2023-05-18 10:05:59 -04:00
Alan Rominger ef99770383 Add subsystem metrics for the dispatcher (#13989) 
This adds a handful of metrics to /api/v2/metrics/ recorded from the dispatcher main process

Adds logic in the dispatcher period tasks to calculate these for the last collection interval
Reports worker count, task count, scale up events, and availability

Add data to demo grafana dashboard
 2023-05-17 14:29:31 -04:00
Alan Rominger 433c28caa8 Materialize label page after getting 204 code (#14010) 2023-05-16 16:12:18 -04:00
Alan Rominger 0d5c0bcb91 Skip constructed_inventory in a more correct loop (#14004) 2023-05-15 13:48:59 -04:00
Alan Rominger 85e7189ee3 Add error handling to scm_version.py script (#13521) 
raise Exception in the case that return code is non-zero

this approach has shown itself to be the most consistently reliable across multiple ecosystems
 2023-05-10 14:20:56 -04:00
Alan Rominger 06430741ab Fix 400 error from job labels sublist (#13972) 
This was caused by an incorrect parent_key ref from label to job
  also applies to workflow_job labels

This fixes a regression introduced by a recent merge (#13957)
 2023-05-10 11:37:59 -04:00
Alan Rominger ba0e9831d2 Fix bug with parent_key filtering (#13957) 
This was making host sub-list views non-functional
  specifically for constructed and smart inventory
  views would always return 0 results before this fix
 2023-05-05 14:10:55 -04:00
Alan Rominger bf5594e338 Merge pull request #13930 from sean-m-sullivan/collection_role_update 
In collection, allow roles to be added to multiple teams and users
 2023-05-02 12:54:22 -04:00
Alan Rominger f012a69c93 Allow running AWX checks on forks (#13938) 2023-05-02 11:47:29 -04:00
Alan Rominger 77175d2862 Consolidate get_queryset methods (#13906) 
In a prior merge, we added the ability to slap filter_read_permission = False on a view to get a certain functionality where it didn't filter a sublist the view is showing.

This logic already existed in a highly duplicated form among a number of views, so this deletes those methods in favor of the flag.
 2023-04-28 09:10:18 -04:00
Alan Rominger 7acc0067f5 Remove Ansible config override to validate group names (#13837) 2023-04-25 13:37:13 -04:00
Alan Rominger 0a13762f11 Use separate module for pytest settings (#13895) 
* Use separate module for test settings

* Further refine some pre-existing comments in settings

* Add CACHES to setting snapshot exceptions to accommodate changed load order
 2023-04-25 13:31:46 -04:00
Alan Rominger 086722149c Avoid recursive include of DEFAULT_SETTINGS, add sanity test (#13236) 
* Avoid recursive include of DEFAULT_SETTINGS, add sanity test to avoid similar surprises

* Implement review comments for more clear code order and readability

* Clarify comment about order of app name, which is last in order so that it can modify user settings
 2023-04-20 15:15:34 -04:00
Alan Rominger d0acb1c53f Delete cp of local_settings.py file in test running, because path no longer exists (#13894) 
* Change reference to moved local_settings.py file

* Do not appy local_settings to test runner
 2023-04-20 13:19:00 -04:00
Alan Rominger 886ba1ea7f Merge pull request #13860 from AlanCoding/move_test 
Move integration tests to be consistent with the rest
 2023-04-14 10:36:44 -04:00
Alan Rominger 36c9c9cdc4 Move integration tests to be consistent with the rest 2023-04-14 09:51:53 -04:00
Alan Rominger 342e9197b8 Customize application_name for different connections in dispatcher service (#13074) 
* Introduce new method in settings, import in-line w NOQA mark

* Further refine the app_name to use shorter service names like dispatcher

* Clean up listener logic, change some names
 2023-04-13 22:36:36 -04:00
Alan Rominger 1ea6d15ee3 Add run-clear-cache to tower-processes for auto-reload 2023-04-11 17:05:41 -04:00
Alan Rominger 3cd5d59d87 Get rid of 1 perpetually unused connection in our app 2023-04-11 17:04:59 -04:00
Alan Rominger 2db29e5ce2 Merge pull request #13786 from AlanCoding/refresh_refresh_refresh 
Fix docker-clean target, accounting for slashes
 2023-03-30 14:20:04 -04:00
Alan Rominger 7bb0d32be1 Fix docker-clean file, accounting for slashes 2023-03-30 13:46:15 -04:00
Alan Rominger 5080a5530c Merge pull request #13448 from ansible/feature_constructed-inventory 
Allow for using Ansible's `constructed` inventory plugin to dynamically group hosts from AWX inventories
 2023-03-29 09:27:21 -04:00
Alan RomingerandRick Elrod 16ad27099e [constructed-inventory] Save facts on model for original host (#13700) 
* Save facts on model for original host

Redirect to original host for ansible facts

Use current inventory hosts for facts instance_id filter
Thanks for Gabe for identifying this bug

* Fix spelling of queryset

Co-authored-by: Rick Elrod <rick@elrod.me>

* Fix sign error with facts expiry - from review

---------

Co-authored-by: Rick Elrod <rick@elrod.me>
 2023-03-28 11:20:24 -05:00
Alan RomingerandRick Elrod 3f5a4cb6f1 [constructed-inventory] Backlink events to real hosts and summaries to both hosts (#13718) 
* Backlink events to real hosts and summaries to both hosts

* Prevent error when original host is deleted during job run

* No duplicate entries, review suggestion from Rick

* Change word tense in help text, dict style adjustments

From code review

Co-authored-by: Rick Elrod <rick@elrod.me>

* Back out new variable for constructed host id

---------

Co-authored-by: Rick Elrod <rick@elrod.me>
 2023-03-28 11:20:24 -05:00
Alan Rominger b88d9f4731 Force overwrite all vars for constructed inventory (#13731) 2023-03-28 11:20:24 -05:00
Alan Rominger 62b79b1959 Point constructed inventory URL to special view (#13730) 2023-03-28 11:20:24 -05:00
Alan Rominger be5a2bbe61 Fail inventory updates with unmatched limits (#13726) 2023-03-28 11:20:24 -05:00
Alan Rominger aa631a1ba7 [constructed-inventory] Allow filtering based on facts (#13678) 
* initial functional filter-on-facts functionality

* Move facts to its own module to make interface more coherent

* Update test
 2023-03-28 11:20:24 -05:00
Alan Rominger 771b831da8 Fail constructed inventory if ANY source is unparsed 2023-03-28 11:20:24 -05:00