Commit Graph
100 Commits
Author SHA1 Message Date
Ryan Petrello 581756527e fix an i18n-related bug that affects non-English hipchat users
see: https://github.com/ansible/tower/issues/951
2018-06-04 15:02:27 -04:00
Ryan Petrello 6183e5166d fix a failing timezone test 2018-06-01 09:51:42 -04:00
Ryan Petrello 99d2f3ea34 allow Jinja2 in ansible -a when ALLOW_JINJA_IN_EXTRA_VARS is 'always' 2018-05-31 11:49:50 -04:00
Ryan Petrello 9bc871db47 add a test for tower inventory syncs 2018-05-30 15:13:49 -04:00
Ryan Petrello 354b076956 clean up Tower inventory error handling
related: https://github.com/ansible/tower/pull/1697
related: https://github.com/ansible/tower-qa/pull/1746
2018-05-30 13:34:14 -04:00
Ryan Petrello c369d44518 use the _correct_ argument to specify poll vs select 2018-05-29 11:25:08 -04:00
Ryan Petrello 7f7f635f7b upgrade to the latest pexpect
see: https://github.com/pexpect/pexpect/pull/492
see: https://github.com/ansible/tower/issues/1797
2018-05-29 09:52:59 -04:00
Ryan Petrello af7ec17ccd fix a few minor issues that have broken the User Token creation
see: https://github.com/ansible/tower/issues/1928
2018-05-25 17:37:02 -04:00
Ryan Petrello e03c584b80 mark dynamic Credential Type labels and help_text for i18n
see: https://github.com/ansible/tower/issues/1960
related: https://github.com/ansible/ansible-tower/pull/6844
2018-05-25 15:08:11 -04:00
Ryan Petrello a0433773d8 don't allow Accept:application/json on /api/login/
see: https://github.com/ansible/tower/issues/1672
2018-05-25 14:21:22 -04:00
Ryan Petrello 870adc14f9 fix a bug in the instance policy algorithm when both min and % are used
see: https://github.com/ansible/tower/issues/897
2018-05-24 12:28:46 -04:00
Ryan Petrello c9c7a4b8f4 fix a few broken network UI tests 2018-05-24 09:46:35 -04:00
Ryan Petrello 37264d9d21 rename some tests from unit -> functional 2018-05-24 09:27:34 -04:00
Ryan Petrello 3abdf66794 run network ui tests in shippable and Jenkins 2018-05-24 09:07:53 -04:00
Ryan Petrello 63f089c712 allow any authenticated user to access the schedule preview API endpoint
see: https://github.com/ansible/tower/issues/1939
2018-05-23 16:51:58 -04:00
Ryan Petrello d8f86ecba0 add help text for the new custom_virtualenv field
see: https://github.com/ansible/tower/issues/1866
2018-05-23 16:19:59 -04:00
Ryan Petrello 28a42850a2 allow AUTH_LDAP_USER_FLAGS_BY_GROUP to specify an OR'd list for a flag
see: https://github.com/ansible/tower/issues/968
2018-05-23 14:45:46 -04:00
Ryan Petrello f434196bae store denormalized metadata about ActivityStream.actor for accounting
see: https://github.com/ansible/tower/issues/1782
2018-05-23 09:47:26 -04:00
Ryan Petrello d493a4e0d0 revert expect(use_poll=True) due to a bug that causes os.read() hangs
There's a bug in the implementation in pexpect:
pexpect/pexpect#491

Issues that could be related to this:
ansible/awx#1870
ansible/awx#1840

Rolling this back will cause #861 to no longer be "fixed". We'll have to solve it another way, or wait for pexpect to fix the poll bug.
2018-05-21 12:42:20 -04:00
Ryan Petrello 4abac44411 prevent unicode in instance hostnames and instance group names
see: https://github.com/ansible/tower/issues/1721
2018-05-18 16:28:43 -04:00
Ryan Petrello 51f66b8c0a filter /api/v2/users/N/tokens/ to only show tokens for _that_ user
see: https://github.com/ansible/tower/issues/1773
2018-05-17 15:44:35 -04:00
Ryan Petrello b6923bdbeb speed up a handful of really slow stdout tests
before: 59 passed in 95.20 seconds
after: 59 passed in 11.09 seconds
2018-05-17 13:27:18 -04:00
Ryan Petrello 53ef9ed288 never convert ANSI codes to HTML for format /stdout/?format=json
see: https://github.com/ansible/awx/issues/1863
2018-05-16 11:20:55 -04:00
Ryan Petrello 39cb1cb60c fix a nuanced parsing bug in naive UNTIL= parsing 2018-05-16 09:35:04 -04:00
Ryan Petrello db1a669c68 work around a django-polymorphic bug that breaks certain cascades
see: #1794
2018-05-15 16:55:37 -04:00
Ryan Petrello d5fbb2d3b6 remove md5 password hashing in dev 2018-05-15 14:57:47 -04:00
Ryan Petrello 3ab7f06f95 run scm inv syncs at the project root so relative imports work w/ bwrap
see: https://github.com/ansible/tower/issues/1357
2018-05-15 12:00:37 -04:00
Ryan Petrello 05b0c5ec6f censor OAuth tokens from activity stream deletion records
see: https://github.com/ansible/tower/issues/1772
2018-05-15 09:16:37 -04:00
Ryan Petrello 357a735e56 fix a bug that prevented JT admins from editing diff mode
see: https://github.com/ansible/tower/issues/801
2018-05-14 16:01:36 -04:00
Ryan Petrello 5b55e3cb2b fix a bug that prevented JT admins from editing custom virtualenvs
see: https://github.com/ansible/tower/issues/1754
2018-05-14 14:12:22 -04:00
Ryan Petrello bb3b19e174 truncate certain event fields when they are overly long
see: https://github.com/ansible/tower/issues/1775
2018-05-14 14:02:17 -04:00
Ryan Petrello c52eb0f327 provide a naive UNTIL= datestamp for schedules for UI convenience 2018-05-09 15:51:52 -04:00
Ryan Petrello 056933e33e refactor naive UNTIL= coercion 2018-05-09 15:00:48 -04:00
Ryan Petrello 00ae91dace slight cleanup and refactor of Schedule.timezone property 2018-05-08 08:28:51 -04:00
Ryan Petrello 441e5cc9c2 allow naive UNTILs to be specified for schedule rrules 2018-05-07 13:00:01 -07:00
Ryan Petrello fbe2391b86 provide the timezone so that the UI doesn't have to
this will also ensure that UI doesn't use a different front end library
that will yield different results than the underlying Python code
2018-05-07 13:00:01 -07:00
Ryan Petrello 30af0a1b44 don't run scheduled jobs if there isn't a valid license 2018-05-02 11:52:51 -04:00
Ryan Petrello c8e416f0b7 restore the celery hostname 2018-04-27 11:40:58 -04:00
Ryan Petrello 1eb5e98743 Merge branch 'release_3.2.4' into release_3.3.0 2018-04-26 11:10:28 -04:00
Ryan Petrello f0d3713e99 use select.poll() instead of select.select() for file descriptors
see: https://github.com/ansible/tower/issues/861
see: https://github.com/pexpect/pexpect/pull/474
2018-04-25 16:29:55 -04:00
Ryan Petrello 0bc5665e92 remove the legacy fact cleanup system template
see: https://github.com/ansible/tower/issues/1021
2018-04-25 14:20:19 -04:00
Ryan Petrello c98ede2f27 fix a bug in custom virtualenv when Project.organization is None
see: https://github.com/ansible/tower/issues/1490
2018-04-24 16:53:10 -04:00
Ryan Petrello 19d5d71937 unpin botocore now that an upstream dependency issue is resolved
related: https://github.com/ansible/awx/commit/4f585dd09e35c2ab1011e8ea93e6533be8877329
related: https://github.com/boto/botocore/pull/1433
2018-04-23 14:43:09 -04:00
Ryan Petrello f8211b0588 add more edge case handling for yaml unsafe marking 2018-04-19 09:16:22 -04:00
Ryan Petrello 835f2eebc3 make extra var YAML serialization more robust to non-dict extra vars 2018-04-17 15:39:37 -04:00
Ryan Petrello fe47b75aad use a three-prong setting for Jinja extra vars policy 2018-04-17 12:08:07 -04:00
Ryan Petrello 7304301948 don't bother building a safe extra vars namespace; it's a file path now 2018-04-17 10:24:14 -04:00
Ryan Petrello 7074dcd677 don't allow usage of jinja templates in certain ansible CLI flags
see: https://github.com/ansible/tower/issues/1338
2018-04-17 09:20:05 -04:00
Ryan Petrello 88c243c92a mark all unsafe launch-time extra vars as !unsafe
see: https://github.com/ansible/tower/issues/1338
see: https://bugzilla.redhat.com/show_bug.cgi?id=1565865
2018-04-16 16:47:44 -04:00
Ryan Petrello b1028a2e0a fix a bug preventing custom credential templates from including unicode
see: https://github.com/ansible/tower/issues/1266
2018-04-09 17:08:10 -04:00
Ryan Petrello 18c95bf706 add exception handling to deprecated v1 credential support
see: https://github.com/ansible/tower/issues/1268
2018-04-09 14:23:43 -04:00
Ryan Petrello ba66996add missing import for celery failure handler 2018-04-09 09:10:50 -04:00
Ryan Petrello 4c0096a524 implement celery failure logging using CELERY_ANNOTATIONS
see: https://github.com/ansible/awx/issues/1720
see: https://github.com/ansible/tower/issues/1190
2018-04-06 11:23:23 -04:00
Ryan Petrello 5f01d26224 automatically encrypt/decrypt main_oauth2application.client_secret
see: https://github.com/ansible/awx/issues/1416
2018-04-04 15:35:24 -04:00
Ryan Petrello 4b518298a6 remove old crusty test fixtures 2018-04-04 09:32:17 -04:00
Ryan Petrello 0db24a5c97 more gracefully account for undefined stdout
see: https://github.com/ansible/tower/issues/1215
related: https://github.com/ansible/tower/pull/1192#issuecomment-377982131
2018-04-04 08:29:57 -04:00
Ryan Petrello 31a0eab880 add more custom credential type env blacklist items
see: https://github.com/ansible/tower/issues/1224
2018-04-03 15:44:44 -04:00
Ryan Petrello 5fd5c95a1d only record task.args in the callback plugin if DISPLAY_ARGS_TO_STDOUT
see: https://github.com/ansible/awx/issues/1633
2018-04-03 10:52:55 -04:00
Ryan Petrello f8c40cc26f properly support v2_playbook_on_notify in ansible 2.5+
see: https://github.com/ansible/awx/issues/1705
see: https://github.com/ansible/tower/issues/1205
related: https://github.com/ansible/ansible/pull/32633
2018-04-03 08:53:13 -04:00
Ryan Petrello c1cc92afa0 properly filter disabled hosts on smart inventory composition
see: #1053
related: https://github.com/ansible/tower/pull/1155
2018-03-28 17:02:32 -04:00
Ryan Petrello 23267bce38 properly filter disabled hosts on smart inventory composition
see: https://github.com/ansible/tower/issues/1053
2018-03-28 15:16:26 -04:00
Ryan Petrello 21d629531f remove an RRULE parsing bug fix that landed upstream in python-dateutil
related: a2a246a834
2018-03-26 18:02:52 -04:00
Ryan Petrello a2a246a834 update to a newer python-dateutil with more bug fixes we were vendoring
related: dateutil/dateutil#649
2018-03-26 17:12:01 -04:00
Ryan Petrello 35e38760aa properly sanitize module arguments with no_log (like uri:password)
this will _not_ sanitize playbooks that have secrets hard-coded *in* the
playbook - for that, people will need to use Vault or a variable/lookup

see: https://github.com/ansible/tower/issues/1101
see: https://github.com/ansible/awx/issues/1633
2018-03-23 11:15:37 -04:00
Ryan Petrello 61aafe15d6 fix busted shippable builds 2018-03-22 16:56:04 -04:00
Ryan Petrello f59f47435b send job notification templates _after_ all events have been processed
see: https://github.com/ansible/awx/issues/500
2018-03-22 09:30:41 -04:00
Ryan Petrello 6a96e6a268 dynamically set worker autoscale max_concurrency based on system memory 2018-03-21 11:10:48 -04:00
Ryan Petrello 918f372c20 add uwsgitop as a dependency
see: https://github.com/ansible/ansible-tower/issues/7966
2018-03-19 08:53:30 -04:00
Ryan Petrello 4f585dd09e pin botocore to avoid dependency hell re: latest python-dateutil
boto decided to pin python-dateutil on a version _lower than_ what we
need for the TZID= bug fix:
https://github.com/boto/botocore/commit/90d7692702be1a423af15e0f49b58365f2a400f2#diff-b4ef698db8ca845e5845c4618278f29a
2018-03-16 16:08:03 -04:00
Ryan Petrello 44adab0e9e bump python-dateutil to latest
this change provides support for numerous bug fixes, along with
support for parsing TZINFO= from rrule strings

related: https://github.com/ansible/ansible-tower/issues/823
related: https://github.com/dateutil/dateutil/issues/614
2018-03-12 12:20:03 -04:00
Ryan Petrello a61187e132 restrict API filtering on oauth-related fields
related: https://github.com/ansible/awx/issues/1354
2018-03-12 09:16:37 -04:00
Ryan Petrello 397b9071a6 properly categorize OAuth2 endpoints for swagger autogen 2018-03-09 15:07:50 -05:00
Ryan Petrello 8955e6bc1c normalize custom_virtualenv empty values to null
see: https://github.com/ansible/ansible-tower/issues/7923
2018-03-05 17:05:10 -05:00
Ryan Petrello 8887be5952 add validation to InventorySource.inventory to avoid task manager death
see: https://github.com/ansible/awx/issues/1438
2018-03-05 14:40:57 -05:00
Ryan Petrello 13672cc88c fix busted shippable builds 2018-03-05 14:16:42 -05:00
Ryan Petrello b9ab06734d don't inject custom extra_vars for inventory updates
see: https://github.com/ansible/awx/issues/1366
2018-02-27 16:10:23 -05:00
Ryan Petrello d743b77353 replace our rdb tooling w/ the sdb PyPI package 2018-02-26 19:05:50 -05:00
Ryan Petrello 7741de5153 set $HOME via an API call so AWX_TASK_ENV isn't marked as readonly
see: https://github.com/ansible/awx/issues/1315
2018-02-26 16:35:36 -05:00
Ryan Petrello 35f629d42c Revert "changes to license compliance"
This reverts commit 218dfb680e.
2018-02-22 15:02:33 -05:00
Ryan Petrello 7d9e4d6e2f support fact caching for isolated hosts
see: https://github.com/ansible/awx/issues/198
2018-02-20 15:00:47 -05:00
Ryan Petrello ac3ce82eb1 remove dead code
the code that persists `set_stat` data for workflows now lives elsewhere

related: https://github.com/ansible/awx/commit/d57470ce49f80afd6b510667be151b035f7b0e55
2018-02-20 14:14:23 -05:00
Ryan Petrello 56e3d98e62 don't require credentials to relaunch a job
see: https://github.com/ansible/awx/issues/1291
2018-02-19 11:15:55 -05:00
Ryan Petrello 218dfb680e changes to license compliance
now if a license is expired or over the managed node limit, it won't
prevent host creation or Job/JobTemplate launches

see: https://github.com/ansible/ansible-tower/issues/7860
2018-02-14 15:51:19 -05:00
Ryan Petrello 1c62c142f1 we don't use travis for tests; remove .travis.yml 2018-02-14 10:07:17 -05:00
Ryan Petrello 613d48cdbc add support for new "BECOME" prompt in Ansible 2.5+ for adhoc commands
see: https://github.com/ansible/ansible-tower/issues/7850
2018-02-13 14:26:27 -05:00
Ryan Petrello 82e41b40bb enforce strings for secret password inputs on Credentials
see: https://github.com/ansible/ansible-tower/issues/7898
2018-02-12 17:03:32 -05:00
Ryan Petrello 194c2dcf0b improve a bwrap test 2018-02-12 10:14:37 -05:00
Ryan Petrello 2a168faf6a upgrade to the latest pexpect
see: https://github.com/ansible/awx/issues/417
2018-02-12 09:18:14 -05:00
Ryan Petrello 605c5e3276 fix celery pid restart issues 2018-02-09 11:03:00 -05:00
Ryan Petrello 3c43aaef21 normalize dates in the Swagger output to minimize diffs 2018-02-09 10:16:27 -05:00
Ryan Petrello fe02abe630 move swagger doc metadata out of the awx repo 2018-02-09 09:45:23 -05:00
Ryan Petrello 7472026cca remove the new_in_<version> in API doc gen
see: https://github.com/ansible/awx/issues/73
2018-02-08 16:21:22 -05:00
Ryan Petrello 72715df751 fix a bug for "users should be able to change type of unused credential"
see: https://github.com/ansible/ansible-tower/issues/7516
related: https://github.com/ansible/tower/pull/441
2018-02-08 15:44:14 -05:00
Ryan Petrello f2c5859fde properly handle STDOUT_MAX_BYTES_DISPLAY for system jobs
see: https://github.com/ansible/ansible-tower/issues/7890
2018-02-08 11:37:05 -05:00
Ryan Petrello 5b9dc41015 add indention to swagger docs
this will make it easier to spot changes as our APIs change
2018-02-08 10:51:42 -05:00
Ryan Petrello c866d85b8c update zoneinfo endpoint to be a list of dicts 2018-02-08 09:12:26 -05:00
Ryan Petrello 3c799b007e don't allow rrule values that contain both COUNT and UNTIL
see: https://github.com/ansible/ansible-tower/issues/7887
2018-02-08 08:59:52 -05:00
Ryan Petrello 887f16023a improve detection of expensive DTSTART RRULE values 2018-02-08 08:54:30 -05:00
Ryan Petrello 1adb4cefec fix a bad swagger-related import that breaks the build 2018-02-07 08:56:59 -05:00
Ryan Petrello cc3659d375 fix a busted swagger import 2018-02-06 13:43:31 -05:00