Commit Graph

2332 Commits

Author SHA1 Message Date
Ryan Petrello
ef211a4dc8 add a missing Location header on HTTP 201 in a few places 2018-07-06 11:34:48 -04:00
Christian Adams
90d57300da Merge pull request #2357 from rooftopcellist/hookup_ui_expire
Hookup ui expire
2018-07-05 08:45:56 -04:00
Alan Rominger
0b811a53ff Merge pull request #2410 from AlanCoding/filterama
Show filterable: False if not filterable
2018-07-03 17:32:11 -04:00
adamscmRH
ae0793f374 Hookup UI session expiration 2018-07-03 16:53:27 -04:00
Alan Rominger
13c1b87df4 Merge pull request #2191 from AlanCoding/schedule_fixes
Fix bugs creating WFJT schedule with passwords
2018-07-03 16:51:01 -04:00
Alan Rominger
360ad7ad61 Merge branch 'release_3.3.0' into filterama 2018-07-03 15:42:37 -04:00
Ryan Petrello
151187f623 Merge pull request #2408 from ryanpetrello/fix-2323
properly check read permissions in `GET /api/v2/wfjt/N/copy/`
2018-07-03 15:32:20 -04:00
Alan Rominger
1f7d7151ad Merge pull request #2405 from AlanCoding/app_act_str
Add back in application activity stream link
2018-07-03 15:23:18 -04:00
AlanCoding
b97626bf37 show filterable: False if not filterable 2018-07-03 15:21:10 -04:00
Ryan Petrello
d1f5485b96 properly check read permissions in GET /api/v2/wfjt/N/copy/
see: https://github.com/ansible/tower/issues/2323
2018-07-03 15:15:00 -04:00
AlanCoding
2a5853e4fc add back in application activity stream link 2018-07-03 14:30:56 -04:00
Yunfan Zhang
b4890ee331 Handle exception with invalid HTTP content_type.
Signed-off-by: Yunfan Zhang <yz322@duke.edu>
2018-07-03 13:55:18 -04:00
Guoqiang Zhang
5a4451ddd4 Fix serializers of unified_jobs & ad_hoc_commands to avoid special exceptions 2018-07-02 11:53:33 -04:00
Alan Rominger
6f63c7ba38 Merge pull request #2346 from AlanCoding/no_controller_node
No controller node field for project updates
2018-06-29 14:52:34 -04:00
AlanCoding
8ae979908c Enforce unified list field consistency
Discovered via bug: controller_node field present in
project update list but not in detail view

Added tests to assert that "unified" list serializer
produces same fields as the ordinary serializer,
for unified jobs & unified JTs

Added test to check that list serializers do differ
from detail serializer except for allowed differences

Added test to check that list serializers are applied
correctly - only on list views, and that detail views,
likewise, do not use list serializers

Fix the many many bugs discovered by these new
testing mechanisms
2018-06-29 14:03:52 -04:00
Alan Rominger
d5661a0434 Merge pull request #2343 from AlanCoding/credential_hell
Copy JT credential logic to Job summary fields
2018-06-28 19:27:33 -04:00
Ryan Petrello
b8ed78ee9d Never send WWW-Authenticate: Basic... headers for the API 2018-06-28 13:00:23 -04:00
Ryan Petrello
d52fa377d8 remove unnecessary CSRF exemptions 2018-06-28 09:35:01 -04:00
Ryan Petrello
3b0f7de3e6 Properly return HTTP 403 when CSRF fails (not HTTP 500) 2018-06-28 09:33:59 -04:00
Ryan Petrello
504dfd32ee properly enforce CSRF validation
see: https://github.com/ansible/tower/issues/2339
2018-06-27 21:09:26 -04:00
AlanCoding
a15527b54c copy JT credential logic to Job summary fields 2018-06-27 14:39:35 -04:00
Ryan Petrello
7880f83d97 don't send WWW-Authenticate: Basic for AJAX, and properly detect 401 2018-06-26 08:40:21 -04:00
Christian Adams
8bd2217a49 Merge pull request #2278 from rooftopcellist/fix_dot_oauth2_error
Fix dot oauth2 error
2018-06-22 12:54:39 -04:00
adamscmRH
b7f5161835 try-except auth_header 2018-06-21 17:11:34 -04:00
AlanCoding
b2251cb916 remove brittle condition causing schema to fail 2018-06-21 14:39:25 -04:00
Ryan Petrello
813a3be2b8 always specify cloud: True/False for JT/job credential summary 2018-06-21 11:16:35 -04:00
Ryan Petrello
c7125a335a filter jt.summary_fields.credential.credential_type from /api/v1/ 2018-06-21 11:03:23 -04:00
Ryan Petrello
30e2207960 Merge pull request #2266 from AlanCoding/no_cs_v1
Do not show create_schedule link in v1
2018-06-21 10:54:17 -04:00
AlanCoding
94fce61d36 do not show create_schedule link in v1 2018-06-21 10:09:47 -04:00
Ryan Petrello
83ecea2377 don't show summary_fields.credential.credential_type_id on /api/v1/ 2018-06-21 09:19:47 -04:00
adamscmRH
01a1d6ffd0 selectively authenticate with OAuth2 Backend 2018-06-20 23:09:52 -04:00
Ryan Petrello
78f6907c1b don't show inventory_source/update.related.credentials in /api/v1/ 2018-06-20 17:21:08 -04:00
AlanCoding
f753bea24f Test-based fixes to launch config password handling
Fix bug creating WFJT schedule with passwords:
discard survey_passwords field if given in WFJT
prompts processing method.
Fixed by porting prior JT fix to WFJT method of
same name.

Fix bug where API browser will show encrypted form
of variables in the POST submission box after
failed attempt:
copy extra_data so encrypted data values are not
added in still-linked request.data

Fix a bug where submitted extra_data $encrypted$ string
literal was saved because survey_passwords was empty
when there was no diff from prior.

Allow not answering required password questions with a
non-empty default value when saving a launch config.
The literal $encrypted$ string now gets passed into the
prompts / survey validator.
2018-06-20 14:18:38 -04:00
Yunfan Zhang
37d61904bf Merge pull request #2177 from YunfanZhang42/disallow_dict_on_credentials
Disallow posting dictionary as credentials to JT launch API endpoint.
2018-06-20 13:37:21 -04:00
Yunfan Zhang
9fec43c643 Disallow posting dictionary as credentials to JT launch API endpoint. 2018-06-20 13:05:47 -04:00
Bill Nottingham
482f45b860 Switch token/basic auth logging to INFO, to match login/logout logging. 2018-06-19 11:37:19 -04:00
Ryan Petrello
45fb262556 fix a bug in JobTemplate.extra_credentials summary_fields
see: https://github.com/ansible/tower/issues/2184
2018-06-15 12:19:40 -04:00
adamscmRH
462e0be8d3 adds related tokens link to app endpoint 2018-06-14 14:12:18 -04:00
Jared Tabor
1a8b5426f8 UI i18n Audit: Translates strings throughout the UI
Translations for dashboard lists -> tooltips

Changing "Portal Mode" to "My View," in part due to translations.

Adding "Job Template" to strings to be translated from OPTIONS on API

Marking translations for JT that has a project that needs to be re-synced.

Marking translations for survey maker

Marking translations for lookup modal directive

Marking translations for empty, "Go To Notifications To Add Template"

Adds strings service for scheduler, and marking strings for translation

Translations for teams linkout from orgs, as well as cred types

Translations for instance groups

Marks translations for the Network UI

Translates strings on the workflow editor

Translations for workflow results

Translations for host event modal and some missing translations on

the stdout page.
2018-06-13 12:49:22 -04:00
Alan Rominger
ce117285e1 Merge pull request #2079 from AlanCoding/creds_no_op
Allow no-op case when modifying deprecated credentials
2018-06-12 09:08:35 -04:00
Jake McDermott
9137b4acef Merge pull request #2114 from jakemcdermott/job-results/host-counts
reduce the minimum number of http requests required to load job details from 7 to 3
2018-06-11 18:19:14 -04:00
Yunfan Zhang
1bc1a6f63f Disallow HTTP update methods in job_detail API endpoint. 2018-06-11 14:47:43 -04:00
Jake McDermott
92ae09e163 add host_status_counts and playbook_counts to project update details 2018-06-08 22:27:41 -04:00
Yunfan Zhang
1a3ab7d487 Fix exception format in project_update_stdout.
Signed-off-by: Yunfan Zhang <yz322@duke.edu>
2018-06-08 15:42:00 -04:00
Yunfan Zhang
1255cfc2f0 Merge pull request #2104 from YunfanZhang42/release_3.3.0
Fix job id incorrectly cast to string in ActiveJobConflict.
2018-06-08 09:53:06 -04:00
Yunfan Zhang
0de369b42f Fix job id incorrectly cast to string in ActiveJobConflict. 2018-06-08 09:31:38 -04:00
Alan Rominger
bcd9c5dada Merge pull request #2098 from AlanCoding/u_no_copy
Prohibit users without read_role from viewing copy endpoint
2018-06-08 08:54:32 -04:00
AlanCoding
ed762fd4b6 prohibit users without read_role from viewing copy endpoint 2018-06-07 15:14:49 -04:00
AlanCoding
8509a43b95 exclude m2m copies from activity stream 2018-06-07 13:34:58 -04:00
Jake McDermott
b1f36572c6 Merge pull request #2065 from jakemcdermott/2058
add host_status, play, and task counts to job details
2018-06-07 12:59:11 -04:00