External-Mirrors/awx
2
0
Fork 0
mirror of https://github.com/ansible/awx.git synced 2026-09-16 08:50:10 -02:30
Code Issues Packages Projects Releases Wiki Activity
3,412 Commits 65 Branches 102 Tags
932c2768295cdde1b784fa0c814132293b2e863b
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Jared Tabor b7a85f7f3c Job submission 
had to adjust the job submission to correctly pass empty strings for extra vars and for survey questions
 2015-01-07 10:49:58 -05:00
Jared Tabor 9848a37b02 Force user to login before opening web sockets 
Rearranged the series of events so that the socket handshake happens after the user logs in.
 2015-01-06 17:00:22 -05:00
Jared Tabor 9c3b3aab90 Variable parsing 
expanded the variable parsing to disregard an empty string inside of an empty string ("\"\"")
 2015-01-06 12:54:34 -05:00
Jared Tabor 5e2f915236 Socket reconnection logic 
To test the socket reconnection logic, i've increased the number of times the UI will attempt to try and connect to the socket url.
 2015-01-06 11:30:24 -05:00
Jared Tabor 7d63f1dbf0 Socket.js error message 
I've added an error message to be posted to the javascript console anytime the socket service has an error. This should help in debugging issues down the line.
 2015-01-06 10:22:44 -05:00
Jared Tabor 6fccee404a Job Submission 
The job submission should NOT send an empty extra_vars dict if no extra variable are collected as a result of the job submission prompts. I was under the impression that an empty extra vars dict would be disregarded. An empty extra_vars dict will in fact overwrite any extra_vars in the JT with a blank set of extra_vars
 2015-01-05 18:27:35 -05:00
Jared Tabor 5d5213ba4c Socket.js 
removing 'force new connection' line again
 2015-01-05 16:07:36 -05:00
Jared Tabor f6baacfbe2 Socket.js 
adding 'force new connection' line back into socket file
 2015-01-05 11:14:40 -05:00
Jared Tabor a2b5c38436 Typo on survey help 2015-01-05 09:40:30 -05:00
Jared Tabor b0c9845bc3 Survey maker prevent duplicate vars 
Added check in survey maker to prevent saving a question that uses a variable that is already in use.
 2014-12-19 14:28:38 -05:00
Jared Tabor 54465d4b31 Socket.js 
removing the line i added for the security patch per Matt's request
 2014-12-19 14:22:13 -05:00
Jared Tabor c7c25250a7 Dashboard host count graph 
Pie chart tooltip wasn't displaying values with commas properly
 2014-12-19 13:57:22 -05:00
Jared Tabor e41de1684c Job Template form survey check 
The job template form wasn't checking for survey in every scenario
 2014-12-19 12:18:23 -05:00
Jared Tabor 05ff0a14a4 Job submission 
if survey is enabled and not prompting for extra vars then get the extra vars from the job template
 2014-12-19 12:05:09 -05:00
Jared Tabor cd486b6d9a Job detail page 
When the job run was complete the interval was not being turned off that would continue to update the DOM
 2014-12-18 16:29:14 -05:00
Jared Tabor f5100ee110 Cleanup tower modal issue between saves 
cleaned up the management modal between states
 2014-12-18 14:25:41 -05:00
Jared Tabor 50372f9c38 Prompt for credentials 
fixed prompt for credentials so that ssh and ssh key unlock were both accounted for
 2014-12-18 10:52:53 -05:00
Jared Tabor be2f2596f3 Made delete prompts use the same styling 
made the delete prompts more uniform
 2014-12-17 17:49:45 -05:00
Jared Tabor 7d0e6d8f53 Account menu for Tower after portal mode 
the account menu for tower was displaying items for non-admin users after going to portal page and back to tower.
 2014-12-17 17:41:53 -05:00
Jared Tabor 318da8522f Passing vars to API via extra_vars in job launch 
We changed this at one point to have all vars passed on the root level, but for uniformity we have changed it back to using the extra_vars object
 2014-12-17 17:29:43 -05:00
Jared Tabor 6e3cd5bc54 Added "Manual" to inventory source options 
The 'manual' option was not being shown b/c it's value was an empty string.
 2014-12-17 15:29:25 -05:00
Jared Tabor f422d86355 Survey maker edit multiple quesitons 
The survey maker would allow the user to edit multiple questions at the same time. I've removed this functionality.
 2014-12-16 15:06:27 -05:00
Jared Tabor 956dfedb30 Job detail job events 
The job events modal was not being loaded because the data call to the API was not specifying which page of data to request.
 2014-12-16 13:49:40 -05:00
Jared Tabor feaee64706 Made SCM update button disabled on edit projects 
On the edits project page I disabled the button if the SCM type is manual.
 2014-12-16 01:23:12 -05:00
Jared Tabor 283e4a2a96 Custom inventory scripts required on source modal 
custom inventory scripts needs to be required when on the source modal screen
 2014-12-15 16:40:07 -05:00
Jared Tabor b12d5c90fd Inventory add/edit group->filter custom inv by org 
On the inventory page, if you're adding/editing a group with source is custom, the lookup for an inventory script should be filtered by the organization that is associated with that inventory
 2014-12-15 15:16:24 -05:00
Jared Tabor d410e1aa2c Survey maker 
changed the way that question data is gathered from the question form. Instead of looping through I explicitly set the varaibles needed for the particular question
 2014-12-15 13:25:03 -05:00
Jared Tabor e5ba0ce8bc Survey maker/taker issue with int/floats = 0 
fixed a defect with the survey maker/taker where floats/ints equal to zero weren't being displayed the entire way through
 2014-12-15 13:24:51 -05:00
Jared Tabor 651dd1239a Survey maker variable name checking 
Generalized the directive for the variable name of survey maker to check for illegal characters for a javascript object
 2014-12-15 11:27:58 -05:00
Jared Tabor 312c76788d Copy JT 
Cleared the value of the copy JT form of any stale text
 2014-12-15 10:14:51 -05:00
Jared Tabor c0f4f7185b Projects/add 
With fixes to the manual scm type, if the local path returns no playbooks then an error message should be shown.
 2014-12-12 11:46:07 -05:00
Jared Tabor 696e356fd1 Changed labels for survey maker min/max 
For text and textarea questions, i changed the labels from 'Minimum' and 'Maximum' to 'Minimum Length' and 'Maximum Length'
 2014-12-12 10:23:04 -05:00
Jared Tabor c2c47328df Survey taker float required error field 
adding the div for the float required error field
 2014-12-11 16:01:26 -05:00
Jared Tabor 7b9a6a4bb8 float's weren't required for survey taker 
accidentally goofed up the expression for ng-required for floats on survey maker.
 2014-12-11 15:43:50 -05:00
Jared Tabor eb51600790 Hiding 'relaunch' icon for system jobs 
hiding the relaunch icon for queued jobs, running jobs, and the dashboard view of jobs
 2014-12-11 14:56:10 -05:00
Jared Tabor f41a6f22bf Hide 'relaunch' icon for system jobs 
system jobs don't have a relaunch resource, therefore we don't want the user thinking that they can relaunch these jobs.
 2014-12-11 14:48:44 -05:00
Jared Tabor 1c1aa1f807 Add custom inventory script to activity streams 
added custom inventory script filtering on the activity stream widget
 2014-12-11 13:35:10 -05:00
Jared Tabor acf7e83843 delete Job Template 
added the div for styling of the delete job template prompt
 2014-12-11 12:04:12 -05:00
Jared Tabor 2688f2c3cc Survey cancel button 
Need to clean up lingering question object if cancel is pressed on the survey maker modal
 2014-12-11 11:44:19 -05:00
Jared Tabor 7510714386 ToJSON fix 
Expanded the list of things the ToJSON method can accept
 2014-12-11 11:24:08 -05:00
Jared Tabor b70464dfeb Job template form add mode, can_edit = true 
had to include can_edit = true for creating a job template so that button would be enabled when form is valid
 2014-12-10 16:22:09 -05:00
Jared Tabor e668280d67 Permissions type text change 
On the permissions page for "Job Template" type, the explanation text at the bottom needed to be updated from the 'deploy' verbage to the 'job template' verbage
 2014-12-10 16:09:53 -05:00
Jared Tabor 646bcd407f Job Detail events scrolling defect fix 
On the events view of the job detail page, when the list of hosts if very long, and an api call is made to get more host events, the host edit modal was using the hostname instead of the host id number to make a call to the job events endpoint
 2014-12-10 15:18:16 -05:00
Jared Tabor ec132ae151 Survey maker/taker html tag injection 
Fixed a defect in which the user could inject html tags into the survey maker, which could in turn show up in survey taker.
 2014-12-10 14:05:29 -05:00
Jared Tabor 1268fb6191 Permissions form-type label 
Changed the label for 'Deploy' from 'Deployment' to 'Job Template'
 2014-12-10 12:07:23 -05:00
Jared Tabor 1641122737 Disable survey if 'can_edit' is false 
The user should not be able to edit a survey if they do not have permission to edit the job template. I've added a check if the mode is 'edit' to see if the can_edit flag is false.
 2014-12-10 11:53:05 -05:00
Jared Tabor f7706c3808 Job Template form 'can_edit' 
the 'Save' button should be disabled if the user does not have sufficient permissions to edit the job template
 2014-12-10 10:37:09 -05:00
Jared Tabor f121228d1a Project playbooks save issue 
Fixed defect with project directory not saving for a manual project. Checked for creating/editing a project
 2014-12-10 09:22:19 -05:00
Jared Tabor b5e521a759 Survey maker 
There was a discrepency between save states in the survey maker when creating a new job template. I had to make some changes to how we 'save' survey's when creating job templates. Now survey info is stored in a seperate object and then stored in the scope when the user clicks save. It used to all be stored in teh scope object.
 2014-12-09 16:26:04 -05:00
Jared Tabor 5d6137c8a3 Add new inventory--empty source vars 
The source variable parsing was out of date, and wasn't using the updated parser that I fixed to accept empty variables.
 2014-12-08 16:41:23 -05:00
Jared Tabor e10167ee5a Job Detail -- Events Summary 
the edit icon for the host events was not receiving the correct host id during the processing of job_event data from the job_event endpoint
 2014-12-08 16:16:39 -05:00
Jared Tabor 5daeed14c7 Inventory source tab fix for vmware inventory 
Fixed an error with the vmware sourve variables not properly being instatiated once data is returned from the API
 2014-12-08 14:17:28 -05:00
Jared Tabor 9f6230f7cc Portal job templates default sort by 
Added 'noLink' option to the list view for the portal job templates, so that the list has a default sort-by option but does not contain links to other pages.
 2014-12-08 13:34:50 -05:00
Jared Tabor 6d45dbbeb4 Default sort by w/ no link 
set key and noLink to true, which will force the list to have a default sort-by, but will not force the list to contain any links
 2014-12-08 13:33:35 -05:00
Jared Tabor be63b3e0b3 adding 'noLink' property for list generators 
adding noLink option which will override any other options to make a list column an href. This is useful when using the 'key' attribute, which sorts a list and includes links on the items. Now there is a way to override this feature. This is for portal mode and used in custom inv scripts as well.
 2014-12-08 13:29:57 -05:00
Jared Tabor 8e28c73623 made organization required on custom inv script 
the organization field of the custom inv script modal needed to have the astericks to indicate that it is required.
 2014-12-08 12:52:07 -05:00
Jared Tabor 9e8ec0ebd0 Host events variable parsing to prevent tag inject 
The host events modal needs to have escape characters for tag elements in case a user tries to inject html code into the arguements of the host events.
 2014-12-08 12:28:38 -05:00
Jared Tabor fd86b940e2 Prevent html injection in host events 
replaced '<' and '>' characters with their escape characters to prevent html from being rendered onto the view.
 2014-12-08 11:11:50 -05:00
Jared Tabor 1ffca45c4a Remove open modals when logging in 
If the session times out, and the user attempts to open a modal dialog, then it must be closed due to the fact that bootstrap modals do not work with more than one modal open. The login modal is a bootstrap modal so all other modals need to be closed when it is shown.
 2014-12-05 14:31:45 -05:00
Jared Tabor 9c80dba4a2 Survey maker type change fix 
Made all custom fields set to pristine state when the user changes the question type
 2014-12-05 12:21:09 -05:00
Jared Tabor 4a0afd97b0 Added org column to custom inv scripts list 
I added the organization column to the custom inventory scripts list on the scripts modal
 2014-12-05 11:32:28 -05:00
Jared Tabor 5eb4b59745 Projects form -> edit / SCM fix 
The manual scm option was not showing up when editing an existing project
 2014-12-05 11:06:34 -05:00
Jared Tabor 224e136269 Portal mode column styling 
Added text wrap and fixed layout style for portal mode widgets for long names
 2014-12-05 11:01:56 -05:00
Jared Tabor b4be8f7d49 Project SCM type drop down fix 
The SCM type for the projects page was broken when we sorted the drop down options by value. There was no value for 'manual' projects. I had to insert the word 'manual' where it was expecting a blank sting and then remove the word manual before saving the job template to the API
 2014-12-04 15:56:35 -05:00
Jared Tabor c05d746d73 Fixed empty Extra Variable JSON parsing issue 
if the user saved a job template with empty extra variables and the Parse as option as JSON, then the UI crapped out. I added a check to make sure the default string is '{}' if the user submits an empty field.
 2014-12-04 12:01:05 -05:00
Jared Tabor d9e69fc2c3 Fixed JT form Reset button 
Had to make a small repair to Job Template form reset that was caused when i refactored the code to fill the form
 2014-12-04 10:49:50 -05:00
Jared Tabor ce879f58d8 Added Organization lookup to custom inv script 
The custom inventory script form needed to have an organization associated with it, so I added a lookup to the form and made sure this was incorporated with the Reset functionality
 2014-12-04 10:29:13 -05:00
Jared Tabor f893e4b00b Fixed small issue with JT form vars 
A '$' got deleted somewhere along the line
 2014-12-03 16:34:23 -05:00
Jared Tabor c095ebcbfb Tooltip fix for vmware vars 
on the source panel for vmware extra vars, had to change the wording of the tooltip
 2014-12-03 15:40:17 -05:00
Jared Tabor 9a90277e5e Environment Variables for VMWare inv source 
added the yaml/json parser for VMWare inventory sources
 2014-12-03 15:04:17 -05:00
Jared Tabor 8a2a829bac Fixed reset on custom inv form 
Instead of clearing the form we reset it to the values in the API
 2014-12-03 11:11:04 -05:00
Jared Tabor 696475591a Cleanup Jobs prompt for days >=0 
I've made the prompt_for_days modal require an integer, as well as a non-negative integer (allows 0), and fixed ngMin to new awMin
 2014-12-02 15:46:32 -05:00
Jared Tabor f99a73fb85 text/textarea min/max length 
added fields on survey maker for text/textarea min/max length. on survey taker added the error handling for these.
 2014-12-02 14:01:34 -05:00
Jared Tabor e9e2c1f6ab awSurveyVariableName directive 
created a new directive to check the variable name field for spaces. this could be expanded for future use if we want to check against other constraints. checked with matt though and he said space checking shoudl suffice
 2014-12-02 12:45:31 -05:00
Jared Tabor c96b317202 Launch job from job template form 
added a check that there is a valid survey if survey_enabled === true on the JT form
 2014-12-02 10:06:57 -05:00
Jared Tabor e14630b155 renamed ngmin/ngmax 
renamed to awmin/awmax to match custom directive format. the prefix 'ng' is meant to imply an 'angular' specific directive
 2014-12-01 22:52:55 -05:00
Jared Tabor 98fa7eae40 Float directive 
I changed the float directive last week and now i'm reverting it back. The change i made didn't account for neagative numbers so i'm reverting back
 2014-12-01 22:10:34 -05:00
Jared Tabor a7066443f0 Fixed wording for custom inventory scripts 
Fixed the label on the source panel and on the lookup modal
 2014-12-01 20:38:59 -05:00
Jared Tabor f3037a3b06 Improved ngmin/ngmax 
the ngmin/ngmax directives were failing out if the user never set the ngmin/ngmax (which could happen). added a check to for empty ngmin's/ngmax's
 2014-12-01 16:04:22 -05:00
Jared Tabor a319def4b4 ngMin/ngMax directives fix for surveys 
the ngMin and ngMax directives needed to be re-written to work properly with other directives. They weren't playing nice with other directives' values
 2014-12-01 12:39:39 -05:00
Jared Tabor 47ab0fe06e Inventory Scripts 
Changed "Inventory Script" to "Inventory Scripts" on account menu
 2014-12-01 09:34:53 -05:00
Jared Tabor 15f710331b Extra var parsing 
added a check for an empty string
 2014-11-30 22:29:33 -05:00
Jared Tabor 0c10581ecd Clean up jobs 
Made the prompt for days field required when submitting a cleanup job.
 2014-11-30 21:34:26 -05:00
Jared Tabor a71e787eab Cleanup jobs redirect to jobs page 
when the cleanup jobs run they need to redirect to the jobs page
 2014-11-26 16:06:43 -05:00
Jared Tabor 18cb53cd26 Custom inventory : Edit 
fixed issue with list of custom inventories not updating correctly when a user saves an inv script they were editing
 2014-11-26 15:49:50 -05:00
Jared Tabor fd443295dd Portal credential modal needed 
added the credential div needed to populate the lookup modal for a cred on the portal mode page
 2014-11-26 15:22:15 -05:00
Jared Tabor cfbec378c3 Survey Maker 
on typeChange of survey question, clear out the values of any downstream components
 2014-11-26 14:26:07 -05:00
Jared Tabor 71d0f3af80 JS Hint errors 
fixed a jshint error from cchurch's change
 2014-11-26 14:25:42 -05:00
Jared Tabor 86c717bca3 Job submission 
changed the 'credential' to 'credential_id' on the POST to the job launch endpoint, per request from Matt
 2014-11-26 13:19:13 -05:00
Jared Tabor 6f1f065414 Custom Inventory Scripts 
Changed the title of the modal to be a plural noun instead of singular ('Script')
 2014-11-26 09:45:02 -05:00
Jared Tabor f36885b255 forms/Sources.js 
fixed a couple small errors from church's commit for ec2 tags
 2014-11-26 09:37:30 -05:00
Jared Tabor b94e0711c5 Host events 
added check in host event call to make sure an empty data set is not returend from the API
 2014-11-25 15:11:49 -05:00
Jared Tabor 045592e1eb Launch configuration/survey taker 
Fixed issue with optional text/textarea/mc questions being required
 2014-11-25 08:33:55 -05:00
Jared Tabor c4bdf0d936 Job submission 
Fixed some new errors that emerged as a result of adding the prompt for credentials back in and fixing the html generation of code mirror editor for job variables.
 2014-11-24 15:54:35 -05:00
Jared Tabor 300fb677fa Portal mode pagination 
fixed the pagination on the job templates portal widget. To fix this i had to include an '&' in the pagination url creation in paginationhelpers.js. not sure if this could have effect on anything else that uses pagination.
 2014-11-24 13:31:04 -05:00
Jared Tabor 226c31bc35 Source.js 
Changed the tooltip for environment variables for custom inventory script
 2014-11-21 14:01:30 -05:00
Jared Tabor ee3c838d74 Sources 
Added some changes to fields in the source form.
 2014-11-21 13:46:20 -05:00
Jared Tabor 0ffb979e8e Storable inventory script 
Added the list and form for adding/editing/deleting custom inventory scripts.
 2014-11-19 17:00:52 -05:00
Jared Tabor 3d98fe02b6 Cleanup jobs modal 
changed the title and fixed an issue with the launch url and schedule url getting reused improperly
 2014-11-19 13:42:00 -05:00
Jared Tabor e499dda709 widgets/Stream.js 
added check for system_job_templates for when processing activity stream rows
 2014-11-19 13:05:41 -05:00