Commit Graph
100 Commits
Author SHA1 Message Date
Alan Rominger 5a7119759a Merge pull request #2672 from AlanCoding/popin_locking
Lock IG for updating list
2018-07-25 15:48:41 -04:00
AlanCoding 39cb9f2652 lock IG for updating list 2018-07-25 11:08:40 -04:00
Alan Rominger f0252f67dc Merge pull request #2625 from AlanCoding/just_role
Write special cases for object_association field
2018-07-24 07:46:22 -04:00
Alan Rominger 4c023d21af Merge pull request #2639 from AlanCoding/cool_as_isolated
Disallow adding or removing instance from iso-IG
2018-07-23 15:57:23 -04:00
AlanCoding 6d305c60d5 Disallow adding or removing instance from iso-IG 2018-07-23 15:39:30 -04:00
Alan Rominger c878c027f5 Merge pull request #2631 from AlanCoding/host_dne
Handle does-not-exist errors in JobHostSummary unicode method
2018-07-23 10:37:37 -04:00
AlanCoding fa3a334424 Handle does not exist errors in JobHostSummary unicode 2018-07-23 10:17:47 -04:00
AlanCoding 5de321ae7a write special cases for object_association field 2018-07-20 12:40:12 -04:00
Alan Rominger eb22e09e4d Merge pull request #2568 from AlanCoding/fussy_logger
Add log statement if canceling takes way too long
2018-07-19 10:30:45 -04:00
Alan Rominger 5c7c441b47 Merge pull request #2555 from AlanCoding/app_name_unique
Make applications org-name-unique
2018-07-17 16:49:57 -04:00
AlanCoding 7221c9dae1 add log statement if canceling takes way too long 2018-07-17 12:06:20 -04:00
Alan Rominger 27bf12feb2 Merge pull request #2563 from AlanCoding/old_timer_types
Strict type enforcement of deprecated launch fields
2018-07-17 11:53:17 -04:00
AlanCoding a38d6552e8 strict type enforcement of deprecated launch fields 2018-07-17 08:41:40 -04:00
AlanCoding 885ea2c5e1 make applications name-unique 2018-07-16 15:54:00 -04:00
Alan Rominger 9208ef6664 Merge pull request #2540 from AlanCoding/towerkit_protector
Raise 400 instead of ignoring if fields mismatch v1/v2
2018-07-16 13:29:12 -04:00
Alan Rominger 9db6202210 Merge pull request #2538 from AlanCoding/team_queryset
Remove custom get_queryset that ignored special case
2018-07-16 11:14:31 -04:00
Alan Rominger 53b4a4e2fc Merge pull request #2531 from AlanCoding/everything_text_type
Fix unicode bug in launch error message
2018-07-16 10:49:44 -04:00
AlanCoding fd468ac766 raise 400 instead of ignoring if fields mismatch v1/v2 2018-07-16 09:36:43 -04:00
AlanCoding b5b2bf15df remove custom get_queryset that ignored special case 2018-07-14 21:09:57 -04:00
AlanCoding e897cbd237 fix unicode bug in launch error message 2018-07-13 15:50:50 -04:00
Alan Rominger 9a44f6d13d Merge pull request #2524 from AlanCoding/schedule_log
Add missing job lifecycle log for schedule spawns
2018-07-13 14:18:15 -04:00
AlanCoding a5803255ac add missing job lifecycle log for schedule spawns 2018-07-13 11:13:47 -04:00
Alan Rominger 2ceae5c88a Merge pull request #2496 from AlanCoding/proj_create
Restore project_admin as role for project creation
2018-07-11 16:11:09 -04:00
AlanCoding 46c8920020 restore project_admin as role for project creation 2018-07-11 15:36:48 -04:00
Alan Rominger f268857129 Merge pull request #2466 from AlanCoding/prompts_but_not_prompts
Fix regression of JT callback relaunch
2018-07-11 13:58:39 -04:00
AlanCoding 6697d0c205 fix bug where empty extra vars gave relaunch 500 2018-07-11 13:09:44 -04:00
Alan Rominger 00cc002b8e Merge pull request #2467 from AlanCoding/ig_errors
Fix server errors unattaching instance from group
2018-07-10 16:20:21 -04:00
Alan Rominger a7561ce527 Merge pull request #2478 from AlanCoding/std_env
Move static inventory update options to constants
2018-07-10 16:01:31 -04:00
AlanCoding a634b6b9e7 move static inventory update options to constants 2018-07-10 14:45:55 -04:00
Alan Rominger 7b860e4eeb Merge pull request #2445 from AlanCoding/true_admin
Fix bug with custom script user_capabilities
2018-07-10 10:25:17 -04:00
AlanCoding 73f3837f62 fix server errors unattaching instance from group 2018-07-10 09:38:56 -04:00
AlanCoding ec643d6406 fix regression of callback relaunch 2018-07-10 08:45:23 -04:00
Alan Rominger c78e274373 Merge pull request #2459 from AlanCoding/old_cred_msg
Change key to match old error message
2018-07-09 15:57:11 -04:00
AlanCoding e36458a6c0 change key to match old error message 2018-07-09 15:36:13 -04:00
Alan Rominger a90329f21b Merge pull request #2385 from AlanCoding/team_org_object_roles
Allow adding teams to org object roles
2018-07-09 15:34:45 -04:00
AlanCoding e044b996e5 allow adding teams to org object roles 2018-07-09 14:13:57 -04:00
Alan Rominger 2dd3014374 Merge pull request #2441 from AlanCoding/error_message
Fix regression: include error message from remote server
2018-07-09 13:51:06 -04:00
AlanCoding 7860cda9dc fix bug with custom script user_capabilities 2018-07-09 10:15:17 -04:00
AlanCoding 34e2d9b47c fix regression: include error message from remote server 2018-07-09 09:04:14 -04:00
Alan Rominger 0b811a53ff Merge pull request #2410 from AlanCoding/filterama
Show filterable: False if not filterable
2018-07-03 17:32:11 -04:00
Alan Rominger 13c1b87df4 Merge pull request #2191 from AlanCoding/schedule_fixes
Fix bugs creating WFJT schedule with passwords
2018-07-03 16:51:01 -04:00
Alan Rominger 360ad7ad61 Merge branch 'release_3.3.0' into filterama 2018-07-03 15:42:37 -04:00
Alan Rominger 1f7d7151ad Merge pull request #2405 from AlanCoding/app_act_str
Add back in application activity stream link
2018-07-03 15:23:18 -04:00
AlanCoding b97626bf37 show filterable: False if not filterable 2018-07-03 15:21:10 -04:00
AlanCoding 2a5853e4fc add back in application activity stream link 2018-07-03 14:30:56 -04:00
Alan Rominger 6f63c7ba38 Merge pull request #2346 from AlanCoding/no_controller_node
No controller node field for project updates
2018-06-29 14:52:34 -04:00
AlanCoding 8ae979908c Enforce unified list field consistency
Discovered via bug: controller_node field present in
project update list but not in detail view

Added tests to assert that "unified" list serializer
produces same fields as the ordinary serializer,
for unified jobs & unified JTs

Added test to check that list serializers do differ
from detail serializer except for allowed differences

Added test to check that list serializers are applied
correctly - only on list views, and that detail views,
likewise, do not use list serializers

Fix the many many bugs discovered by these new
testing mechanisms
2018-06-29 14:03:52 -04:00
Alan Rominger d5661a0434 Merge pull request #2343 from AlanCoding/credential_hell
Copy JT credential logic to Job summary fields
2018-06-28 19:27:33 -04:00
AlanCoding a15527b54c copy JT credential logic to Job summary fields 2018-06-27 14:39:35 -04:00
Alan Rominger bed4d240af Merge pull request #2274 from AlanCoding/absolute_nonsense
Remove brittle condition causing schema to fail
2018-06-21 15:44:48 -04:00
AlanCoding b2251cb916 remove brittle condition causing schema to fail 2018-06-21 14:39:25 -04:00
AlanCoding 94fce61d36 do not show create_schedule link in v1 2018-06-21 10:09:47 -04:00
AlanCoding f753bea24f Test-based fixes to launch config password handling
Fix bug creating WFJT schedule with passwords:
discard survey_passwords field if given in WFJT
prompts processing method.
Fixed by porting prior JT fix to WFJT method of
same name.

Fix bug where API browser will show encrypted form
of variables in the POST submission box after
failed attempt:
copy extra_data so encrypted data values are not
added in still-linked request.data

Fix a bug where submitted extra_data $encrypted$ string
literal was saved because survey_passwords was empty
when there was no diff from prior.

Allow not answering required password questions with a
non-empty default value when saving a launch config.
The literal $encrypted$ string now gets passed into the
prompts / survey validator.
2018-06-20 14:18:38 -04:00
Alan Rominger 8dc2068d18 Merge pull request #2238 from AlanCoding/hold_auth_app
Delay auth app migrations until 3.3
2018-06-20 13:27:44 -04:00
Alan Rominger d1bc9758db Merge pull request #2060 from AlanCoding/one_less_counter
Get rid of duplicate counter variable
2018-06-20 09:46:03 -04:00
AlanCoding ecf24b6eef delay auth app migrations until 3.3 2018-06-20 07:57:40 -04:00
AlanCoding 16696a6fea get rid of duplicate counter variable 2018-06-15 09:29:13 -04:00
Alan Rominger ad354238e9 Merge pull request #2165 from AlanCoding/bwrap_where_art_thou
log details for unhandled bwrap case
2018-06-14 15:18:09 -04:00
AlanCoding adee02ab51 log details for unhandled bwrap case 2018-06-14 14:01:59 -04:00
Alan Rominger ce117285e1 Merge pull request #2079 from AlanCoding/creds_no_op
Allow no-op case when modifying deprecated credentials
2018-06-12 09:08:35 -04:00
Alan Rominger 3251ed2f6c Merge pull request #1980 from AlanCoding/settings_exc_info
Handle broken transactions in DB settings getattr
2018-06-12 07:49:05 -04:00
Alan Rominger a8c31a51e9 Merge pull request #2004 from AlanCoding/checkin_access
Allow managing credentials with external user management
2018-06-12 07:47:16 -04:00
Alan Rominger 951142d510 Merge pull request #1950 from AlanCoding/more_roles
Cover testing of new 3.3 org roles for user security fix
2018-06-12 07:45:36 -04:00
Alan Rominger bcd9c5dada Merge pull request #2098 from AlanCoding/u_no_copy
Prohibit users without read_role from viewing copy endpoint
2018-06-08 08:54:32 -04:00
Alan Rominger df1fe19b21 Merge pull request #2089 from AlanCoding/friends_workflow_job
Prohibit relaunching workflow jobs from other users
2018-06-07 20:07:58 -04:00
AlanCoding ed762fd4b6 prohibit users without read_role from viewing copy endpoint 2018-06-07 15:14:49 -04:00
Alan Rominger d969e37f94 Merge pull request #2095 from AlanCoding/memories_of_labels
Exclude m2m copies from activity stream
2018-06-07 15:09:27 -04:00
AlanCoding 8509a43b95 exclude m2m copies from activity stream 2018-06-07 13:34:58 -04:00
AlanCoding b0b7f7a295 prohibit relaunching workflow jobs from other users 2018-06-07 13:01:15 -04:00
AlanCoding dde706b61f allow no-op case when modifying deprecated credentials 2018-06-07 07:16:07 -04:00
Alan Rominger 4f85de5fcf Merge pull request #2056 from AlanCoding/alan33chachachachanges
Update CHANGELOG.md for many 3.3 items
2018-06-06 10:57:55 -04:00
AlanCoding a9391584d7 Update CHANGELOG.md for 3.3 items
Added API items in headline feature list
Added items found by scrubbing the merged PR queue

Add 3.3 section header
move the 3.3 section to the top of file,
before the existing 3.2 section
2018-06-06 10:37:49 -04:00
Alan Rominger 88051cc9fc Merge pull request #2045 from AlanCoding/can_see_all_teams
Show org-admins all teams if ALL USERS setting enabled
2018-06-05 08:39:59 -04:00
AlanCoding 74c6c350a1 show org-admins all teams if ALL USERS setting enabled 2018-06-05 07:55:13 -04:00
Alan Rominger d250b89f47 Merge pull request #2041 from AlanCoding/lazy_passwords
No launch config errors with replacable ASK credential
2018-06-05 07:49:43 -04:00
AlanCoding 648ec3141b no launch config errors with replacable ASK credential 2018-06-04 11:19:22 -04:00
Alan Rominger f394c02afd Merge pull request #2013 from AlanCoding/big_trouble_in_0013
Fix tracebacks when running migrations
2018-06-04 09:51:44 -04:00
AlanCoding 239c60a2bd fix tracebacks when running migrations 2018-06-04 07:35:35 -04:00
Alan Rominger a4efd0a5d2 Merge pull request #2005 from AlanCoding/dep_oauth
Make our oauth model creation a dependency of other app
2018-06-01 09:35:07 -04:00
Alan Rominger b3b38777c1 Merge pull request #1994 from AlanCoding/network_client
Remove network_ui Client model, replace with simple uuid
2018-05-31 15:23:00 -04:00
Alan Rominger dd944319f1 Merge pull request #1989 from AlanCoding/delete_networks
Delete network canvas objects in delete inventory task
2018-05-31 13:57:13 -04:00
AlanCoding b7a5c10ce4 make our oauth model creation a dependency of other app 2018-05-31 10:19:43 -04:00
AlanCoding f692f0c70a test creating credential for self & org_member 2018-05-31 08:58:38 -04:00
AlanCoding 253606c8bf allow managing credentials with external user management 2018-05-31 08:40:32 -04:00
Alan Rominger 302505905e Merge pull request #1992 from AlanCoding/copy_v2
Make copy endpoints specific to v2
2018-05-30 15:51:44 -04:00
Alan Rominger 7aa1c64fac Merge pull request #1996 from AlanCoding/null_handler_again
Interpret null protocol as logging.NullHandler
2018-05-30 15:49:15 -04:00
AlanCoding 015b19d8c3 interpret null protocol as logging.NullHandler 2018-05-30 15:21:51 -04:00
AlanCoding c690da4058 make copy endpoints specific to v2 2018-05-30 14:01:58 -04:00
AlanCoding e889c976eb Remove network_ui Client model 2018-05-30 13:56:19 -04:00
AlanCoding 124fcd6f62 delete network canvas objects in delete inventory task 2018-05-30 12:03:20 -04:00
AlanCoding 4e6fd59180 Handle broken transactions in DB settings getattr
This expands the role of the log database error context manager
and will actually make itself an exception to the standard
ORM behavior of raising an error when any queries are executed
inside of a broken transaction.

In this particular case it is less risky to continue on
with a database query and push the data to memcache than
it would be to use default settings values in violation of
user's intent. (hopefully)
2018-05-30 09:00:03 -04:00
Alan Rominger 232ad2a06c Merge pull request #1912 from AlanCoding/other_user_relaunch
Disallow launching jobs with other user's prompts
2018-05-29 11:51:13 -04:00
Alan Rominger 03d975e18d Merge pull request #1959 from AlanCoding/cpf8
flake8 errors in access.py due to an upgrade
2018-05-25 12:09:37 -04:00
AlanCoding e64e25fcc1 flake8 errors in access.py due to an upgrade 2018-05-25 11:28:38 -04:00
Alan Rominger d35fb691b1 Merge pull request #1952 from AlanCoding/new_test_artifact
Ignore new test artifact being produced
2018-05-25 09:54:05 -04:00
AlanCoding 1790b1703f ignore new test artifact being produced 2018-05-24 15:48:13 -04:00
AlanCoding e04a07f56c cover testing of new 3.3 org roles for user security fix 2018-05-24 13:56:38 -04:00
Alan Rominger 9dc4e1944c Merge pull request #1917 from AlanCoding/no_more
Do not put deep copy items in activity stream
2018-05-24 08:07:05 -04:00
Alan Rominger 550c6edb33 Merge pull request #1851 from AlanCoding/sch_modified_by
Fix schedules modified_by getting nulled
2018-05-23 10:42:07 -04:00
AlanCoding b7e9bda6cf track prior organization_id by base model prior values tore
Also fix bug where unified pointers were counted in
the prior values store
2018-05-23 08:54:03 -04:00