Rebeccah
5bfe89be6e
removed the to_representation and replaced with get_summary_fields per suggestion in PR comments
2020-03-23 14:57:07 -04:00
Rebeccah
47661fad51
added in summary fields into logging which will solve several issues related to needing more data in logging outputs
2020-03-23 14:57:07 -04:00
Rebeccah
457dc956f1
added a check for the field of finished making sure it's not none, and then breaking the DateTime function
2020-03-04 15:56:46 -05:00
Rebeccah
07752f48f6
formatted finished time to match microsecond expected output as is in the API.
2020-03-03 11:05:28 -05:00
Rebeccah
e11ff69f3e
Added in check for the unified_job_template_id attribute to be present and populated in the object.
...
For anyone reading this later, know that AdHocCommands still have unified_job_template and unified_job_template_id fields, they are just nonetypes because they don't get used by the AdHocCommand objects. Which means you have to actually get the object, not just check that it's there, to use it the way I am in this change.
2020-03-03 11:05:28 -05:00
Rebeccah
6d6d99bcf8
fixed the spelling of cancelled to be canceled, note to us later -> we need to stick with a single spelling of the word
2020-03-03 11:05:28 -05:00
Rebeccah
1fe28463da
added finished job timestamp to websocket emit
2020-03-03 11:05:28 -05:00
Rebeccah
98f5525d28
added unified job template ID to websocket emits
2020-03-03 11:05:28 -05:00
Rebeccah
eca516f8ce
removed 'self' from positional arguemnt of workflow attribute 'all_parents_must_converge' per Alans suggestion, since django takes it to be verbose_name, which is not needed
2020-02-05 17:38:36 -05:00
Rebeccah
fd60cd1a35
fixed copy functionality to include convergence as is instead of reseting ALL nodes to be default ANY nodes
2020-02-05 15:34:54 -05:00
Rebeccah
ad8bcd0de2
moved migration dependency from 0106 to 0107
2020-02-05 14:28:35 -05:00
Rebeccah
fdc29eebb7
expanded unit test to include 3 root nodes meeting on a convergence node and successfully marking that to node.
2020-02-05 14:28:35 -05:00
Rebeccah
63ae2cac38
Jake McDermott found some behavior that revealed a logical bug that would have caused issues later with ALL convergence nodes in sequential order via the API, although not the UI, and was causing existing issues with Root Nodes spawning repeatedly. To fix this I refactored the code from marking DNR nodes into it's own function that checks parents convergence criteria and leveraged that in bfs_nodes_to_run so that root nodes and convergence nodes can be differentiated but both can be correctly processed, also so that children of convergence nodes can be properly traversed by the function
2020-02-05 14:28:35 -05:00
Rebeccah
4e787cc079
made marking nodes as DNR more 'eager', added more unit tests, and added convergence check to bfs_nodes_to_run with new changes to the eagerness of DNR marking since it needs it to prevent convergence nodes from running too quickly
2020-02-05 14:28:35 -05:00
Rebeccah
a419547731
redid some formatting and syntax per personal preferences, comments on PR, and suggestions from @jrb
2020-02-05 14:28:35 -05:00
Rebeccah
1b3fbee38d
workflow convergence toggle migration
2020-02-05 14:28:35 -05:00
Rebeccah
6d2a2ab714
drastically improved performance by removing unnecessary iteration over children of parent nodes, additionally added an extra check that the node didn't already have a job so that it wasn't cycling over nodes that had already run when running through all_nodes
2020-02-05 14:28:35 -05:00
Rebeccah
82dd4a3884
remove node_object comparison and use the full dict to eliminate issues comparing obj and compare instead the whole node object with the node objects in the list
2020-02-05 14:28:35 -05:00
Rebeccah
86a39938fe
fixed issue where successful convergence wasn't being met due to the not quite correct leveraging of get_children
2020-02-05 14:28:35 -05:00
Rebeccah
70cf4cf5d4
added in handling for a parent being DNR so status is only checked if the parent isn't a DNR parent (in which case the parent has no status, which was breaking the logic) also edited a comment and added in a DNR check that @alancoding suggested to cut out duplicates in the DAG list
2020-02-05 14:28:34 -05:00
Rebeccah
2d3172f648
added in support for existing workflow unit tests
2020-02-05 14:28:34 -05:00
Rebeccah
b2c33e3204
redid migration dependency
2020-02-05 14:28:34 -05:00
Rebeccah
f7f648b956
included all_parents_must_converge in the get_workflow_job_fieldnames so that the true/false is copied into the job node and not just in the template node. Also added in the migration for the DB, also relocated logic from bfs_nodes_to_run down into mark_dnr_nodes to prevent nodes not being marked as DNR but not being marked to run, causing them to run anyways
2020-02-05 14:28:34 -05:00
Rebeccah
780f104ab2
shifted from dependants/dependencies to children/parents for clarity in function names, also added in toggle logic
2020-02-05 14:28:34 -05:00
Rebeccah
4c35adad6c
added logic to include workflow convergence nodes to nodes to run or not run based on their parents successful statuses
2020-02-05 14:28:34 -05:00
Rebeccah
cf24c81b3e
updated syntax from python2 to 3
2020-02-05 14:28:34 -05:00
Rebeccah
6f38edf9a3
add in testing to see that when an instance group is containerized that the policy field values are set to default
2019-11-12 13:13:34 -05:00
Rebeccah
1f05372ac9
change the logic to not break existing policy_instance testing
2019-11-12 13:13:34 -05:00
Rebeccah
d0327fc044
added onto the when saved function for instance groups that sets policy variables to their default.
2019-11-12 13:13:34 -05:00
Rebeccah
e4a21b67c7
remove u markers in assertion statements, they are unnecessary in python3
2019-10-30 15:52:14 -04:00
Rebeccah
2e6c484a50
added in testing for updating(or not allowing updates of) policy_instance variables in instance and container groups
2019-10-30 15:51:55 -04:00
Rebeccah
54ac1905b3
pinning pytest-mock to version 1.11.1
2019-10-29 11:24:16 -04:00
Rebeccah
220354241b
added in check to see if the the current check has an instance or not to prevent nonetype errors
2019-10-29 11:24:15 -04:00
Rebeccah
1ae8fdc15c
moved filterint out policy instance values in the api browser input box into the instanceGroupDetail class where I overrode the update_raw_data function to parse out the unneeded data. Additionally added the fix for checking the value in the serializer.
2019-10-29 11:24:15 -04:00
Rebeccah
4bbdce3478
removed policy_instance variables from container groups default values in the API put/patch view
2019-10-29 11:24:15 -04:00
Rebeccah
d25e6249fd
Added in validation for each of the 3 fields that should not be changed if the instance is a container group, defaults in the textarea persist with these 3 options
2019-10-29 11:24:15 -04:00
Rebeccah
678ce81487
pinning pytest-mock to version 1.11.1
2019-10-25 14:14:41 -04:00
Rebeccah Hunter
8de92b152c
Merge pull request #3899 from rebeccahhh/release_3.6.0
...
fix serializer validation when instance not present
2019-10-25 09:27:03 -04:00
Rebeccah
95ab5327c3
added in check to see if the the current check has an instance or not to prevent nonetype errors
2019-10-25 09:20:44 -04:00
Rebeccah Hunter
8669e87454
Merge pull request #3868 from rebeccahhh/release_3.6.0
...
Add api validation for policy rules in container groups
2019-10-24 11:29:10 -04:00
Rebeccah
4c199b0ab2
moved filterint out policy instance values in the api browser input box into the instanceGroupDetail class where I overrode the update_raw_data function to parse out the unneeded data. Additionally added the fix for checking the value in the serializer.
2019-10-23 17:18:21 -04:00
Rebeccah
ef7b3fec94
removed policy_instance variables from container groups default values in the API put/patch view
2019-10-23 17:15:56 -04:00
Rebeccah
93bd1e6705
Added in validation for each of the 3 fields that should not be changed if the instance is a container group, defaults in the textarea persist with these 3 options
2019-10-23 17:15:56 -04:00
Rebeccah
7efacb69aa
added in parsing for multiple choice and multiselect, which either takes a string, splits it up, and then eliminates any extra newlines, or just accepts alist. Extra newlines are sanitized out.
...
Signed-off-by: Rebeccah <rhunter@redhat.com >
2019-10-09 13:59:32 -04:00
Rebeccah
28a119ca96
re-worked unit test into 3 seperate unit tests, one for orphans, one for group members, and one for multi-group members
2019-09-30 15:07:19 -04:00
Rebeccah
758529d7dd
added in unit test for org admin deleting user
2019-09-30 15:07:19 -04:00
Rebeccah
075d1a2521
removed superuser check since can_admin already checks that, and also added allow orphans so admins can delete orphaned users
2019-09-30 15:07:19 -04:00
Rebeccah
69924c9544
added in ability to delete a user if they are part of your organization
2019-09-30 15:07:19 -04:00
Rebeccah
fbf182de28
removed refernce to workflow job in parent schedule naming as it is unnecessary
2019-09-16 14:22:37 -04:00
Rebeccah
5fab9e418b
added functional test to test new schedule functionality
2019-09-16 14:22:37 -04:00
Rebeccah
d39b931377
added in logic to check if the parent workflow has a schedule and onsolidated a couple import statements
2019-09-16 14:22:37 -04:00
Rebeccah
daba25f107
added 'ignored' and 'rescued' into all_hosts dictionary update
2019-09-03 18:58:29 -04:00
Rebeccah Hunter
be0c36540e
Removing job_status from the docs because it doesn't exist.
2019-08-23 10:53:23 -04:00
Rebeccah