External-Mirrors/awx
2
0
Fork 0
mirror of https://github.com/ansible/awx.git synced 2026-09-16 00:40:11 -02:30
Code Issues Packages Projects Releases Wiki Activity
33,957 Commits 63 Branches 102 Tags
e4646ae611dec3cc5ddee3a76330f8c87d7ec569
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Alan Rominger 47a061eb39 Fix and test data migration error from DAB RBAC (#15138) 
* Fix and test data migration error from DAB RBAC

* Fix up migration test

* Fix custom method bug

* Fix another fat fingered bug
 2024-04-24 15:14:03 -04:00
Alan Rominger c760577855 Adjust test for stricter DAB user view permission enforcement (#15130) 2024-04-23 15:21:06 -04:00
Alan Rominger e3af658f82 Use released version of django-radius (#15103) 2024-04-12 16:34:23 -04:00
Alan Rominger 390c2d8907 [RBAC] Update related name to reflect upstream DAB change (#15093) 
Update related name to reflect upstream DAB change
 2024-04-11 14:59:09 -04:00
Alan Rominger 97605c5f19 Make custom urls work with RBAC 2024-04-11 14:59:09 -04:00
Alan Rominger 818c326160 [RBAC] Rename managed role definitions, and move migration logic here (#15087) 
* Rename managed role definitions, and move migration logic here

* Fix naming capitalization
 2024-04-11 14:59:09 -04:00
Alan RomingerandSeth Foster c98727d83e [RBAC] Fix bug where team could not be given read_role to other team (#15067) 
* Fix bug where team could not be given read_role to other team

* Avoid unwanted triggers of parentage granting

* Restructure signal structure

* Fix another bug unmasked by team member permission fix

* Changes to live with test writing

* Use equality as opposed to string "in"

from Seth in review comment

Co-authored-by: Seth Foster <fosterseth@users.noreply.github.com>

---------

Co-authored-by: Seth Foster <fosterseth@users.noreply.github.com>
 2024-04-11 14:59:09 -04:00
Alan Rominger a138a92e67 [RBAC] Tweaks to reflect what endpoints are deprecated (#15068) 
Tweaks to reflect what endpoints are deprecated
 2024-04-11 14:59:09 -04:00
Alan Rominger 7aed19ffda Fix missing role membership when giving creator permissions (#15058) 2024-04-11 14:59:09 -04:00
Alan Rominger 389a729b75 [RBAC] Fix known issues with backward compatible access_list (#15052) 
* Remove duplicate access_list entries for direct team access

* Revert test changes for superuser in access_list
 2024-04-11 14:59:09 -04:00
Alan Rominger 2f3c9122fd Generalize can_delete solution, use devel DAB (#15009) 
* Generalize can_delete solution, use devel DAB

* Fix bug where model was used instead of model_name

* Linter fixes
 2024-04-11 14:59:09 -04:00
Alan Rominger 733478ee19 [RBAC] Fix server error from delete capability of approvals (#15002) 
Fix server error from delete capability of approvals
 2024-04-11 14:59:09 -04:00
Alan Rominger 41c6337fc1 [RBAC] Fix migration for created and modified field changes (#14999) 
Fix migration for created and modified field changes
 2024-04-11 14:59:09 -04:00
Alan Rominger 7446da1c2f Bump migration number for RBAC branch 2024-04-11 14:59:09 -04:00
Alan Rominger c79fca5ceb Adopt internal DAB RBAC Permission model (#14994) 2024-04-11 14:59:09 -04:00
Alan Rominger dc5f43927a Minor RBAC test fix (#14982) 2024-04-11 14:59:09 -04:00
Alan Rominger 35a5a81e19 Use AWX base view to make unauth requests 401 (#14981) 2024-04-11 14:59:09 -04:00
Alan Rominger 9dcc11d54c [DAB RBAC] Re-implement system auditor as a singleton role in new system (#14963) 
* Add new enablement settings from DAB RBAC

* Initial implementation of system auditor as role without testing

* Fix system auditor role, remove duplicate assignments

* Make the system auditor role managed

* Flake8 fix

* Remove another thing from old solution

* Fix a few test failures

* Add extra setting to disable custom system roles via API

* Add test for custom role prohibition
 2024-04-11 14:59:09 -04:00
Alan Rominger 74ce21fa54 Bump number of allowed endpoints (#14956) 2024-04-11 14:59:09 -04:00
Alan Rominger eb93660b36 Cache organization child evaluations and remove hacks 2024-04-11 14:59:09 -04:00
Alan Rominger f50e597548 Cast ObjectRole object_id to int, very wrong, tmp fix 2024-04-11 14:59:09 -04:00
Alan Rominger 817c3b36b9 Replace role system with permissions-based DB roles 
Develop ability to list permissions for existing roles

Create a model registry for RBAC-tracked models

Write the data migration logic for creating
  the preloaded role definitions

Write migration to migrate old Role into ObjectRole model

This loops over the old Role model, knowing it is unique
  on object and role_field

Most of the logic is concerned with identifying the
  needed permissions, and then corresponding role definition

As needed, object roles are created and users then teams
  are assigned

Write re-computation of cache logic for teams
  and then for object role permissions

Migrate new RBAC internals to ansible_base

Migrate tests to ansible_base

Implement solution for visible_roles

Expose URLs for DAB RBAC
 2024-04-11 14:59:09 -04:00
Alan Rominger 1859a6ae69 Fix failure from DAB (#15102) 
@AlanCoding said to do this 🚌
 2024-04-11 17:10:11 +00:00
Alan Rominger cc5d4dd119 Clean the postgres 15 volume (#15083) 2024-04-09 16:06:42 -04:00
Alan Rominger 4b6f7e0ebe Add link to service-index URL 2024-03-29 10:07:15 +00:00
Alan Rominger 30500e5a95 Re-parent DAB views from AWX base 2024-03-29 10:03:12 +00:00
Alan Rominger f48b2d1ae5 Add resource and ansible_id to serializers (#15020) 2024-03-26 22:37:15 -04:00
Alan Rominger a4a2fabc01 Add test for utils method is_testing 2024-03-05 11:38:14 +00:00
Alan Rominger d70c6b9474 Reset another to test-playbooks 2024-02-21 15:11:12 +00:00
Alan Rominger 5549516a37 Reset these tests back to test-playbooks 2024-02-21 15:11:12 +00:00
Alan Rominger 14ac91a8a2 Swap repos test fix 2024-02-21 15:11:12 +00:00
Alan Rominger d5753818a0 Stop using the bulky test-playbooks in tests where possible 2024-02-21 15:11:12 +00:00
Alan Rominger 14454cc670 Fix playbook errors found by debugging 2024-02-21 14:36:41 +00:00
Alan Rominger 7ab2bca16e Fix missing var name change 2024-02-21 14:36:41 +00:00
Alan Rominger f0f655f2c3 Style consistency for task 'when' 2024-02-21 14:36:41 +00:00
Alan Rominger 1ebff23232 Do not rely on unreliable dir output and use exists query 2024-02-21 13:43:54 +00:00
Alan Rominger 700de14c76 Make the migration middleware faster, second attempt 2024-02-21 13:43:54 +00:00
Alan Rominger cd91fbf59f Label any changes to requirements folder with dependencies label 2024-02-19 15:56:53 +00:00
Alan Rominger 1f7be9258c Remove tower_legacy module_utils that appears unused (#14421) 
* Remove tower_legacy module that appears unused

* Update license details
 2024-02-16 16:02:09 -05:00
Alan Rominger 4d80f886e0 Revert "Drop cython dep" (#14884) 
* Revert "Remove cython lib"

This reverts commit 46f816e7a4.

* Revert "WIP consider droping cython dep"

This reverts commit 54b32c10f0.

* Update Cython comment
 2024-02-15 11:58:17 -05:00
Alan Rominger 362e11aaf2 Respect old downtime setting name if user has already set it 2024-02-15 12:34:24 +00:00
Alan Rominger 46f816e7a4 Remove cython lib 2024-02-13 14:45:28 +00:00
Alan Rominger 54b32c10f0 WIP consider droping cython dep 2024-02-13 14:45:28 +00:00
Alan Rominger 20202054cc Use lowercase password 2024-02-13 14:36:39 +00:00
Alan Rominger e84e2962d0 Support DB configs where PASSWORD is not used 2024-02-13 14:36:39 +00:00
Alan Rominger 4c41f6b018 Ability to use updater script to pin dev requirements (#14644) 
* Add a dev option for updater script to pin CI reqs

* Avoid removing git links for dev requirements

* Add dev to primary options

* Fix up sanitize git switch
 2024-02-12 11:57:59 -05:00
Alan Rominger 8eb4a9a2a0 Update location of logstash build context (#14676) 2024-02-12 15:49:29 +00:00
Alan Rominger a1bbe75aed Adopt new rules from black upgrade (#14809) 2024-01-26 12:54:44 -05:00
Alan Rominger d91da39f81 New setting for pg_notify listener DB settings, add keepalive (#14755) 2024-01-17 13:44:04 -05:00
Alan Rominger 325f5250db Narrow the actor types accepted for RBAC evaluations (#14709) 
* Narrow the scope of RBAC evaluations

* Update tests for RBAC method changes

* Simplify querset for credentials in org

* Fix call pattern to pass in team role obj
 2023-12-14 21:30:47 -05:00
Alan Rominger b14518c1e5 Simplify RBAC get_roles_on_resource method (#14710) 
* Simplify RBAC get_roles_on_resource method

* Fix bug

* Fix query type bug
 2023-12-14 10:42:26 -05:00
Alan Rominger 1294cec92c Fix updater bug due to missing newline at EOF (#14713) 2023-12-08 16:51:17 +00:00
Alan Rominger adb1b12074 Update RBAC docs, remove unused get_permissions (#14492) 
* Update RBAC docs, remove unused get_permissions

* Add back in section for get_roles_on_resource
 2023-11-16 11:29:33 -05:00
Alan Rominger 8fae20c48a Remove unused methods we attach to user model (#14668) 2023-11-16 11:21:21 -05:00
Alan Rominger 1f36e84b45 Correctly handle case where unpartitioned table does not exist (#14648) 2023-11-14 08:38:48 -05:00
Alan Rominger 93c329d9d5 Fix cancel bug - WorkflowManager cancel in transaction (#14608) 
This fixes a bug where jobs within a workflow job were not canceled
  when the workflow job was canceled by the user

The fix is to submit the cancel request as a part of the
  transaction that WorkflowManager commits its work in
  this requires that we send the message without expecting a reply
  so this changes the control-with-reply cancel to just a control function
 2023-10-30 15:30:18 -04:00
Alan Rominger 333ef76cbd Send notifications for dependency failures (#14603) 
* Send notifications for dependency failures

* Delete tests for deleted method

* Remove another test for removed method
 2023-10-30 10:42:37 -04:00
Alan Rominger fc0b58fd04 Fix bug that prevented dispatcher exit with downed DB (#14469) 
* Separate handling of original sitTERM and sigINT
 2023-10-26 14:34:25 -04:00
Alan Rominger b6b167627c Fix Boolean values defaulting to False in collection (#14493) 
* Fix Boolean values defaulting to False in collection

* Remove null values in other cases, fix null handling for WFJT nodes

* Only remove null values if it is a boolean field

* Reset changes to WFJT node field processing

* Use test content from sean-m-sullivan to fix lookups in assert
 2023-10-24 14:29:16 -04:00
Alan Rominger 07f49f5925 AAP-16926 Delete unpartitioned tables in a separate transaction (#14572) 2023-10-13 15:50:51 -04:00
Alan Rominger 19ca480078 Upgrade client library for dsv since tss already landed (#14362) 2023-10-11 16:01:22 -04:00
Alan Rominger 9745058546 Only block commits if black fails for certain paths (#14531) 2023-10-10 10:12:57 -04:00
Alan Rominger e72e9f94b9 Fix collection test flake due to successful canceled command (#14519) 2023-10-04 09:09:29 -04:00
Alan Rominger f5922f76fa DROP unnecessary unpartioned event tables (#14055) 2023-10-03 11:49:23 -04:00
Alan Rominger 1d340c5b4e Add a section for postgres max_connections value (#14482) 2023-09-28 10:28:52 -04:00
Alan Rominger 770cc10a78 Get rid of names_digest hack no longer needed (#14459) 2023-09-26 12:09:30 -04:00
Alan Rominger 159dd62d84 Add null value handling in create_partition (#14480) 2023-09-25 18:28:44 -04:00
Alan Rominger 9ed527eb26 Consolidate image and server setup in several checks (#14477) 2023-09-25 09:02:20 -04:00
Alan Rominger 29ad6e1eaa Fix bug, None was used instead of empty for DB outage (#14463) 2023-09-21 14:30:25 -04:00
Alan Rominger 3e607f8964 AAP-15927 Use ATTACH PARTITION to avoid exclusive table lock for events (#14433) 2023-09-21 14:27:04 -04:00
Alan Rominger 3b8e662916 Remove conditional paths due to conflict with required checks (#14450) 2023-09-14 16:19:42 -04:00
Alan Rominger aa3228eec9 Fix continue-on-error GH actions bug, always run archive step instead 2023-09-14 19:45:07 +00:00
Alan Rominger 7b0598c7d8 Continue workflow steps to save logs from failed tests (#14448) 2023-09-14 18:23:22 +00:00
Alan Rominger 8feeb5f1fa Allow saving github creds in user folder (#14435) 2023-09-12 15:47:12 -04:00
Alan Rominger 09168e5832 Edit docker-compose instructions for correctness (#14418) 2023-09-06 11:55:25 -04:00
Alan Rominger 6df1de4262 Avoid activity stream entries for instance going offline (#14385) 2023-09-06 11:18:52 -04:00
Alan RomingerandMaxwell G e072bb7668 Declare license for unique module that uses BSD-2 
Co-authored-by: Maxwell G <maxwell@gtmx.me>
 2023-09-06 10:43:25 -04:00
Alan Rominger ec579fd637 Fix collection metadata license to match intent 2023-09-06 10:43:25 -04:00
Alan Rominger 20fc7c702a Add check for building docsite (#14406) 2023-09-05 16:07:48 -04:00
Alan Rominger ab3ceaecad Remove extra scheduler state save that does nothing (#14396) 2023-08-31 10:35:07 -04:00
Alan Rominger cdb4f0b7fd Consume job_explanation from runner, fix error reporting error (#13482) 2023-08-30 16:45:50 -04:00
Alan Rominger 951bd1cc87 Re-run the updater script after upstream removal of future (#14265) 2023-08-29 15:36:42 -04:00
Alan Rominger 4fbdc412ad Restrict PR body check to just AWX repo 2023-08-29 09:29:30 -04:00
Alan Rominger db1af57daa Revert "Adding PR check to ensure JIRA links are present" 
This reverts commit 3ae6174050.
 2023-08-29 09:29:30 -04:00
Alan Rominger c448b87c85 AAP-10891 Apply AWX_TASK_ENV when performing credential plugin lookups (#14271) 2023-08-23 13:26:12 -04:00
Alan Rominger 8dc6ceffee Fix programming error in facts retry merge (#14336) 2023-08-11 13:54:18 -04:00
Alan Rominger 2c7184f9d2 Add a retry to update host facts on deadlocks (#14325) 2023-08-11 11:13:56 -04:00
Alan Rominger 284bd8377a Integrate scheduler into dispatcher main loop (#14067) 
Dispatcher refactoring to get pg_notify publish payload
  as separate method

Refactor periodic module under dispatcher entirely
  Use real numbers for schedule reference time
  Run based on due_to_run method

Review comments about naming and code comments
 2023-08-10 14:43:07 -04:00
Alan Rominger 6f9ea1892b AAP-14538 Only process ansible_facts for successful jobs (#14313) 2023-08-04 17:10:14 -04:00
Alan Rominger ab5cc2e69c Simplifications for DependencyManager (#13533) 2023-07-27 15:42:29 -04:00
Alan Rominger 98bfe3f43f Add missing trigger for failed-to-start nodes (#13802) 2023-07-24 12:17:46 -04:00
Alan Rominger ea455df9f4 Only push the production images for main repo (#14261) 2023-07-19 09:51:33 -04:00
Alan Rominger b8c48f7d50 Restore pre-upgrade pg_notify notifcation behavior (#14222) 2023-07-11 16:23:53 -04:00
Alan Rominger 82abd18927 Fix DELETE 500 KeyError due to eventless model events (#14172) 2023-07-05 15:37:52 -04:00
Alan Rominger aed96fb365 Use the proper queryset to filter project update events (#14166) 2023-06-26 21:41:08 -04:00
Alan Rominger fe2da52eec Upgrade Github actions issue labeler to fix 404 errors (#14163) 2023-06-26 17:14:53 -04:00
Alan RomingerandSarabraj Singh 974465e46a Add hashivault option as docker-compose optional container (#14161) 
Co-authored-by: Sarabraj Singh <singh.sarabraj@gmail.com>
 2023-06-26 15:48:58 -04:00
Alan Rominger c736986023 Try to fix CI by adding dropped coreapi lib (#14165) 2023-06-26 15:11:12 -04:00
Alan Rominger 755e55ec70 Remove reference to unmaintained runner image (#14143) 2023-06-23 10:15:11 -04:00
Alan Rominger aa8437fd77 Tooling for running collection tests locally ad hoc (#14160) 2023-06-22 13:32:09 -04:00