External-Mirrors/awx
2
0
Fork 0
mirror of https://github.com/ansible/awx.git synced 2026-09-16 00:40:11 -02:30
Code Issues Packages Projects Releases Wiki Activity
16,256 Commits 63 Branches 102 Tags
e7a8ecc05a029d81ece280dcf31d487529da1fcd
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Alan Rominger ad8822bcfc Merge pull request #1314 from AlanCoding/fix_rescheduling 
Correct permission check for job rescheduling
 2018-02-22 16:04:04 -05:00
Alan Rominger db39ab1b0c Merge pull request #1322 from AlanCoding/check_version 
Loosen overwrite_vars constraint for new feature
 2018-02-22 14:26:30 -05:00
AlanCoding 4727cda336 Loosen overwrite_vars constraint for new feature 2018-02-22 07:47:28 -05:00
Alan Rominger 2ebee58727 Merge pull request #1321 from AlanCoding/magic_credential 
Alias filters by credential to credentials
 2018-02-21 15:51:42 -05:00
AlanCoding 91e59ebd29 alias filters by credential to credentials 2018-02-21 14:57:26 -05:00
AlanCoding 992d7831b1 add test for ScheduleAccess prompts 2018-02-21 14:11:55 -05:00
AlanCoding de4e95f396 correct permission check for job rescheduling 2018-02-21 09:25:43 -05:00
Alan Rominger 1582fcbb50 Merge pull request #1277 from AlanCoding/inv_multicred 
Use the m2m field for inventory source credentials
 2018-02-20 14:08:22 -05:00
AlanCoding bb6032cff6 docs and review change for IS multivault 
Mention inventory sources /credentials/ endpoint in docs
Also change means of identifying projects for the purose
of injecting custom credentials
 2018-02-20 12:34:58 -05:00
AlanCoding 9c4d89f512 use the m2m field for inventory source creds 2018-02-20 12:34:56 -05:00
Alan Rominger 1a6819cdea Merge pull request #630 from AlanCoding/text_type 
Fix unicode bugs with log statements
 2018-02-15 15:52:29 -05:00
AlanCoding 465e605464 fix unicode bugs with log statements 2018-02-15 15:26:58 -05:00
Alan Rominger 22f1a53266 Merge pull request #1233 from AlanCoding/no_turning_back 
Raise 400 error on removal of credential on launch
 2018-02-15 14:11:57 -05:00
AlanCoding 3d433350d3 raise 400 error on removal of credential on launch 
Definition of removal is providing a `credentials` list on launch
that lacks a type of credential that the job template has.
This assures that every category of credential the job template
has will also exist on jobs ran from that job template.
This restriction already existed, but this makes the endpoint
fail instead of re-adding the credentials.
This change makes manual launch congruent with saved launch
configurations.
 2018-02-15 08:16:03 -05:00
Alan Rominger 5935c410e4 Merge pull request #629 from AlanCoding/export 
Use --export option for ansible-inventory
 2018-02-14 15:56:05 -05:00
Alan Rominger c90cf7c5e2 Merge pull request #1253 from AlanCoding/group_vars 
Use --export option for ansible-inventory
 2018-02-14 15:52:00 -05:00
AlanCoding b01deb393e use --export option for ansible-inventory 2018-02-14 14:48:13 -05:00
AlanCoding 05e6eda453 use --export option for ansible-inventory 2018-02-14 12:34:41 -05:00
Alan Rominger 39362aab4b Merge pull request #1204 from AlanCoding/default_omission 
Omit placeholder vars with survey password defaults
 2018-02-13 12:58:11 -05:00
Alan Rominger 6cb3267ebe Merge pull request #1214 from AlanCoding/fix_schedule_qs 
Change schedule queryset logic to avoid server error
 2018-02-13 12:54:05 -05:00
AlanCoding 58a94be428 Omit placeholder vars with survey password defaults 
WFJT nodes & schedules (launch configs) will accept POST/PATCH/PUT
with variables in extra_data that have $encrypted$ for their value
if a valid survey default exists.

In this case, the variable is simply removed from the extra_data.
This is done so that it does not affect pre-existing value
substitution for $encrypted$ values from the config itself
 2018-02-13 09:07:59 -05:00
AlanCoding 960845883d change schedule qs logic, avoid server error 2018-02-13 08:32:00 -05:00
Alan Rominger 0268d575f8 Merge pull request #1193 from AlanCoding/no_sneaking_credential_in 
Validation clause for WFJT node to follow credential prompt rule
 2018-02-12 12:46:12 -05:00
AlanCoding 02ac139d5c validation clause for WFJT node to follow cred prompt rule 2018-02-09 16:17:21 -05:00
Alan Rominger b3dcfc8c18 Merge pull request #903 from ansible/item_copy 
Implement item copy feature
 2018-02-08 15:51:16 -05:00
Alan Rominger 01c6463b1b Merge pull request #1162 from AlanCoding/remove_cred_sf 
Remove credential from node and schedule summary fields
 2018-02-08 10:37:46 -05:00
Alan Rominger 181399df7a Merge pull request #1159 from AlanCoding/reschedule_msg 
Verbose error messages for failure to re-schedule
 2018-02-08 10:28:11 -05:00
AlanCoding 0f66892d06 remove credential from node and schedule summary fields 2018-02-08 09:22:55 -05:00
AlanCoding 87b59903a5 verbose error messages for failure to re-schedule 2018-02-08 08:46:56 -05:00
Alan Rominger b38aa3dfb6 Merge pull request #1153 from AlanCoding/fix_wfjt_scheduling 
fix bug scheduling WFJT without prompts
 2018-02-07 15:49:13 -05:00
AlanCoding fe69a23a4e fix bug scheduling WFJT without prompts 2018-02-07 14:34:25 -05:00
AlanCoding 80a2d10742 fix bug when creating system job schedule 2017-12-20 15:30:57 -05:00
AlanCoding 08570fe785 make inventory update name combination of inventory and source 2017-12-18 16:21:39 -05:00
Alan Rominger 6e27294e2b Merge pull request #846 from AlanCoding/encrypt_on_save 
Encrypt password answers on config save
 2017-12-18 16:20:08 -05:00
AlanCoding 3439ba5f3b allow WFJT nodes without required variables 2017-12-18 12:03:40 -05:00
AlanCoding c8e10adc96 fix bug saving extra_data and follow prompts rules 
display_extra_vars was not taking a copy of the data before
acting on it - this causes a bug where the activity stream will
modify the existing object on the model. That leads to new data
not being accepted.

Also moved the processing of extra_data to prior to the accept
or ignore kwargs logic so that we pass the right (post-encryption)
form of the variables.
 2017-12-18 10:50:22 -05:00
AlanCoding 1e1839915d validate against unencrypted values at spawn point 2017-12-15 10:47:23 -05:00
AlanCoding 74bf058d62 encrypt password answers on config save 2017-12-15 07:48:55 -05:00
AlanCoding 0bb9c58e25 cache the global settings list, cProfile speedup 2017-12-14 11:29:30 -05:00
Alan Rominger 9c783aa0ce Merge pull request #804 from AlanCoding/active_count 
simplify query for active_count
 2017-12-14 10:47:12 -05:00
Alan Rominger 526391a072 Merge pull request #838 from AlanCoding/no_unicode_loop_2 
Avoid slowdown generating smart_filter (alternative 2)
 2017-12-14 10:23:31 -05:00
AlanCoding 98f8faa349 simplify query for active_count 2017-12-14 09:53:26 -05:00
AlanCoding 8a2a5b0fb1 avoid slowdown generating smart_filter 2017-12-14 09:39:39 -05:00
AlanCoding e188692acf use Options models to consolidate field_names list 2017-12-13 22:39:38 -05:00
AlanCoding 9fb24f1a4c add hack to TimingMiddlWare for Shippable tests 2017-12-13 18:49:26 -05:00
Alan Rominger 7eb2d86890 Merge pull request #749 from AlanCoding/detail_opt 
Apply list view optimizations to detail view
 2017-12-13 18:19:00 -05:00
AlanCoding e3a731bb9e apply listview optimizations to detail view 2017-12-13 16:09:37 -05:00
AlanCoding 77a1c405a6 flake8 fixes from removal of reencrypt test 2017-12-13 14:32:34 -05:00
AlanCoding 1b0bca8229 add back in support of towervars lost in merge 2017-12-13 14:30:11 -05:00
Alan Rominger 6c1c850c5f Merge pull request #816 from AlanCoding/ints 
use credential property that returns integers
 2017-12-13 12:56:07 -05:00
AlanCoding f4f1e0fd3c use credential property that returns integers 2017-12-13 12:54:32 -05:00
AlanCoding 7243f871b4 fix bug creating inventory source schedules 2017-12-12 17:49:51 -05:00
Alan Rominger 8d348f916b Merge pull request #794 from AlanCoding/hide_config_pass 
Hide survey passwords in saved launch configs
 2017-12-12 10:37:41 -05:00
AlanCoding 659d31324d hide survey passwords in saved launch configs 2017-12-12 09:35:46 -05:00
Alan Rominger 1be3c77ac6 Merge pull request #787 from AlanCoding/workflow_system_jobs 
allow using SystemJobTemplates in workflows
 2017-12-11 13:21:33 -05:00
AlanCoding 4adfb9804e allow using SystemJobTemplates in workflows 2017-12-11 08:58:45 -05:00
Alan Rominger 64ac1ee238 Merge pull request #746 from AlanCoding/i_forgot 
Intentionally forget start_args when job is done
 2017-12-11 08:08:27 -05:00
AlanCoding 0bf06479d5 add migration to remove old start_args 2017-12-10 12:08:59 -05:00
AlanCoding 1f8cab4171 intentionally forget start_args when job is done 2017-12-10 12:08:54 -05:00
Alan Rominger 2135291f35 Merge pull request #740 from AlanCoding/configs_rebased5 
Feature: saved launchtime configurations
 2017-12-08 16:55:00 -05:00
AlanCoding a9aae91634 generalize schedule prompts validation 
This makes ScheduleSerializer behave same as WFJT nodes
Prevents providing job_type for workflow jobs, as example
 2017-12-08 16:23:56 -05:00
AlanCoding 905ff7dad7 fix bugs where ask_ var was checked on node 2017-12-08 13:57:33 -05:00
AlanCoding e59a724efa fix bug that broke combining WFJT and node vars 2017-12-08 13:48:45 -05:00
AlanCoding 1c8217936d Bug fixes from integration ran on launchtime branch 
Make error message for muti-vault validation more
consistent with historical message
 2017-12-08 13:46:38 -05:00
AlanCoding 72a8854c27 Make ask_mapping a simple class property 
from PR feedback of saved launchtime configurations
 2017-12-08 13:45:23 -05:00
AlanCoding 98df442ced combine launch config and multi-cred migrations 2017-12-08 13:45:21 -05:00
AlanCoding 5ada021a6e Tweak validation to allow multiple vault credentials 
support providing vault passwords based on id
include needed passwords in launch serializer defaults
 2017-12-08 13:43:43 -05:00
AlanCoding 34a8e0a9b6 Feature: saved launchtime configurations 
Consolidate prompts accept/reject logic in unified models
Break out accept/reject logic for variables
Surface new promptable fields on WFJT nodes, schedules

Make schedules and workflows accurately reject variables
  that are not allowed by the prompting
  rules or the survey rules on the template

Validate against unallowed extra_data in system job schedules
Prevent schedule or WFJT node POST/PATCH with unprompted data
Move system job days validation to new mechanism
Add new psuedo-field for WFJT node credential
Add validation for node related credentials
Add related config model to unified job
Use JobLaunchConfig model for launch RBAC check

Support credential overwrite behavior with multi-creds
  change modern manual launch to use merge behavior
Refactor JobLaunchSerializer, self.instance=None
Modularize job launch view to create "modern" data
Auto-create config object with every job
Add create schedule endpoint for jobs
 2017-12-08 13:38:54 -05:00
Alan Rominger 7fe22e9c53 Merge pull request #757 from AlanCoding/vault_cred_noop 
allow no-op case for vault_credential
 2017-12-04 16:01:00 -05:00
Alan Rominger 42d8368596 Merge pull request #763 from AlanCoding/remember_where_you_came_from 
add AWX meta extra_vars for workflow + schedule
 2017-12-04 15:52:30 -05:00
AlanCoding eecf997856 add AWX meta extra_vars: WFJT + schedule 2017-12-04 15:33:05 -05:00
Alan Rominger 759867c863 Merge pull request #609 from AlanCoding/more_encryption_tests 
encryption tests around the contract with survey functionality
 2017-12-04 14:20:30 -05:00
Alan Rominger d4613d448c Merge pull request #608 from AlanCoding/empty_string_defaults 
allow password default reuse with empty default
 2017-12-04 14:19:32 -05:00
AlanCoding dbd68c5747 encryption tests around the contract with survey functionality 2017-12-04 11:45:07 -05:00
AlanCoding d23d7c422d allow password default reuse with empty default 2017-12-04 10:49:36 -05:00
Alan Rominger e0edfeac7c Merge pull request #602 from AlanCoding/clean_defaults 
block user from entering encrypted as bare default
 2017-12-01 14:54:42 -05:00
AlanCoding 47f45bf9b3 block user from entering encrypted as bare default 2017-12-01 14:44:06 -05:00
AlanCoding 6269b43456 update tests to new Ansible core code 2017-12-01 12:31:56 -05:00
AlanCoding 67867cf0c8 flake8: comply with new E722 rule 2017-12-01 12:16:44 -05:00
AlanCoding dfc154ed95 allow no-op case for vault_credential 2017-12-01 10:29:23 -05:00
Alan Rominger fde5a8850d Merge pull request #748 from AlanCoding/no_job_in_relaunch 
Do not show job serialization in relaunch GET
 2017-11-30 09:58:35 -05:00
AlanCoding c359c072c4 do not show job serialization in relaunch GET 2017-11-30 08:47:35 -05:00
Alan Rominger 53c6248a6d Merge pull request #647 from AlanCoding/no_sql 
remove raw SQL in visible_roles
 2017-11-29 16:46:09 -05:00
AlanCoding c4bc310271 remove raw SQL in visible_roles 2017-11-29 16:04:31 -05:00
Alan Rominger 43c58b5bf5 Merge pull request #731 from AlanCoding/enabled_fix 
fix inventory import bug with enabled_var
 2017-11-29 14:46:16 -05:00
AlanCoding 2c06bfc9ce fix inventory import bug with enabled_var 2017-11-29 14:12:03 -05:00
Alan Rominger 5602b5d2d7 Merge pull request #733 from AlanCoding/credentials_in_list 
Show credentials in list view
 2017-11-29 12:09:52 -05:00
Alan Rominger 04f682bf7a Merge pull request #694 from AlanCoding/credentials_not_a_thing 
adjust assertions about JT credentials to be correct
 2017-11-29 10:41:48 -05:00
Alan Rominger 070a12a10c Merge pull request #692 from AlanCoding/vault_credential_check 
Modify JT access tests to reflect new vault_credential reality
 2017-11-29 10:40:35 -05:00
AlanCoding 37a44c439e show credentials in list view 2017-11-29 08:14:45 -05:00
Alan Rominger 8f5be46d52 Merge pull request #730 from AlanCoding/list_bug 
fix bug with inventory update queryset
 2017-11-28 18:41:39 -05:00
AlanCoding a880f47925 fix bug with inventory update queryset 2017-11-28 14:13:35 -05:00
AlanCoding 9fe524cd20 adjust assertions about JT credentials to be correct 2017-11-21 10:03:57 -05:00
AlanCoding 1481a62b23 modify JT access tests to reflect new vault_credential reality 2017-11-21 08:40:04 -05:00
Alan Rominger ce6d96feda Merge pull request #687 from AlanCoding/new_kill 
allow deletion of new jobs
 2017-11-21 07:20:05 -05:00
AlanCoding 6c57a3bb68 allow deletion of new jobs 2017-11-20 11:19:22 -05:00
Alan Rominger 4ea27e0d1b Merge pull request #587 from AlanCoding/computed_self 
update original when updating computed fields
 2017-11-17 12:23:43 -05:00
AlanCoding 51c73cb357 update original when updating computed fields 2017-11-17 10:16:49 -05:00
AlanCoding fb29f68efc update smart inventory computed fields 2017-11-16 11:57:30 -05:00
Alan Rominger 71127c039d Merge pull request #668 from AlanCoding/null_cred_okay2 
Do not filter out JTs with null credentials
 2017-11-16 11:18:16 -05:00