Newer ansible versions don't allow with_items to reference undefined
variables so we'll provide a default.
We'll also update some conditionals to deal with naming requirements
changes on insights api endpoints
These macros were intended to pull the version and release from a python file if they werent passed in with --define, but /usr/bin/python is not available at this point in the build process. I'm not sure when or if this ever worked. Perhaps before we were using mock.
This approach also works for our Brew builds, as we cannot specify a macro value at build time.
* release_3.1.2: (149 commits)
updating changelog for 3.1.2
Add back SRC_ONLY_PKGS
Fix ubuntu 14 restart service list pt 2
Make sure the insight playbook fetch doesn't quote user and pass
Add requirements/vendor to gitignore
Conditionally install from local python dependencies in spec file
Remove requirements/vendor on make clean.
Update brew-srpm target to generate local requirements files
Get offline pip installs working
Add clean-dist target
Navigate back to the jobDetails state when the user clicks outside the host event modal.
Don't use jinja quote filter on insights username or password
fix legacy standard out
Fixed permissions typo
add test, restore old behavior in api test
create _survey_element_validation and use it for updating extra_vars
Do not set the default if the field was not passed in to kwargs_extra_vars
Remove log aggregator port required mark.
Modify according to review feedback.
Host Event json should be read-only
...
This looks pretty hairy, but essentially it's just re-invoking `pip download` with `--no-deps` so that I can record the name of the local archives that are created.
I had to pull the git urls out of the main requirements files because in order to install offline (--no-index), we need pip to install from local package archives rather than cloning repo.
The weird `cat` thing going on in the Makefile is because we need to install everything as part of a single `pip install` transaction. Without this, installing only requirements_git.txt will result in dependencies getting unintentionally updated.
This fixes an issue where a user was trying to use an exclamation mark
in the password. Historically we've used the quote filter but more and
more we're seeing conflicts with special characters
