Dirk JulichandClaude Opus 4.6
2a6dd41186
* AAP-89067: Fix stale image purge when EE image reference form changes The _handle_image_cleanup signal compared images by string only, so two references to the same underlying image (e.g. tag vs digest) were treated as different. This caused podman rmi to strip all names from a still-needed image, breaking environments especially in disconnected installs. Add layered guards: skip cleanup for managed images (settings and managed=True EE objects), detect tag-vs-digest reference form changes for the same repository, and check other EEs for cross-reference form conflicts on delete. Genuinely different versions (v1→v2) still get cleaned up. * Reduce cognitive complexity of _handle_image_cleanup Extract the delete-path loop into _other_ee_shares_repo_with_different_ref to flatten nesting and bring cognitive complexity under the SonarQube threshold of 15. * Extend managed-image guard to match by repo when ref forms differ _is_managed_image previously only did exact string comparison against managed settings, so repo@sha256:... would not match repo:tag in CONTROL_PLANE_EXECUTION_ENVIRONMENT or GLOBAL_JOB_EXECUTION_ENVIRONMENTS. Now also compares by repository + reference form (tag vs digest). * Add docstring to _handle_image_cleanup --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Caution
The last release of this repository was released on Jul 2, 2024. Releases of this project are now paused during a large scale refactoring. For more information, follow the Forum and - more specifically - see the various communications on the matter:
AWX provides a web-based user interface, REST API, and task engine built on top of Ansible. It is one of the upstream projects for Red Hat Ansible Automation Platform.
To install AWX, please view the Install guide.
To learn more about using AWX, view the AWX docs site.
The AWX Project Frequently Asked Questions can be found here.
The AWX logos and branding assets are covered by our trademark guidelines.
Contributing
- Refer to the Contributing guide to get started developing, testing, and building AWX.
- All code submissions are made through pull requests against the
develbranch. - All contributors must use
git commit --signofffor any commit to be merged and agree that usage of--signoffconstitutes agreement with the terms of DCO 1.1 - Take care to make sure no merge commits are in the submission, and use
git rebasevs.git mergefor this reason. - If submitting a large code change, it's a good idea to join discuss via the Ansible Forum. This helps everyone know what's going on, and it also helps save time and effort if the community decides some changes are needed.
Reporting Issues
If you're experiencing a problem that you feel is a bug in AWX or have ideas for improving AWX, we encourage you to open an issue and share your feedback. But before opening a new issue, we ask that you please take a look at our Issues guide.
Code of Conduct
We require all of our community members and contributors to adhere to the Ansible code of conduct. If you have questions or need assistance, please reach out to our community team at codeofconduct@ansible.com
Get Involved
We welcome your feedback and ideas via the Ansible Forum.
For a full list of all the ways to talk with the Ansible Community, see the AWX Communication guide.