Alan RomingerandClaude Opus 4.6
70f42d2b7d
* AAP-87084 — Revert UnifiedJob queryset to DAB APIs, scope actor role filter The previous patch (7242fe89) inlined all DAB RBAC internals into UnifiedJobAccess.filtered_queryset to pre-compute role IDs and avoid repeated subqueries. While it fixed the UNION regression fromc84575c, it created 70 lines of duplicated logic inconsistent with the UnifiedJobTemplate path and fetched ALL user roles regardless of relevance. This commit: - Reverts filtered_queryset to the clean post-f8fa690 form that delegates to DAB's access_ids_qs / accessible_pk_qs APIs - Adds _scoped_actor_role_filter() as a temporary shim that pre-filters RoleUserAssignment by content_type_id, auto-including Org and Team CTs for inherited permissions and NULL for global roles - Wires the scoped filter into UnifiedJobTemplate.accessible_pk_qs - Adds tests for custom global roles, mixed permissions, and unrelated role exclusion The shim duplicates logic planned for DAB's _actor_role_filter content_type_ids parameter; once that merges, replace and delete. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Remove unused ContentType and RoleUserAssignment imports to fix flake8 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * AAP-87084 — Remove _scoped_actor_role_filter shim, use DAB _actor_role_filter directly The scoped content_type_ids parameter now lives in DAB's _actor_role_filter. The AWX shim and its hardcoded Org/Team CT inclusions are no longer needed. The unified job accessible_pk_qs uses the unscoped _actor_role_filter for correctness. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Caution
The last release of this repository was released on Jul 2, 2024. Releases of this project are now paused during a large scale refactoring. For more information, follow the Forum and - more specifically - see the various communications on the matter:
AWX provides a web-based user interface, REST API, and task engine built on top of Ansible. It is one of the upstream projects for Red Hat Ansible Automation Platform.
To install AWX, please view the Install guide.
To learn more about using AWX, view the AWX docs site.
The AWX Project Frequently Asked Questions can be found here.
The AWX logos and branding assets are covered by our trademark guidelines.
Contributing
- Refer to the Contributing guide to get started developing, testing, and building AWX.
- All code submissions are made through pull requests against the
develbranch. - All contributors must use
git commit --signofffor any commit to be merged and agree that usage of--signoffconstitutes agreement with the terms of DCO 1.1 - Take care to make sure no merge commits are in the submission, and use
git rebasevs.git mergefor this reason. - If submitting a large code change, it's a good idea to join discuss via the Ansible Forum. This helps everyone know what's going on, and it also helps save time and effort if the community decides some changes are needed.
Reporting Issues
If you're experiencing a problem that you feel is a bug in AWX or have ideas for improving AWX, we encourage you to open an issue and share your feedback. But before opening a new issue, we ask that you please take a look at our Issues guide.
Code of Conduct
We require all of our community members and contributors to adhere to the Ansible code of conduct. If you have questions or need assistance, please reach out to our community team at codeofconduct@ansible.com
Get Involved
We welcome your feedback and ideas via the Ansible Forum.
For a full list of all the ways to talk with the Ansible Community, see the AWX Communication guide.