29658 Commits

Author SHA1 Message Date
Alexander Schwartz
2210b1ed50
Avoid un-escaped strings in the login templates for HTML entities
Closes #44296

Signed-off-by: Alexander Schwartz <alexander.schwartz@ibm.com>
2025-11-26 07:55:35 -03:00
Stian Thorgersen
a8d4336da6
Migrate transactions package to new testsuite
Closes #44460

Signed-off-by: stianst <stianst@gmail.com>
2025-11-26 10:57:19 +01:00
Alexander Schwartz
37f2488441
When joining a group, don't rely on cached values if user has already been updated
Closes #44480

Signed-off-by: Alexander Schwartz <alexander.schwartz@ibm.com>
2025-11-26 10:52:14 +01:00
Stian Thorgersen
2acfd41b19
Stop looking up client in ClientAssertionState to prevent lookup by clientId in federated client authentication (#44448)
Closes #44447

Signed-off-by: stianst <stianst@gmail.com>
2025-11-26 06:31:05 +01:00
ruchikajha95
570ac40025
Promote MDC Logging Feature to Supported State
Closes #41205

Signed-off-by: Ruchika Jha <ruchika@li-0551ffcc-341d-11b2-a85c-a28deda416be.ibm.com>
Signed-off-by: Alexander Schwartz <alexander.schwartz@ibm.com>
Co-authored-by: Ruchika Jha <ruchika@li-0551ffcc-341d-11b2-a85c-a28deda416be.ibm.com>
Co-authored-by: Alexander Schwartz <alexander.schwartz@ibm.com>
2025-11-25 18:53:34 +00:00
Weblate (bot)
8a9e585899
Update translation files (#44444)
Updated by "Cleanup translation files" hook in Weblate.

Signed-off-by: Hosted Weblate <hosted@weblate.org>
2025-11-25 18:24:41 +01:00
Giuseppe Graziano
b323fea8bc Always allow to setup JWKS URL in oidc idp
Closes #44217

Signed-off-by: Giuseppe Graziano <g.graziano94@gmail.com>
2025-11-25 17:09:13 +01:00
dawg
d5a507e90d
fix #43819 - partial import fails to overwrite existing groups (#43924)
* fix #43819 - partial import fails to overwrite existing groups

- when removal is delayed until insertion of the newly imported group
  this causes a duplicate key constrain violation (`Key (realm_id, parent_group, name)`)
- fixed by flushing group removals

Signed-off-by: Martin Nowak <code@dawg.eu>

* adding a test and using a general fix

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
# Conflicts:
#	services/src/main/java/org/keycloak/partialimport/PartialImportManager.java

---------

Signed-off-by: Martin Nowak <code@dawg.eu>
Signed-off-by: Steve Hawkins <shawkins@redhat.com>
Co-authored-by: Steve Hawkins <shawkins@redhat.com>
2025-11-25 16:17:51 +01:00
Martin Söderström
b57c0d2f88
Fix race condition in SAML DocumentBuilderFactory creation
Closes #44438

Signed-off-by: martins <martin.soderstrom@aurorainnovation.com>
Signed-off-by: Alexander Schwartz <alexander.schwartz@ibm.com>
Co-authored-by: Alexander Schwartz <alexander.schwartz@ibm.com>
2025-11-25 13:01:42 +00:00
Ryan Emerson
c5427b3e5f
Add debug logging to keycloak_ec2_installer ansible-playbook
Closes #44327

Signed-off-by: Ryan Emerson <remerson@ibm.com>
2025-11-25 13:09:14 +01:00
Stian Thorgersen
63c7cc7381
Delete MetricsRestServiceTest
Closes #44451

Signed-off-by: stianst <stianst@gmail.com>
2025-11-25 12:21:29 +01:00
Thomas Diesler
39264edf3f [OID4VCI] Fix deprecated realm-scoped well-known endpoint access
Signed-off-by: Thomas Diesler <tdiesler@ibm.com>
2025-11-25 12:19:17 +01:00
Ryan Emerson
ebd4a6936a
Utilise community wording in downstream high-availability guides
Closes #4428

Signed-off-by: Ryan Emerson <remerson@ibm.com>
Signed-off-by: Alexander Schwartz <alexander.schwartz@gmx.net>
Co-authored-by: Alexander Schwartz <alexander.schwartz@gmx.net>
2025-11-25 09:10:21 +00:00
rmartinc
5ab371f1ff Use PrivateKey directly when decrypting SAML
Closes #44289

Signed-off-by: rmartinc <rmartinc@redhat.com>
2025-11-25 09:11:05 +01:00
Weblate (bot)
74033d3108
Translations update from Hosted Weblate (#44372)
* Updated translation for Turkish

Language: tr

Update translation files

Updated by "Cleanup translation files" hook in Weblate.

Co-authored-by: Arif EROL <arif.erol16@gmail.com>
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Signed-off-by: Arif EROL <arif.erol16@gmail.com>
Signed-off-by: Hosted Weblate <hosted@weblate.org>

* Update translation files

Updated by "Cleanup translation files" hook in Weblate.

Updated translation for German

Language: de

Updated translation for German

Language: de

Updated translation for German

Language: de

Updated translation for German

Language: de

Updated translation for German

Language: de

Updated translation for German

Language: de

Updated translation for German

Language: de

Co-authored-by: Alexander Schwartz <alexander.schwartz@gmx.net>
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: Till Reymann <till.reymann@gmail.com>
Signed-off-by: Alexander Schwartz <alexander.schwartz@gmx.net>
Signed-off-by: Hosted Weblate <hosted@weblate.org>
Signed-off-by: Till Reymann <till.reymann@gmail.com>

* Update translation files

Updated by "Cleanup translation files" hook in Weblate.

Co-authored-by: Hosted Weblate <hosted@weblate.org>
Signed-off-by: Hosted Weblate <hosted@weblate.org>

* Update translation files

Updated by "Cleanup translation files" hook in Weblate.

Co-authored-by: Hosted Weblate <hosted@weblate.org>
Signed-off-by: Hosted Weblate <hosted@weblate.org>

* Updated translation for Chinese (Traditional Han script)

Language: zh_Hant

Update translation files

Updated by "Cleanup translation files" hook in Weblate.

Updated translation for Chinese (Traditional Han script)

Language: zh_Hant

Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: 秉虎 <s96016641@gmail.com>
Signed-off-by: Hosted Weblate <hosted@weblate.org>
Signed-off-by: 秉虎 <s96016641@gmail.com>

---------

Signed-off-by: Arif EROL <arif.erol16@gmail.com>
Signed-off-by: Hosted Weblate <hosted@weblate.org>
Signed-off-by: Alexander Schwartz <alexander.schwartz@gmx.net>
Signed-off-by: Till Reymann <till.reymann@gmail.com>
Signed-off-by: 秉虎 <s96016641@gmail.com>
Co-authored-by: Arif EROL <arif.erol16@gmail.com>
Co-authored-by: Alexander Schwartz <alexander.schwartz@gmx.net>
Co-authored-by: Till Reymann <till.reymann@gmail.com>
Co-authored-by: 秉虎 <s96016641@gmail.com>
2025-11-24 21:31:50 +00:00
Nagi
1d0806e688
Reorder translation keys for zh_Hans
Reorder the translation keys in zh_Hans messages to keep the key order align
with en messages.

Closes #44440

Signed-off-by: Nagi <nagi@mptree.com>
2025-11-24 21:10:29 +01:00
Pedro Ruivo
f7ee930a27
Remove remote call when handling events)
Closes #44048

Signed-off-by: Pedro Ruivo <1492066+pruivo@users.noreply.github.com>
Signed-off-by: Alexander Schwartz <alexander.schwartz@ibm.com>
Co-authored-by: Pedro Ruivo <1492066+pruivo@users.noreply.github.com>
Co-authored-by: Alexander Schwartz <alexander.schwartz@ibm.com>
2025-11-24 18:45:00 +00:00
rmartinc
ca205272ba Initial integration of the JWT Authorization Grant in client Policies
Using the downscope executor for testing
Closes #44201

Signed-off-by: rmartinc <rmartinc@redhat.com>
2025-11-24 19:37:07 +01:00
Stan Silvert
fc67e54fde Fix NPE
Fixes #44278

Signed-off-by: Stan Silvert <ssilvert@redhat.com>
2025-11-24 16:36:05 +01:00
vramik
0825f22331 Add toPredicate implementation for conditions
Closes #42696

Signed-off-by: vramik <vramik@redhat.com>
2025-11-24 08:56:36 -03:00
mposolda
49b694bf0a Compilation failure in OID4VCTimeNormalizationSdJwtTest
closes #44419

Signed-off-by: mposolda <mposolda@gmail.com>
2025-11-24 08:39:09 -03:00
Awambeng
8406cf34fb
[OID4VCI]: Realm-Configurable Time-Claim Normalization (Randomize/Round) to Mitigate Correlation (#43834)
Closes #43399


Signed-off-by: Awambeng <awambengrodrick@gmail.com>
2025-11-24 11:07:07 +01:00
Pascal Knüppel
64d5e1a3d5
[OID4VCI] Redesign SDJwt API and handle keybinding JWT (#44227)
closes #42091


Signed-off-by: Pascal Knüppel <pascal.knueppel@governikus.de>
Signed-off-by: Captain-P-Goldfish <captain.p.goldfish@gmx.de>
Signed-off-by: mposolda <mposolda@gmail.com>
Co-authored-by: mposolda <mposolda@gmail.com>
2025-11-24 11:01:19 +01:00
Sebastian Łaskawiec
081d8e5a01
Move Kubernetes IdP to preview
Closes #42947

Signed-off-by: Sebastian Łaskawiec <sebastian.laskawiec@defenseunicorns.com>
Signed-off-by: Alexander Schwartz <alexander.schwartz@ibm.com>
Co-authored-by: Alexander Schwartz <alexander.schwartz@ibm.com>
2025-11-22 12:56:09 +01:00
Stian Thorgersen
2a78bc67d7
Refactoring around federated client authenticator to better handling lookup of IdPs and clients. Also, introducing updates to documentation. (#44325)
Closes #44253
Closes #42987
Closes #44063

Signed-off-by: stianst <stianst@gmail.com>
Co-authored-by: Alexander Schwartz <alexander.schwartz@gmx.net>
2025-11-22 12:53:22 +01:00
vramik
091b57c1e4 Flaky test: org.keycloak.testsuite.account.AccountRestServiceTest#listApplicationsWithoutPermission
Closes #43755

Signed-off-by: vramik <vramik@redhat.com>
2025-11-21 15:05:41 -03:00
Steven Hawkins
3b491bc9bf
fix: removing the keycloak hidden option for disabling http server (#44388)
closes: #43199

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
2025-11-21 17:37:52 +00:00
Peter Zaoral
4e5f9acac7
Add CI tests for Azure SQL Database
Closes: #42986

Signed-off-by: Peter Zaoral <pzaoral@redhat.com>
2025-11-21 14:42:28 +00:00
Stian Thorgersen
2c21d1b5c9
Schedule nightly runs to after nightly release (#44381)
Signed-off-by: stianst <stianst@gmail.com>
2025-11-21 13:26:16 +01:00
Alexander Schwartz
bb971dc6fc
Efficient row-count on PostgreSQL
Closes #44057

Signed-off-by: Alexander Schwartz <alexander.schwartz@ibm.com>
2025-11-21 12:28:09 +01:00
Alexander Rasmussen
99aad0741a
Fix logical error in Danish email verification message
Added missing 'ikke' (not) to correctly instruct users to ignore
  the email if they did NOT create the account.

Fixes #44342

Signed-off-by: Alexander Rasmussen <a-m-h-r@hotmail.com>
2025-11-21 10:47:31 +00:00
Weblate (bot)
3d2ae27ae3
Translations update from Hosted Weblate (#44306)
* Updated translation for Turkish

Language: tr

Updated translation for Turkish

Language: tr

Updated translation for Turkish

Language: tr

Co-authored-by: Arif EROL <arif.erol16@gmail.com>
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Signed-off-by: Arif EROL <arif.erol16@gmail.com>
Signed-off-by: Hosted Weblate <hosted@weblate.org>

* Updated translation for German

Language: de

Updated translation for German

Language: de

Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: Till Reymann <till.reymann@gmail.com>
Signed-off-by: Hosted Weblate <hosted@weblate.org>
Signed-off-by: Till Reymann <till.reymann@gmail.com>

* Updated translation for Japanese

Language: ja

Updated translation for Japanese

Language: ja

Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: Kohei Tamura <ktamura.biz.80@gmail.com>
Signed-off-by: Hosted Weblate <hosted@weblate.org>
Signed-off-by: Kohei Tamura <ktamura.biz.80@gmail.com>

* Updated translation for French

Language: fr

Updated translation for French

Language: fr

Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: Sylvain Pichon <service@spichon.fr>
Signed-off-by: Hosted Weblate <hosted@weblate.org>
Signed-off-by: Sylvain Pichon <service@spichon.fr>

* Updated translation for Chinese (Traditional Han script)

Language: zh_Hant

Updated translation for Chinese (Traditional Han script)

Language: zh_Hant

Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: 秉虎 <s96016641@gmail.com>
Signed-off-by: Hosted Weblate <hosted@weblate.org>
Signed-off-by: 秉虎 <s96016641@gmail.com>

* Updated translation for Chinese (Simplified Han script)

Language: zh_Hans

Updated translation for Chinese (Simplified Han script)

Language: zh_Hans

Updated translation for Chinese (Simplified Han script)

Language: zh_Hans

Updated translation for Chinese (Simplified Han script)

Language: zh_Hans

Updated translation for Chinese (Simplified Han script)

Language: zh_Hans

Updated translation for Chinese (Simplified Han script)

Language: zh_Hans

Updated translation for Chinese (Simplified Han script)

Language: zh_Hans

Updated translation for Chinese (Simplified Han script)

Language: zh_Hans

Updated translation for Chinese (Simplified Han script)

Language: zh_Hans

Updated translation for Chinese (Simplified Han script)

Language: zh_Hans

Updated translation for Chinese (Simplified Han script)

Language: zh_Hans

Translated using Weblate (Chinese (Simplified Han script))

Translation: Keycloak/Theme base/admin
Translate-URL: https://hosted.weblate.org/projects/keycloak/theme-baseadmin/zh_Hans/

Translated using Weblate (Chinese (Simplified Han script))

Translation: Keycloak/Theme base/admin
Translate-URL: https://hosted.weblate.org/projects/keycloak/theme-baseadmin/zh_Hans/

Translated using Weblate (Chinese (Simplified Han script))

Translation: Keycloak/Theme base/admin
Translate-URL: https://hosted.weblate.org/projects/keycloak/theme-baseadmin/zh_Hans/

Updated translation for Chinese (Simplified Han script)

Language: zh_Hans

Updated translation for Chinese (Simplified Han script)

Language: zh_Hans

Updated translation for Chinese (Simplified Han script)

Language: zh_Hans

Updated translation for Chinese (Simplified Han script)

Language: zh_Hans

Updated translation for Chinese (Simplified Han script)

Language: zh_Hans

Updated translation for Chinese (Simplified Han script)

Language: zh_Hans

Updated translation for Chinese (Simplified Han script)

Language: zh_Hans

Updated translation for Chinese (Simplified Han script)

Language: zh_Hans

Updated translation for Chinese (Simplified Han script)

Language: zh_Hans

Updated translation for Chinese (Simplified Han script)

Language: zh_Hans

Updated translation for Chinese (Simplified Han script)

Language: zh_Hans

Updated translation for Chinese (Simplified Han script)

Language: zh_Hans

Translated using Weblate (Chinese (Simplified Han script))

Translation: Keycloak/Theme base/admin
Translate-URL: https://hosted.weblate.org/projects/keycloak/theme-baseadmin/zh_Hans/

Co-authored-by: Alexander Schwartz <alexander.schwartz@gmx.net>
Co-authored-by: Charlie <charlie@mapletree.biz>
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: Nagi <nagi@mptree.com>
Signed-off-by: Alexander Schwartz <alexander.schwartz@gmx.net>
Signed-off-by: Charlie <charlie@mapletree.biz>
Signed-off-by: Hosted Weblate <hosted@weblate.org>
Signed-off-by: Nagi <nagi@mptree.com>

---------

Signed-off-by: Arif EROL <arif.erol16@gmail.com>
Signed-off-by: Hosted Weblate <hosted@weblate.org>
Signed-off-by: Till Reymann <till.reymann@gmail.com>
Signed-off-by: Kohei Tamura <ktamura.biz.80@gmail.com>
Signed-off-by: Sylvain Pichon <service@spichon.fr>
Signed-off-by: 秉虎 <s96016641@gmail.com>
Signed-off-by: Alexander Schwartz <alexander.schwartz@gmx.net>
Signed-off-by: Charlie <charlie@mapletree.biz>
Signed-off-by: Nagi <nagi@mptree.com>
Co-authored-by: Arif EROL <arif.erol16@gmail.com>
Co-authored-by: Till Reymann <till.reymann@gmail.com>
Co-authored-by: Kohei Tamura <ktamura.biz.80@gmail.com>
Co-authored-by: Sylvain Pichon <service@spichon.fr>
Co-authored-by: 秉虎 <s96016641@gmail.com>
Co-authored-by: Alexander Schwartz <alexander.schwartz@gmx.net>
Co-authored-by: Charlie <charlie@mapletree.biz>
Co-authored-by: Nagi <nagi@mptree.com>
2025-11-21 09:45:49 +01:00
Pedro Ruivo
2dccc0bf37
Operator Update Logic: add hash based comparison (#44332)
* Operator Update Logic: add hash based comparation

Fixes #44280

Signed-off-by: Pedro Ruivo <1492066+pruivo@users.noreply.github.com>

* refinements to the update logic

Signed-off-by: Steve Hawkins <shawkins@redhat.com>

---------

Signed-off-by: Pedro Ruivo <1492066+pruivo@users.noreply.github.com>
Signed-off-by: Steve Hawkins <shawkins@redhat.com>
Co-authored-by: Pedro Ruivo <1492066+pruivo@users.noreply.github.com>
Co-authored-by: Steve Hawkins <shawkins@redhat.com>
2025-11-20 12:35:38 -05:00
Rahul Jain
61b1e53eee
Bump Quarkus to 3.27.1 LTS (#44348)
Closes #43642
Signed-off-by: Rahul Jain <jainrahul0311@gmail.com>
2025-11-20 15:36:23 +01:00
Martin Bartoš
a71ceee8f1
[Docs] Warn users about printing headers in HTTP access logs (#44353)
Closes #43156

Signed-off-by: Martin Bartoš <mabartos@redhat.com>
2025-11-20 14:48:01 +01:00
Peter Zaoral
0e959ad89e
Delete operation for Client v2 (#44335)
Closes: #43291

Signed-off-by: Peter Zaoral <pzaoral@redhat.com>
2025-11-20 12:12:33 +01:00
ruchikajha95
dc62067cfe
Detailed how to skip test while building keycloak
Closes #44338

Signed-off-by: Ruchika Jha <ruchika@li-0551ffcc-341d-11b2-a85c-a28deda416be.ibm.com>
Signed-off-by: Alexander Schwartz <alexander.schwartz@gmx.net>
Co-authored-by: Ruchika Jha <ruchika@li-0551ffcc-341d-11b2-a85c-a28deda416be.ibm.com>
Co-authored-by: Alexander Schwartz <alexander.schwartz@gmx.net>
2025-11-20 11:29:56 +01:00
Steven Hawkins
8ae3750348
fix: switching to Boolean instead of boolean (#44340)
closes: #38843

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
2025-11-20 08:53:28 +01:00
schnillerman
4e87b1f5a0
Fix grammar in LDAP federation group mapper
Closes #44341

Signed-off-by: schnillerman <till.reymann@gmail.com>
2025-11-19 23:11:24 +00:00
Pedro Ruivo
13ef89664c
More accurate user session expiration logic
Closes #44204

Signed-off-by: Pedro Ruivo <1492066+pruivo@users.noreply.github.com>
Co-authored-by: Pedro Ruivo <1492066+pruivo@users.noreply.github.com>
2025-11-19 21:06:17 +01:00
Stian Thorgersen
271fdfcf0f
Restore KeycloakServerConfigBuilder to use single --features and --features-disabled arguments (#44322)
Signed-off-by: stianst <stianst@gmail.com>
2025-11-19 20:45:06 +01:00
Stian Thorgersen
c089a3a6fe
Add support to use kcw with remote test server
Closes #44312

Signed-off-by: stianst <stianst@gmail.com>
2025-11-19 20:43:42 +01:00
Carlos Rodríguez Hernández
2a876c143f
Add support for PostgreSQL 18 (#44288)
Signed-off-by: Carlos Rodríguez Hernández <carlos.rodriguez-hernandez@broadcom.com>
2025-11-19 11:39:36 +01:00
Giuseppe Graziano
3e8b2f8ab7
New JWT Authorization Grant Identity provider (#44176)
Closes #43570

Signed-off-by: Giuseppe Graziano <g.graziano94@gmail.com>
2025-11-19 09:18:23 +01:00
Steven Hawkins
731414e44a
fix: reverting dev property key changes (#44293)
closes: #44287

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
2025-11-19 07:35:50 +01:00
Pedro Ruivo
febb632e17
Update protolock file list
Closes #44300

Signed-off-by: Pedro Ruivo <1492066+pruivo@users.noreply.github.com>
Co-authored-by: Pedro Ruivo <1492066+pruivo@users.noreply.github.com>
2025-11-18 18:01:12 +00:00
Weblate (bot)
55091f977f
Translations update from Hosted Weblate (#44226)
* Updated translation for Turkish

Language: tr

Co-authored-by: Arif EROL <arif.erol16@gmail.com>
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Signed-off-by: Arif EROL <arif.erol16@gmail.com>
Signed-off-by: Hosted Weblate <hosted@weblate.org>

* Updated translation for Czech

Language: cs

Updated translation for Czech

Language: cs

Updated translation for Czech

Language: cs

Updated translation for Czech

Language: cs

Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: Martin Kluska <martin@kluska.cz>
Signed-off-by: Hosted Weblate <hosted@weblate.org>
Signed-off-by: Martin Kluska <martin@kluska.cz>

* Updated translation for Chinese (Traditional Han script)

Language: zh_Hant

Updated translation for Chinese (Traditional Han script)

Language: zh_Hant

Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: 秉虎 <s96016641@gmail.com>
Signed-off-by: Hosted Weblate <hosted@weblate.org>
Signed-off-by: 秉虎 <s96016641@gmail.com>

---------

Signed-off-by: Arif EROL <arif.erol16@gmail.com>
Signed-off-by: Hosted Weblate <hosted@weblate.org>
Signed-off-by: Martin Kluska <martin@kluska.cz>
Signed-off-by: 秉虎 <s96016641@gmail.com>
Co-authored-by: Arif EROL <arif.erol16@gmail.com>
Co-authored-by: Martin Kluska <martin@kluska.cz>
Co-authored-by: 秉虎 <s96016641@gmail.com>
2025-11-18 18:35:21 +01:00
Jon Koops
f7e4b78f1d Prevent slash duplication in request URLs
Closes #44269

Signed-off-by: Jon Koops <jonkoops@gmail.com>
2025-11-18 15:44:40 +01:00
mposolda
68cfb8d720 Fix flaky test ClientAuthSignedJWTTest.testClientWithGeneratedKeysJKS
closes #43713

Signed-off-by: mposolda <mposolda@gmail.com>
2025-11-18 11:52:01 +01:00
Awambeng Rodrick
97ae31dfe3 fix(admin-ui): allow assignment of OID4VCI client scopes to clients
Closes #43899

Signed-off-by: Awambeng Rodrick <awambengrodrick@gmail.com>

Address @forkimenjeckayang review comments

Signed-off-by: Awambeng Rodrick <awambengrodrick@gmail.com>

Address @IngridPuppet review comments

Signed-off-by: Awambeng Rodrick <awambengrodrick@gmail.com>

Address @IngridPuppet review comments

Signed-off-by: Awambeng Rodrick <awambengrodrick@gmail.com>

fix lint error

Signed-off-by: Awambeng Rodrick <awambengrodrick@gmail.com>
2025-11-18 11:25:23 +01:00