fix a bug in multi-LDAP authentication

see: https://github.com/ansible/tower/issues/2738
This commit is contained in:
Ryan Petrello 2018-08-01 17:36:55 -04:00
parent c09a23f063
commit 2102c1ef0a
No known key found for this signature in database
GPG Key ID: F2AA5F2122351777

View File

@ -110,12 +110,13 @@ class LDAPBackend(BaseLDAPBackend):
pass
try:
user = super(LDAPBackend, self).authenticate(username, password)
try:
user.ldap_user._get_groups().get_group_dns()
except ImproperlyConfigured:
logger.exception(_("Encountered an error populating user {} from LDAP").format(user.username))
user.delete()
raise
if user and getattr(user, 'ldap_user', None):
try:
user.ldap_user._get_groups().get_group_dns()
except ImproperlyConfigured:
logger.exception(_("Encountered an error populating user {} from LDAP").format(user.username))
user.delete()
raise
return user
except Exception:
logger.exception("Encountered an error authenticating to LDAP")