Commit Graph
100 Commits
Author SHA1 Message Date
Chris Houseknecht 0cfa818245 Form Generation
Add ID attribute to elements containing field validation error text: https://trello.com/c/VzfY24y7/116-ui-automation-no-dom-id-for-form-field-errors
2014-08-27 10:41:11 -04:00
Chris Houseknecht 5facdb221b Support MacBook Pro 13" Display
Removed 'funky wrapping' from project page on wee little viewports: https://trello.com/c/FVie0qm7/43-funky-wrapping-throughout-macbook-pro-13-retina-chrome
2014-08-26 15:15:17 -04:00
Chris Houseknecht fe88623550 Schedules
Since we don't display schedule.id anywhere, there's probably no need to provide a filter for it.
2014-08-26 15:04:15 -04:00
Chris Houseknecht 973695e6d8 Jobs page
Filter schedules by job type. https://trello.com/c/cw57g3Vw/45-jobs-tab-scheduled-jobs-do-not-allow-filtering-by-type
2014-08-26 12:15:37 -04:00
Chris Houseknecht a6252e4ed2 Jobs tab
Add job status back into filter options for completed jobs. Added to jobs tab, dashboard and job template page.
https://trello.com/c/dOqMitNv/38-jobs-tab-can-t-view-only-successful-jobs
2014-08-26 10:57:49 -04:00
Chris Houseknecht fa9c6b0171 Remove help link from tab order
Fixed: https://trello.com/c/JbtD7aQP/33-tabing-between-dialog-on-forms-will-select-the-help-elements
2014-08-26 10:40:21 -04:00
Chris Houseknecht 920011dd01 Job Stdout
Fixed https://trello.com/c/lnsjMHax/98-incorrect-use-of-bold-on-job-stdout-breadcrumb
2014-08-25 16:14:34 -04:00
Chris Houseknecht e5cf444c17 Event Viewer Dialog
Fixed: https://trello.com/c/GlHhfp7Y/95-job-event-for-win-feature-module-isn-t-displayed-correctly. Prevents 'feature_result' from appearing on the Results tab. It is now only visible on the JSON tab.
2014-08-25 14:21:20 -04:00
Chris Houseknecht 0766bc302b Fixed js lint error 2014-08-19 16:14:44 -04:00
Chris Houseknecht bec9cc73cd Job detail page
Fix for https://trello.com/c/uGFQjYn0/323-host-event-order-differs-between-host-events-list-and-host-event-dialog
2014-08-19 16:10:24 -04:00
Chris Houseknecht 186ab7814f Job detail page
Fix for https://trello.com/c/WZ18zIqG/337-completed-job-detail-statistics-differ-between-realtime-and-page-refresh
2014-08-19 13:17:11 -04:00
Chris Houseknecht e605a89a80 Job detail page
Fixed Host Events sort to always sort by ascending host name, matching the event viewer dialog. https://trello.com/c/uGFQjYn0/323-host-event-order-differs-between-host-events-list-and-host-event-dialog
2014-08-19 12:56:17 -04:00
Chris Houseknecht aa61a491d0 Login
Attempted fix for https://trello.com/c/dcu8BoSa/307-401-error-on-login
2014-08-19 11:08:38 -04:00
Chris Houseknecht 66e26cfa1d Job detail page
Fixed mistyped variable name
2014-08-18 16:45:20 -04:00
Chris Houseknecht 6d44bdd5c7 Job Detail Page
Additional fix for https://trello.com/c/WZ18zIqG/337-completed-job-detail-statistics-differ-between-realtime-and-page-refresh
2014-08-18 15:57:06 -04:00
Chris Houseknecht ccc947afdf Job detail page
Fix for https://trello.com/c/WZ18zIqG/337-completed-job-detail-statistics-differ-between-realtime-and-page-refresh
2014-08-18 14:38:25 -04:00
Chris Houseknecht 4a9ce25dff Job detail page
Fixed https://trello.com/c/3AIlW5Hy/335-elapsed-time-disappears-when-job-is-completed
2014-08-18 13:24:57 -04:00
Chris Houseknecht caff0572a5 Search
Fixed ?& and mishandling of 'in' search type. Trello: https://trello.com/c/qrkTCicN/316-update-inventory-source-types-in-home-groups
2014-08-18 11:26:03 -04:00
Chris Houseknecht f4cce01af0 Job detail event viewer
Fixed https://trello.com/c/uGFQjYn0/323-host-event-order-differs-between-host-events-list-and-host-event-dialog. Not sure why the event viewer sort was by ID rather than host_name. The reason might be that up until about 3 weeks ago the host_name could be empty, if a host was deleted.
2014-08-18 10:41:14 -04:00
Chris Houseknecht 15c5247f90 Job detail page
Fixed https://trello.com/c/dKA4UU0U/308-if-a-job-products-no-plays-tasks-or-job-host-summaries-the-corresponding-page-sections-say-loading
2014-08-16 03:56:56 -04:00
Chris Houseknecht 36dfd780bb Job detail page
Fixed https://trello.com/c/dKA4UU0U/308-if-a-job-products-no-plays-tasks-or-job-host-summaries-the-corresponding-page-sections-say-loading
2014-08-16 03:47:38 -04:00
Chris Houseknecht c763302c06 Inventory edit dialog
Fixed https://trello.com/c/id6ngxh4/314-odd-wording-on-tower-2-0-dev201408141545-inventory-group-source-overwrite
2014-08-16 03:13:47 -04:00
Chris Houseknecht 92f813aa55 License
Fixed https://trello.com/c/ya3zFzDX/277-slightly-goofy-looking-nested-scrolling-in-view-license-widget
2014-08-16 03:03:04 -04:00
Chris Houseknecht b9c17df31b Fixed JS lint errors. 2014-08-16 02:54:52 -04:00
Chris Houseknecht e83150f6e1 Projects
Fixed https://trello.com/c/qJ1vWQeQ/317-project-sync-icon-enabled-while-project-update-inprogress
Project update status was not reflected correctly. Issue was PostRefresh not handling success/failed status correctly.
2014-08-16 02:52:11 -04:00
Chris Houseknecht 8c7c81bebc Fixed JS lint errors. 2014-08-16 00:46:28 -04:00
Chris Houseknecht 5a5398664a Jobs page
Fix for https://trello.com/c/tWDz8Jd7/320-js-failure-when-attempting-to-delete-a-queued-job. Plus cleaned up the prompting around job delete. Job delete and cancel should behave the same except for the request method sent to the API. Also, removed 'On' from date titles to help keep the tiles from breaking as the viewport shrinks.
2014-08-16 00:39:07 -04:00
Chris Houseknecht 5bc8255d8f Job detail page
Fixed https://trello.com/c/JW7zmAsD/312-job-detail-duplicate-tasks-listed-when-double-clicking-a-play
2014-08-15 23:02:47 -04:00
Chris Houseknecht e25778d0ed Permissions
Fixed missing help text: https://trello.com/c/Lt3HCHkb/319-unknown-permissions-box-when-adding-user-team-permissions
2014-08-15 16:57:41 -04:00
Chris Houseknecht ceeea4d527 License
Changes for https://trello.com/c/gl5PegTL/253-update-license-nags-based-on-marketing-feedback and
https://docs.google.com/a/ansible.com/document/d/1bvcfoV8j5z0OB7ZQsDwYY1WB58odnchp9vCic2F__eo/edit?pli=1
2014-08-15 16:32:38 -04:00
Chris Houseknecht d869f82dc2 Login dialog
If the attempt to get the license ('/api/v1/config') or user info ('/api/v1/me') fails, force user back to the login page. Additionally, call Authorization.logout() to make sure any residual token or user info is cleared.

Tweaked the login HTML so that ng-show on the login dialog header message will cause the message to show when the sessionExpired variable is null or undefined.
2014-08-15 14:10:33 -04:00
Chris Houseknecht c80b07143b Fixed JS lint errors. 2014-08-14 15:18:47 -04:00
Chris Houseknecht 038a1cfb95 Job detail page
Fixed https://trello.com/c/bfSOKm8x/281-on-job-details-page-when-one-task-completely-fails-the-next-task-shows-up-with-a-green-light-beside-it
2014-08-14 14:36:42 -04:00
Chris Houseknecht e8832672db Job detail page
Fixed https://trello.com/c/H4O8aLeG/294-host-summary-includes-delete-host-where-it-could-display-host-name
2014-08-14 13:24:50 -04:00
Chris Houseknecht f134de0be3 Job detail page
Fixed https://trello.com/c/lRz0fKuM/293-play-missing-from-job-detail-page
Now a play with no tasks and no matching hosts appears during live events and after the job finishes and page is reloaded from the API.
2014-08-14 13:13:00 -04:00
Chris Houseknecht da029bb274 Job detail page
Fix for https://trello.com/c/lRz0fKuM/293-play-missing-from-job-detail-page
2014-08-14 11:18:48 -04:00
Chris Houseknecht d445b29ae9 Job detail page
Included the fa-external-link icon in the View stdout for more detail link in support of the garbled playbook.
2014-08-13 19:19:08 -04:00
Chris Houseknecht adbe2d182f Job detail page
Added support for the garbled playbook: https://trello.com/c/UA2oIdhd/284-needs-to-be-a-better-indication-when-a-play-is-failed-due-to-syntax-issue-without-events
2014-08-13 19:16:37 -04:00
Chris Houseknecht 8f7d2fd78b Fixed JS lint errors. 2014-08-13 18:41:25 -04:00
Chris Houseknecht b54f9066b9 Job Detail Page
Changed to match new graph spec: https://trello.com/c/4xDbmXXW/285-pi-chart-mathematics-does-not-show-of-hosts-with-activity-x
2014-08-13 18:28:48 -04:00
Chris Houseknecht 14aa9e4004 Job details
https://trello.com/c/i4MeikiL/266-unable-to-select-play-after-job-completes

When play button clicked to resume live event processing an additional draw loop (setInterval) was being started. Multiple draw loops might be running at the end of the job, and only the most one was gettings stopped. The others kept running. User would click a play, the screen would be repainted one or more times by the remaining draw loops, seleting the first play and irst task in the list regardless of the user selection. Fixed by always checking for and killing the current draw loop before starting a new one.
2014-08-13 16:33:14 -04:00
Chris Houseknecht 41a0f786ed Eventviewer
Not displaying results for 'unreachable-host-X' events under Summary section. Issue was that event_data.res returned from the API as a string rather than an object. The UI expected an object.
2014-08-13 12:58:24 -04:00
Chris Houseknecht b13008421b License
Fixed text typos. Fixed title for missing license.
2014-08-13 11:28:01 -04:00
Chris Houseknecht 23257f1217 Help for selecting from a list
Help text for projects, users and credentials was referring to a 'Create New' button. It now references the '+' button. Also, added the footer message 'esc or click to close'.
2014-08-13 10:38:39 -04:00
Chris Houseknecht 2e39e093af Security- Login
Fixed login modal issue where logging out and immediately clicking Sign In button without entering username/password would log back in as prior user.
2014-08-13 09:22:21 -04:00
Chris Houseknecht 25a49b0198 License
Updated license text per https://docs.google.com/a/ansible.com/document/d/1bvcfoV8j5z0OB7ZQsDwYY1WB58odnchp9vCic2F__eo
2014-08-12 13:32:12 -04:00
Chris Houseknecht aac6cc6a5a Login dialog
Added keycode 13 to the kedown bind for Alert dialogs.
2014-08-12 10:25:20 -04:00
Chris Houseknecht c8bf994eb4 E2E tests
Starting to get protractor to work
2014-08-11 17:10:05 -04:00
Chris Houseknecht 83f724bd19 Fixed jshint error 2014-08-11 16:47:13 -04:00
Chris Houseknecht 50382890e5 Job detail
Removed empty value from the status drop-down on the host event viewer. Selecting the empty value caused a second empty value to appear. All empty values now gone. User can only choose valid status options. Default choice is All.
2014-08-11 15:58:57 -04:00
Chris Houseknecht 299908bfe0 About dialog
Made cow centered on small viewport. Added resizable option to Modal module. The About dialog is no longer resizable.
2014-08-11 10:57:00 -04:00
Chris Houseknecht 7d6cf7e2d0 Breadcrumbs
When adding an organization to a project breadcrumbs did not appear. Fixed.
2014-08-11 10:21:31 -04:00
Chris Houseknecht 5de05aaa4c Job detail page
'Loading' message was not switching to 'No matching hosts' when completed search returns no results.
2014-08-08 16:44:17 -04:00
Chris Houseknecht 1f5f45a162 License
Updated language changes. Dropping mention of 'grace period' when trial flag set. Showing existing license JSON in the license text field when appropriate. Updated unit tests.
2014-08-08 14:40:40 -04:00
Chris Houseknecht 0db0972eb1 License
Started making language revisions per 8/7 status meeting notes.
2014-08-07 18:02:18 -04:00
Chris Houseknecht b9b52f49fc Unit Testing
Looking at protractor as a possible option. It does end-to-end testing, which may be redundant with QA's work, but it may also be exactly what's needed.
2014-08-07 17:20:40 -04:00
Chris Houseknecht 91df59611d License
30 day trial modifiations. Refactored Access helper and created a new License helper. Removed ansible/License module. Created a new license viewer that allows admin user to update the license key. Nag message at login now differentiates between admin and non-admin user.
2014-08-05 17:15:30 -04:00
Chris Houseknecht 9799e81f09 UI Unit Testing
Added plumbing for Karma test runner. Wrote first few tests for new license module.
2014-08-05 02:43:30 -04:00
Chris Houseknecht 07b9f6b12c License
Changed license nagging to a modal dialog with license status aware text and a form for updating the license key. Form provides JSON validation via CodeMirror.
2014-08-04 18:09:26 -04:00
Chris Houseknecht d3cd99bdfc Min pagination size
Tweaked job page to make the minimum aware of taller rows as the width of the viewport shrinks.
2014-07-31 16:06:39 -04:00
Chris Houseknecht 4138a152c4 Websocket help dialogs
Fixed typo in Safari help text.
2014-07-31 15:37:45 -04:00
Chris Houseknecht 9270eb9049 Inventory breadcrumb
Inventory name is now clickable, navigating back to the top of the tree. 'All' has been removed.
2014-07-31 14:45:43 -04:00
Chris Houseknecht bebdcde93b File drag-n-drop
Set validity of 'required' to true and field status to dirty upon successful read of file, otherwise the Save button is never enabled.
2014-07-31 14:04:50 -04:00
Chris Houseknecht f7ed4eceb3 Fixed JS lint error. 2014-07-31 13:00:22 -04:00
Chris Houseknecht 21bd8d63e3 Minimum page sizes
Set minimum page sizing heights and row counts on inventory detail and jobs. On both pages we calculate container heights and page row counts based on the viewport width and height.
2014-07-31 12:25:29 -04:00
Chris Houseknecht 0a44de3346 hintText form option
Add hintText:"some helpful text here" to a field in a form definition object. Form generator will display the text inside the <label> element on a new line with the fa-info-circle icon in a pleasant grey color.
2014-07-30 18:35:31 -04:00
Chris Houseknecht 5c7152dec1 File drag-n-drop
Added an onerror handler to the FileReader. If the file cannot be read for some reason, throw an alert dialog letting user know things went wrong.
2014-07-30 18:13:55 -04:00
Chris Houseknecht ca607f2372 Drag-n-drop directive
Add aw-drop-file directive to a textarea form element. User can drop a file (any file) onto the field and the contents as text will be placed in the textarea. Added this directive to credentials ssh_key field.
2014-07-30 18:08:38 -04:00
Chris Houseknecht 10d0fa7631 Socket connection help
Revised help text, adding status icons. Added clear overlay under the modal dialog. Rotated the network icon left by 45 deg.
2014-07-30 17:07:56 -04:00
Chris Houseknecht 7093e95011 Form-generator
Change handling of labelBind in form generator. It now adds ng-bind directive to a <span> element inside <label> rather than to <label> directly. This stops Angular from wiping out anything else we may want to add inside <label> like help icon.
2014-07-30 16:30:49 -04:00
Chris Houseknecht 6156e3c456 Credentials
Fixed form validation issues when adding a cloud credential. The email address field was being required even though it wasn't visible.
2014-07-30 16:07:34 -04:00
Chris Houseknecht cef468d060 Inventory help
Tweaked the verbage and image sizes a bit.
2014-07-30 14:33:09 -04:00
Chris Houseknecht 2485f86471 Job templates
Added ability to launch a job from th job template detail page.
2014-07-30 14:06:31 -04:00
Chris Houseknecht 6fb89530cc Job events viewer
Made sure stdout, stderr and traceback don't end up on Results tab. Each of these already has a dedicated tab.
2014-07-29 16:57:36 -04:00
Chris Houseknecht 5b6d8e5c98 Job detail page
Added 'Loading...' message to each table. Loading message is turned on at initial page load. It is turned off at the last possible second after completion of page rendering. It is turned on before each API call and back off after the API call completes.
2014-07-29 16:41:44 -04:00
Chris Houseknecht a960638b68 Lookup dialog
Fixed Select column so that it always appears all the way to the right and is always the same width. Looks much better :)
2014-07-29 15:17:59 -04:00
Chris Houseknecht a2ddeb1f22 Event viewer
Fixed issue that occurred while launching event viewer from host event viewer. For a given host event on the host event viewer dialog, click the status link. The event viewer dialog failed to appear if there was only a single event.
2014-07-29 14:52:57 -04:00
Chris Houseknecht 74fa71b3f4 Event viewer
Show more data on the Results tab. Any items not explicitly listed in the event viewer form object are now added to the Results tab, excluding ansible_facts. Also added a JSON tab to show the full event object, again excluding ansible_facts.
2014-07-29 13:17:42 -05:00
Chris Houseknecht 945e6d468f Websocket Help
Show browser aware help for troubleshooting web socket connection problems.
2014-07-29 13:17:42 -05:00
Chris Houseknecht e8a4aadb44 Site footer
Added a 15px margin to bottom of site layout. Fixed inventory detail page auto sizing. It had not been updated with all the layout changes.
2014-07-29 13:17:41 -05:00
Chris Houseknecht 5dd0ae14e4 Pagination
Changed collection name in pagination widget to '(X items)'.
2014-07-29 13:17:41 -05:00
Chris Houseknecht a03309b52a Inventory hosts search
Removed used of dynamic placeholder. Left over from prior iterations.
2014-07-29 13:17:41 -05:00
Chris Houseknecht e137ec7383 local_config
Load what's in local storage, if anything, while waiting for external file to load.
2014-07-29 13:17:41 -05:00
Chris Houseknecht e7e52f3bf7 local_config
Fixed remaining fallout from delay of $AnsibleConfig object.
2014-07-29 13:17:41 -05:00
Chris Houseknecht 9f2e398e69 Event viewer
Show more data on the Results tab. Any items not explicitly listed in the event viewer form object are now added to the Results tab, excluding ansible_facts. Also added a JSON tab to show the full event object, again excluding ansible_facts.
2014-07-29 14:08:28 -04:00
Chris Houseknecht ccf974ed83 Websocket Help
Show browser aware help for troubleshooting web socket connection problems.
2014-07-28 17:00:05 -04:00
Chris Houseknecht 76d6097af7 Site footer
Added a 15px margin to bottom of site layout. Fixed inventory detail page auto sizing. It had not been updated with all the layout changes.
2014-07-25 16:46:21 -04:00
Chris Houseknecht d2435884af Pagination
Changed collection name in pagination widget to '(X items)'.
2014-07-25 16:02:14 -04:00
Chris Houseknecht fd98f96b3e Inventory hosts search
Removed used of dynamic placeholder. Left over from prior iterations.
2014-07-25 15:51:13 -04:00
Chris Houseknecht 5fb27ff9c3 local_config
Load what's in local storage, if anything, while waiting for external file to load.
2014-07-25 15:38:39 -04:00
Chris Houseknecht b3c41c01b8 local_config
Fixed remaining fallout from delay of $AnsibleConfig object.
2014-07-25 15:29:31 -04:00
Chris Houseknecht f8d70f03ea local_settings
Fixed more bits where undefined $AnsibleConfig was breaking things.
2014-07-25 14:16:15 -04:00
Chris Houseknecht 7139b5b25a loca_config
Fixed lingering issues where $AnsibleConfig is referenced when it is not yet defined.
2014-07-25 14:00:18 -04:00
Chris Houseknecht 89f65d8ba0 local_config
Fixed javascript error.
2014-07-25 10:45:12 -04:00
Chris Houseknecht 623ac5804e local_config
Don't start the app until the config file is loaded and $AnsibleConfig is defined.
2014-07-25 10:43:05 -04:00
Chris Houseknecht d872aa1985 local_config.js
Look for local_config.js. If not found, load config.js. Set debug_mode to true and make other config changes locally without affecting production builds.
2014-07-25 10:25:37 -04:00
Chris Houseknecht f0cb84d973 Job detail
Monitor socket connection and attempt to restart when status returns 'error' or continuously returns 'connecting'.
2014-07-25 10:24:15 -04:00
Chris Houseknecht 9af5cc3d6d Job details -play button
Pause live events by clicking on a task or play. Restart live events by clicking the play button. Fixed issues with event viewer and host viewer dialogs.
2014-07-24 20:50:38 -04:00
Chris Houseknecht 074b882714 Authorization
Fixed js error. Confirmed that setting Authorization header to '' on calls to /api and /api/v1 works. Switched debug_mode to false for the demo.
2014-07-23 15:04:30 -04:00
Chris Houseknecht 66851bd28f Authentication
Attempt to remove the Authentication: Basic header by nulling it out on request to /api and /api/v1
2014-07-23 14:35:53 -04:00