Commit Graph
81 Commits
Author SHA1 Message Date
kialam 1cb2a95a47 Merge pull request #137 from ansible/document-naming-functions
Update contributing doc
2019-03-21 14:26:12 -04:00
Kia Lam e3a6a20049 Update contributing doc to include:
- Method naming convention
- Initial Empty State convention
2019-03-21 12:51:23 -04:00
kialam dbeef0a823 Merge pull request #123 from ansible/access-list-remove-role-functionality
Org Access List: add remove role functionality
2019-03-18 10:25:56 -04:00
Kia Lam a4493cd02b Add empty initial states and adjust rendering logic. 2019-03-18 09:32:11 -04:00
Kia Lam a5683fb354 Clear mocked methods after each test to prevent overlaps with other tests. 2019-03-14 10:41:28 -04:00
Kia Lam 518ecee53e Apply padding to Alert component. 2019-03-14 10:35:54 -04:00
Kia Lam 6bd5ee4201 Move test for AccessList. 2019-03-13 17:12:16 -04:00
Kia Lam 390832cc1a Rename AccessList to OrganizationAccessList and fix paths. 2019-03-13 16:46:50 -04:00
Kia Lam c6d810621f Move AccessList out of components directory.
- The AccessList component is pretty specific to the Organization component, and given the structure and methods within it, is pretty context-specific and not a good candidate to be a re-useable component.
2019-03-13 16:37:03 -04:00
Kia Lam 0495214f47 Address PR feedback. 2019-03-13 15:59:42 -04:00
Kia Lam 21156d1409 Merge remote-tracking branch 'origin' into access-list-remove-role-functionality 2019-03-13 15:43:30 -04:00
Kia Lam 198dfe7f2e Add unit test to check state when user tries to delete a role. 2019-03-13 14:44:12 -04:00
Kia Lam 3b65068258 Add remove role functionality. 2019-03-08 13:56:27 -05:00
kialam e935776067 Merge pull request #121 from ansible/org-access-list
Organization Access List
2019-03-05 18:56:29 -05:00
Kia Lam 9f86fc2def Respond to PR feedback. 2019-03-05 12:01:06 -05:00
Kia Lam 35ecd83214 Some cosmetic changes.
- Reverse order of Expand/Compact icons in DataListToolbar to Compact/Expand.
- Make Expanded the default view for Access Lists.
- Make role badge styling closer to Chip component styling.
2019-03-04 14:38:58 -05:00
Kia Lam 86a92fefe7 Merge remote-tracking branch 'origin' into org-access-list 2019-03-01 10:37:44 -05:00
Kia Lam bf7e6201a2 Refactor Access List.
- Derive Team Roles without making extra API call.
- Consistent variable naming convention use camelCase.
- More informative error display.
2019-03-01 10:12:36 -05:00
Kia Lam a3a80bc23e Fix prop errors in unit tests. 2019-02-27 18:03:15 -05:00
Kia Lam 5659270d3e Add unit test for Access List component. 2019-02-27 17:30:02 -05:00
Kia Lam 1443625d89 Abstract out Access List as shared component. 2019-02-26 13:23:34 -05:00
Kia Lam 3cd54c45eb Add Access List to Orgs. 2019-02-26 08:39:13 -05:00
kialam e0df011804 Merge pull request #109 from ansible/add-prop-checking
Add proptypes to shared components
2019-02-19 11:37:03 -05:00
kialam f9d615fdee Fix unit tests. 2019-02-19 11:28:17 -05:00
kialam da8c3f6c43 Enable submit button by default. 2019-02-19 10:24:26 -05:00
kialam c3493b0539 Remove unused method. 2019-02-19 10:19:47 -05:00
kialam bba1c4f5b6 Restore FormGroup to parent Add Org component for AnsibleSelect. 2019-02-19 10:18:03 -05:00
kialam 2a254ea538 Add typechecking to contributing guide. 2019-02-15 15:20:02 -05:00
kialam b340d49cb7 Integrate proptypes for our shared components.
- Fix unit tests.
- Fix linter errors.
2019-02-15 15:08:52 -05:00
kialam 91f87b6d81 Merge pull request #106 from ansible/add-select-default-option
Add default option for AnsibleSelect dropdown.
2019-02-14 11:00:04 -05:00
kialam 7c009fc315 Update unit tests to use new props. 2019-02-14 10:53:53 -05:00
kialam f09eb182c2 Merge remote-tracking branch 'origin/master' into add-select-default-option 2019-02-14 10:38:28 -05:00
kialam 1f07fc8494 Make default option selectable but return null value. 2019-02-13 15:39:29 -05:00
kialam 2b18cee9c0 Fix linter errors and add test to AnsibleSelect component. 2019-02-13 15:39:29 -05:00
kialam 97477b789a Add default option for AnsibleSelect dropdown. 2019-02-13 15:39:26 -05:00
kialam 3060abab1d Merge pull request #87 from ansible/lookup-form-component
Lookup form component
2019-01-16 13:32:28 -05:00
kialam a70a0fa622 Bump Lookup component test coverage up. 2019-01-16 13:15:51 -05:00
kialam 7230b4bf8d Bump up unit test coverage for OrganizationAdd component. 2019-01-15 15:51:37 -05:00
kialam fc32cf026f Address review feedback. 2019-01-15 15:15:17 -05:00
kialam e8fe6fe33c Fix & Add unit tests. 2019-01-15 14:58:23 -05:00
kialam 215c23609c Hook up 'x' remove button; rename ListItem component. 2019-01-14 09:45:49 -05:00
kialam c5cd659c83 Redirect user to org detail page after successful POST. 2019-01-08 16:09:30 -05:00
kialam a1d1dc7a24 Style pop up modal 2019-01-08 15:56:37 -05:00
kialam c085fc6751 Merge remote-tracking branch 'origin/master' into lookup-form-component 2019-01-08 13:47:06 -05:00
kialam 395e30509b Fix linter and existing unit tests. 2019-01-07 17:17:22 -05:00
kialam 517ef8a2c9 Hook up add instance group functionality. 2019-01-07 16:56:39 -05:00
kialam f34ec4be10 Merge remote-tracking branch 'origin/master' into lookup-form-component 2019-01-07 14:40:35 -05:00
kialam c63896fbb6 Implement basic lookup modal component. 2019-01-07 10:09:35 -06:00
kialam e8924e8f6f Fix linter errors. 2019-01-03 15:20:46 -05:00
kialam e77d81dd5b Lift config context one level higher.
- Refactor About component to use config context.
- Update About component unit tests.
2019-01-03 15:20:41 -05:00
kialam a217a387c6 Use new lifecycle method to update component state.
- Use component state to handle rendering of Ansible Select dropdown based on the number of custom virtualenvs the API returns.
2019-01-03 15:20:35 -05:00
kialam 13680a436c Add unit tests for recent changes to App.jsx. 2019-01-03 15:20:30 -05:00
kialam 6c307726db Use setState instead of sessionStorage for config data. 2019-01-03 15:20:23 -05:00
kialam 9bc87b3e80 Implement React Context API
- Move API GET request to /v2/config out to the top level of our App.
- Store /v2/config response data in sessionStorage.
- Use Context API to pass down relevant data to Organizations component.
- Wrap our AnsibleSelect component as a context consumer and pass in the list of Ansible Environments of the logged in user.
- Clear sessionStorage object when user logs out.
- Update unit tests.
2019-01-03 15:20:08 -05:00
kialam fefbb8fff8 Fix linter errors. 2019-01-02 09:19:11 -07:00
kialam f5119e5d97 Lift config context one level higher.
- Refactor About component to use config context.
- Update About component unit tests.
2019-01-02 09:03:48 -07:00
kialam 5fcdd16f54 Use new lifecycle method to update component state.
- Use component state to handle rendering of Ansible Select dropdown based on the number of custom virtualenvs the API returns.
2018-12-22 09:03:44 -05:00
kialam e30b198418 Remove duplicate REST call in add org component. 2018-12-21 11:56:39 -05:00
kialam aaa9096b4e Add unit tests for recent changes to App.jsx. 2018-12-21 10:25:17 -05:00
kialam 4eb04b6f5c Use setState instead of sessionStorage for config data. 2018-12-21 10:20:07 -05:00
kialam 6dc11a926e Merge remote-tracking branch 'origin/master' into react-context-api 2018-12-21 10:16:50 -05:00
kialam fe857ad68b Merge remote-tracking branch 'origin/master' into react-context-api 2018-12-18 10:52:09 -05:00
kialam fd513f704b Add a contributing doc to our repo. 2018-12-18 10:30:48 -05:00
kialam 46e9fcfda7 Merge pull request #53 from ansible/add-org-new
Basic Add Organization View
2018-12-17 17:14:05 -05:00
kialam ff0015e21d Hook up Cancel button
- Update unit tests.
- Add basic error handling for API requests in Add Orgs component.
2018-12-17 13:44:59 -05:00
kialam 656e6d4f6a Add back missing style. 2018-12-17 12:39:41 -05:00
kialam b3b6e0515e Merge remote-tracking branch 'origin/add-org-new' into react-context-api 2018-12-17 11:59:46 -05:00
kialam b8fc402d55 Implement React Context API
- Move API GET request to /v2/config out to the top level of our App.
- Store /v2/config response data in sessionStorage.
- Use Context API to pass down relevant data to Organizations component.
- Wrap our AnsibleSelect component as a context consumer and pass in the list of Ansible Environments of the logged in user.
- Clear sessionStorage object when user logs out.
- Update unit tests.
2018-12-17 11:44:11 -05:00
kialam 9292b21a41 Merge remote-tracking branch 'origin/master' into add-org-new 2018-12-14 10:14:36 -05:00
kialam 7ea5ea2ecd Merge pull request #55 from ansible/ansible-environment-dropdown
Basic Ansible Environment Select Component
2018-12-12 11:03:00 -05:00
kialam 44029c2191 Use object desctructuring. 2018-12-11 16:57:38 -05:00
kialam 9627a73978 Rename AnsibleEnvironmentSelect to AnsibleSelect
- Update references to the component.
2018-12-11 16:42:24 -05:00
kialam 9c7d449a4d Abstract out API get request to Add Org component.
- This makes it so we now have a generic select dropdown where we can pass data down as props.
2018-12-11 16:20:55 -05:00
kialam d047bc876a Basic Ansible Environment Select Component
- Component conditionally renders based on # of virtual environments.
- User can add an Organization and associate it with a virtual environment.
2018-12-10 20:41:47 -05:00
kialam 27e13ca082 Add tests for Organization add view plus code refactoring. 2018-12-10 15:03:33 -05:00
kialam 9400bad990 Linter fixes. 2018-12-10 15:00:49 -05:00
kialam 1dd8175e11 Basic add organization functionality.
- Placeholders for Lookup Modal and Ansible Environment dropdown.
2018-12-10 15:00:16 -05:00
kialam b0855ee33d Fix unhandled promise reject from jenkins. 2018-11-13 13:31:24 -05:00
kialam 03f6e52cf1 Address PR review comments. 2018-11-13 10:55:18 -05:00
kialam 44e9d3919d Update unit tests. 2018-11-13 09:46:43 -05:00
kialam f520be71d6 Begin using async/await. 2018-11-12 13:24:17 -05:00